Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 29 Jul 2022 13:18:49 +0800
From:   Oliver Sang <oliver.sang@intel.com>
To:     Will Deacon <will@kernel.org>
CC:     Peter Zijlstra <peterz@infradead.org>,
        Valentin Schneider <Valentin.Schneider@arm.com>,
        Quentin Perret <qperret@google.com>,
        LKML <linux-kernel@vger.kernel.org>, <lkp@lists.01.org>,
        <lkp@intel.com>, <aubrey.li@linux.intel.com>, <yu.c.chen@intel.com>
Subject: Re: [sched]  9ae606bc74:
 WARNING:at_kernel/rcu/rcutorture.c:#rcu_torture_stats_print[rcutorture]
Message-ID: <YuNtuaIwGknyxJcm@xsang-OptiPlex-9020>
References: <Yt5Qia3AwDOodKI1@xsang-OptiPlex-9020>
 <20220725092057.GB20370@willie-the-truck>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220725092057.GB20370@willie-the-truck>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3/pxK8uxvHSUMBF6cCXzcXtW7E2cIqZd8gOHV+4aXZyFAt3pyNfJYRTUPhq/?=
 =?us-ascii?Q?6BtwuYfNnLsTBrw1x1rF5TiKB0ydIyhI0oecE276c88RPDANIDYLsWrqx7ds?=
 =?us-ascii?Q?7P9Gq4jAzxR/4eACbd7MbydOjN4D8bKEdCB72NST0brEUY6uQa6EbNf7fKZJ?=
 =?us-ascii?Q?wqvWrqZ1DqFm5V37SkL1a9E2eqjb5Oe5+WJWD525oN3sHXyHdzWxXL9FbJgh?=
 =?us-ascii?Q?fZz+JJi83ThWepEjQvVGkXfaLUWJKyjuxn0dqDhAgSCQyVtKPJb6yimZXYWU?=
 =?us-ascii?Q?GqGwsy9s0FqCs0txODcGJtPglOcEOFK/uf97T/0osryIiXunXeuBcpUbNUky?=
 =?us-ascii?Q?SyKF/+mGTsE8tK5h+boyDGLlIKE55XmOf6unDDpmOCQGC6GFXhCv3flPmg9Q?=
 =?us-ascii?Q?HUim3GhRh4rSCMQgh9k2BYMQC0mUD7Y5ZIBMYdOhRH4mtNW/5CrJ4n6W1n5C?=
 =?us-ascii?Q?9ifBvtNwGt2lr6GkjJSEn51ida8BU1AxrIyV2P/1N6nPQTcT4jbj/AAykrow?=
 =?us-ascii?Q?11P0BGp2o6grFjn034rPZGESXfGvLyIefS7n3/tpG/xo6OnoiZA4Ic+s86tU?=
 =?us-ascii?Q?Ok2j9EHEvhSHty1Wvzh4nn/Dh3z8H/s5/4EtnnZxaDwawNC4mQd80l1KaUIp?=
 =?us-ascii?Q?u4d0MIS3wE2mwQIcBZj+FEgvdY7eSk6FoO0BaJpKwqbQNq4CG3xkbCFNCy1T?=
 =?us-ascii?Q?xz4sY0O8mlc7PSkmGKgQEkIWnFninGJUIYfLXhwzIqynQZSS/lZ/yIC5y8WK?=
 =?us-ascii?Q?V9O11QoVpszBfmQfu9FyRAUVKm++P/AqmyIHBgAKC2v5p4EL9U7fVCKDayuF?=
 =?us-ascii?Q?+Bz5tpnwJxxEnM7j1D46sHfH/ULZ5M+dTNJNdU2QObqJRWApxiy9ve1kZ8ha?=
 =?us-ascii?Q?XJntvMHs6rJqV1IqXQKglvcW0k+Po4oVQBKOMVTyCTPuRnA4VME67Pg3LMV7?=
 =?us-ascii?Q?XPjbQ8GvGdEexxOFRkG5Pnw7od1bJdEJmmxZ6dChRqeqVdW2G04rJlY1rCaE?=
 =?us-ascii?Q?o19s+wtEIyWmu3+3ZWFUtF31vyFgiMphfqQ980+Nzk9t7mUVBOxA0Ti/I/ti?=
 =?us-ascii?Q?FX5M4ie1aSZRlApDIcqFTYuGuvT8/OhqXLsafr5tGlWRjEx4C8bt4lqsadCN?=
 =?us-ascii?Q?MstSeeyEfG9GlhZrGnv7qKOmmTpy3U6zj3mzQPRXhh6nTEFo+0dTubBaXJsb?=
 =?us-ascii?Q?t9eWROMoFrTiRubS4fUXdbEZqZ6mBaWgXWh56/iEI4kEweuNJPMiZLQjATeu?=
 =?us-ascii?Q?iZWTUveibYymNmMnwlZLD9x/k8CqCr4YlglmRPZfCUQorXM/tv0qQ5cpe7RL?=
 =?us-ascii?Q?SdZmnR2nIjz7WyDVVosfZmANggyv0InIzKE2auBEnoBMicoVgnbnknl2j5o6?=
 =?us-ascii?Q?Hu7Rm0RMrTFFAeyTa/sMkffRdahlI/88I3GUpaAIazOmOG/Bx+0QfPWzst7F?=
 =?us-ascii?Q?s2n/oXDxpSMCH+HT6oMMzEOzQA+MXCo74a3DFVswBoCAucoJIWuLZ0V6QQJO?=
 =?us-ascii?Q?grIRFUr71ItYg+rV26tXb7ei5vKotPJgRoldeUBqRTZNTeDUZKc8ZqV1B2Te?=
 =?us-ascii?Q?Pzu2hP0XVfZ1CLzTNhUInmei2ZDa3UcmFtoWRgDjfRE5RxEoO8BcyuTKLnU7?=
 =?us-ascii?Q?2g=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d8e3c2d-64d5-479c-b44a-08da7121d76f
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6297.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 05:18:59.1439
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NWPP6jq5ysOcbVa3zwTzUpaA56s77zo6jwF8/5m0+4qzCsafUV3Me/eEIt/LXGwEjCLnIDqpcJ8JYSP1jaoZKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6813
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

hi Will,

On Mon, Jul 25, 2022 at 10:20:58AM +0100, Will Deacon wrote:
> On Mon, Jul 25, 2022 at 04:12:57PM +0800, kernel test robot wrote:
> > 
> > 
> > Greeting,
> > 
> > FYI, we noticed the following commit (built with clang-15):
> > 
> > commit: 9ae606bc74dd0e58d4de894e3c5cbb9d45599267 ("sched: Introduce task_cpu_possible_mask() to limit fallback rq selection")
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> > 
> > in testcase: rcutorture
> > version: 
> > with following parameters:
> > 
> > 	runtime: 300s
> > 	test: cpuhotplug
> > 	torture_type: trivial
> > 
> > test-description: rcutorture is rcutorture kernel module load/unload test.
> > test-url: https://www.kernel.org/doc/Documentation/RCU/torture.txt
> > 
> > 
> > on test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G
> > 
> > caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
> > 
> > 
> > +-------------------------------------------------------------------------+------------+------------+
> > |                                                                         | 304000390f | 9ae606bc74 |
> > +-------------------------------------------------------------------------+------------+------------+
> > | WARNING:at_kernel/rcu/rcutorture.c:#synchronize_rcu_trivial[rcutorture] | 120        | 120        |
> > | RIP:synchronize_rcu_trivial[rcutorture]                                 | 120        | 120        |
> > | WARNING:at_kernel/rcu/update.c:#rcutorture_sched_setaffinity            | 120        | 120        |
> > | RIP:rcutorture_sched_setaffinity                                        | 120        | 120        |
> > | WARNING:at_kernel/rcu/rcutorture.c:#rcu_torture_stats_print[rcutorture] | 0          | 36         |
> > | RIP:rcu_torture_stats_print[rcutorture]                                 | 0          | 36         |
> > +-------------------------------------------------------------------------+------------+------------+
> > 
> > 
> > please be noted, since 9ae606bc74 is kind of old, we also tested on a latest
> > mainline commit:
> > commit 515f71412bb73ebd7f41f90e1684fc80b8730789
> > Merge: 301c8949322fe cf5029d5dd7cb
> > Author: Linus Torvalds <torvalds@linux-foundation.org>
> > Date:   Sat Jul 23 10:22:26 2022 -0700
> > 
> > and confirmed the
> >    WARNING:at_kernel/rcu/rcutorture.c:#rcu_torture_stats_print[rcutorture]
> > still exists.
> 
> I'm not convinced by the bisection -- that commit should't have any effect
> on x86.

Thanks a lot for your information!
we will do some further tests to see if below part could impact x86.
will update you next week. thanks

@@ -3124,9 +3124,7 @@ static int select_fallback_rq(int cpu, struct task_struct *p)

                /* Look for allowed, online CPU in same node. */
                for_each_cpu(dest_cpu, nodemask) {
-                       if (!cpu_active(dest_cpu))
-                               continue;
-                       if (cpumask_test_cpu(dest_cpu, p->cpus_ptr))
+                       if (is_cpu_allowed(p, dest_cpu))
                                return dest_cpu;
                }
        }


> 
> Will