Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp88452imn; Fri, 29 Jul 2022 00:02:29 -0700 (PDT) X-Google-Smtp-Source: AA6agR5QZWX9CjYyMObDShL4O87nT5BPJZzg2kQZ13PZqN2nHp/y/xX7I7wSr0nlnDVd+7jwuZHc X-Received: by 2002:a17:90a:590e:b0:1f1:afeb:996 with SMTP id k14-20020a17090a590e00b001f1afeb0996mr3138366pji.205.1659078148949; Fri, 29 Jul 2022 00:02:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659078148; cv=none; d=google.com; s=arc-20160816; b=qwuCZYfNSZzDh7JgNdwnCZFs//7ALOcT9GxubcmA8qP7ZzglkJM1hxP+qs7m02pqp+ gb93l9DdmAXaaw+TkgTm2e96gGg3Qfxm6T8uGDir44cdb37mobmGOAmJ63/SEE8sDdsD 00XESZFsFTqg0RbfuE3x9uU2oKZR/hgEFa8pANeYaftZdKlUv1e+1YP05WNSV9Wbs442 QKBFLjfkmR2jKnutPpueyfNQDkN3KNZs+/Q48F9RaHngy7jCeXW0iw2MunBes0/X4ChE forMEGEH7r1VoNBmLSs15qJMzVeBrmyy2FjVzR6T5ErrJd101KxZesW5PuLd52AQzIUf Tfhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=X9Z1gP/KeSlFdV4835SNyBMfS7oUH8LcsGy135+GdW0=; b=vN/vXs54BSCwq4uS2YxH2Z3v7EVd6x7wFUkAjx5LvueBPKIrAf0QnoIZtMV0y83Irm YM+Gvf3rX4NHEpFM2zPz2L/2WxcBVZwhEXAm3JDW+UW8Zg3+MD7x1J2S27CRz39ZiZg5 3XdZNF9m3SxsVXkwz0i4IrwzbVa3eBgVhbOlWV66oWEQTklWTEO9CtokbjCgxLGH5tHq kc1ALAZhbZ6rcey+Skt+fYY/vrmadYSvdith++ls/jhwTWtP74wrsTyoJibZw40i8nVk homPdnuKeO8MhEfpc0YQAyhhMbLtSjpW81OV5Ey9gjEQLqfUFB8Z8sIMQK7usFU97Txt z8pQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p5aHYaSN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q186-20020a632ac3000000b0041b96dcd21fsi274439pgq.176.2022.07.29.00.02.13; Fri, 29 Jul 2022 00:02:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p5aHYaSN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234639AbiG2Gv2 (ORCPT + 99 others); Fri, 29 Jul 2022 02:51:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233434AbiG2Gv0 (ORCPT ); Fri, 29 Jul 2022 02:51:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53B8877A59; Thu, 28 Jul 2022 23:51:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D56B0B826F0; Fri, 29 Jul 2022 06:51:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20803C433D7; Fri, 29 Jul 2022 06:51:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659077482; bh=Y+fwoM3j+kiY9u/iHQTKXS3daFS/oyrlt5D21HOO8bQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=p5aHYaSNuQT8YvmPv3CGekypBrbbACWkbwsFrk3avT1fqmpYk41KfMDB3X5qbgU3w gvJ81jw9fHJRxRYXBWlXEEguxEwBY8iyHQvgbtVkFNdHGdCijHjnWqqhPlJEdb97N8 yzOyUl8NdCQx0o3pQCILI8SF51SItOihSRLa4lvYaBWPvHSneoleMCh9gi9hjO3tr7 teVLCXQ01dtW4HVU6rnVWhVN/Vr/Wkl/QtK0tJqkoQjUp4GysPgA1DvK1RuYFcxcTn 00sLJDMsvwEZqAlFsA3BaEWfxQ96je6QyGQ31PPkJk+P9iYtmlPcXMi85Lr9uI3jTu WE6Dj9mPzEWmA== Date: Thu, 28 Jul 2022 23:51:21 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: Li zeming , jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched/net/act: Remove temporary state variables Message-ID: <20220728235121.43bedc43@kernel.org> In-Reply-To: References: <20220727094146.5990-1-zeming@nfschina.com> <20220728201556.230b9efd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Jul 2022 08:30:35 +0200 Jiri Pirko wrote: >> How many case like this are there in the kernel? >> What tool are you using to find this? >> We should focus on creating CI tools which can help catch instances of >> this pattern in new code before it gets added, rather than cleaning up >> old code. It just makes backports harder for hardly any gain. > > What backports do you have in mind exactly? Code backports. I don't understand the question. There's little benefit and we're getting multiple such patches a day.