Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 29 Jul 2022 09:04:31 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Pavel Machek <pavel@ucw.cz>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Linus Walleij <linus.walleij@linaro.org>,
        Tasanakorn Phaipool <tasanakorn@gmail.com>,
        Sheng-Yuan Huang <syhuang3@nuvoton.com>
Subject: Re: [PATCH 3/4] leds: simatic-ipc-leds-gpio: add new model 227G
Message-ID: <20220729090431.565ed505@md1za8fc.ad001.siemens.net>
In-Reply-To: <CAHp75VehvE1cN9kMAhkuRrgek9Tt9OExpYnkPYNqocGPEG6Tew@mail.gmail.com>
References: <20220728155652.29516-1-henning.schild@siemens.com>
        <20220728155652.29516-4-henning.schild@siemens.com>
        <CAHp75VehvE1cN9kMAhkuRrgek9Tt9OExpYnkPYNqocGPEG6Tew@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g40vreZQe/f2UBJFW0G+n2Ps7QEZMgJFDlk1gAvuGfv0xoRyoVdVjDp+u6wG?=
 =?us-ascii?Q?kv5LOKFX3xMgY0REBNsuV3h2ykZ7wqb2DZ7NJrnKXBbNyQPFBuo2B87MI5Hu?=
 =?us-ascii?Q?s4HnbAP5HhYCpgHS+b9Z0B32HO45M09GMCrXFdi5J/x7X5TYVg6gLAtITWFP?=
 =?us-ascii?Q?K5oJhFGitRT2MjPuZCAv1hAT2irNo4Dk4xvrZUX5c3YcxmWKx2m7IqWp/iBE?=
 =?us-ascii?Q?8ZG3nNgBQWGNbUhPfXF6LhTIBQquwm5HkavcuTuSAsfZ9hsR8gNQCmJp08k6?=
 =?us-ascii?Q?CycwdRE8j+RFkknDeo0sJRquui3FQcIHXM1GmH1wdkkkvwEHZjenS9QCsmPd?=
 =?us-ascii?Q?thoaUuDBB+2jcpP3bmFp7qkhrLwMeS7mQHKv1BlaaEtP+nf1i74Xqw3FJ/Ze?=
 =?us-ascii?Q?pDvVmStT2V5LbY7gFJI1J8nmGGJAK1sTRoYDDtSu6MFw5MPwhNEV60+S9hPL?=
 =?us-ascii?Q?VN/pPPD2hzL+c8dKa5Xxntm6hnXFJW0uZgqWPGF7cGa6jYMH6tSFz5cFn0Z6?=
 =?us-ascii?Q?Dl/Wrf+kCaw4s49ptZVG4ckXC8OLP5rLcGeTQJsSaAgzfqYXhXLZaSQ1jIoP?=
 =?us-ascii?Q?1E057NC+66PSobr0GEhIqwgRrAU//nEcWILQv575NGHYcyjNEg1hCmaBodBV?=
 =?us-ascii?Q?MrOojd+u44L+X4oROhaFXW0vPOONCMEFVpKMPPHpCe9irLLOzW4KvQPodDoU?=
 =?us-ascii?Q?HHq0H+EPBfMgWe5tL9+rhezbP14g3uGpmbMqJNELY3M0XQlhVXhs6jmnBvid?=
 =?us-ascii?Q?Qf18zJ0ueaRfrPEUsA8w/yBOQ6Z3fUbiKn2CSiT9R8Zs+pooBRhdAvpdzj/i?=
 =?us-ascii?Q?JHYUvHoHYlZ1tYjZJ90Wp1XLptqH2Q9x+MJ91I0Ud702xfjMy5FuZaNxwlr5?=
 =?us-ascii?Q?9da6e0X6/6bpH4CL3/1pSNKLeoOj4hgHL8dWX7hxmGSZuCEpkidNkQB47HkG?=
 =?us-ascii?Q?c1LNoW57Emipf1XMZUW0iLlE2KpCGZ16qEli0/PELZgdHQPwpddMd02GCjvf?=
 =?us-ascii?Q?bjboNb0VLO4D0LUvqTqTXC8PbFBOpkb7SScCl+LMuPzKGFT7POWm/4ezJ3bA?=
 =?us-ascii?Q?cHpH5mNAov0r5eHlr6vteMBsIcgIl6nvwgGscwv1HTTVAJRRTF3sGgkkdp1m?=
 =?us-ascii?Q?w+7KWRuTCJUn/HzbzeX6MIsB/MfBxyqd1KXIq7as5Hhsqkn9UMWAawVKbCEf?=
 =?us-ascii?Q?BS84QbnmxxFNq/Z6wzknLmO0kc1xIAxgj1qt8c7bVE/e0FUv8t/9eHxV3yfG?=
 =?us-ascii?Q?/iYWNI/dNEwIEuWhVAVEjE21ceCeElYEc21cWVts2cApFEDA0D3LnLdfynzr?=
 =?us-ascii?Q?1QR0gkqumCgoANuHzV5qRwszgB3giydJ6LDw3/0DgB8bi50lfSaaEL1MpSff?=
 =?us-ascii?Q?sCJ2g5kOoRsXMIKo7mtwDMnFnn5dBai31e0e0AmO/008Mu/ThEgOmQn4x5NW?=
 =?us-ascii?Q?ZX4AsGVbKLAENRdbnsJ6I4J+fpgCP/rHwxHlbdHWKpH4PZpz7w3t5Ly80lzP?=
 =?us-ascii?Q?NgIXDRzQBJfBD6rvxE3EYfK6fST8fLKBF6kac7CaFPxoBoXPpHSvTF2gu0BW?=
 =?us-ascii?Q?/ydehopPT0AxP9/6joOsty+tBrSbGDDrB2uSwrLYXastZqTWaM/1yv/YTYQ8?=
 =?us-ascii?Q?Tu4pAExs5gYk76VQnSn52d3au7r/dLPyjWFY5u9G79lmIvA3s9vyVHwxCGAM?=
 =?us-ascii?Q?5MeF2w=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 374f4df0-8a02-4410-854b-08da71309c0e
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 07:04:42.0037
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hjCyoBvDobGwLava1d4x/+40nINIP+RiZcBZsUW2y4mtDpYor/isM1PP+35MSNtzRGMZoh/w6iu649AEb8MZ6zOTLMesjNX4koYYU4O4oq0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB2843
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Thu, 28 Jul 2022 23:41:31 +0200
schrieb Andy Shevchenko <andy.shevchenko@gmail.com>:

> On Thu, Jul 28, 2022 at 5:57 PM Henning Schild
> <henning.schild@siemens.com> wrote:
> >
> > This adds support of the Siemens Simatic IPC227G. Its LEDs are
> > connected to GPIO pins provided by the gpio-f7188x module. We make
> > sure that gets loaded, if not enabled in the kernel config no LED
> > support will be available.  
> 
> ...
> 
> > +       switch (plat->devmode) {
> > +       case SIMATIC_IPC_DEVICE_127E:
> > +               simatic_ipc_led_gpio_table =
> > &simatic_ipc_led_gpio_table_127e;
> > +               break;
> > +       case SIMATIC_IPC_DEVICE_227G:  
> 
> > +               if (!IS_ENABLED(CONFIG_GPIO_F7188X))
> > +                       return -ENODEV;  
> 
> Hmm... What is the difference with the 127E model in the sense of the
> driver absence? Why do we need this check?

What happens when the GPIO_LOOKUP_IDX does not find anything is an
endless printing of all missing lookups, actually pretty frequently so
that the kernel log becomes useless. I did not look deeper but i guess
"leds-gpio" will go into some sort of polling and wait for those pins.

The debian configured kernels i used so far for my work always had
PINCTRL_BROXTON, i guess if that was not available i would end up in
the polling/printing loop as well. I never tried without, just found
that polling thing when working on this model.

In fact the 127E will likely also need to check for PINCTRL_BROXTON
somehow. Or maybe the "leds-gpio" platform device needs to be
registered in a way where it will not go into polling/printing. I will
study the code to see if there is a way to go without polling but then
i might need some sort of serialization so i go not try and
register+fail before those pins exist.

Pavel maybe you have an idea what to do here.

> > +               request_module("gpio-f7188x");  
> 
> I'm not sure why you need request_module().

The difference to "pinctrl-broxton" is that it comes up on its own
because it has autoloading support. And this one only probes on
=m + modprobe or =y.

Henning

> > +               simatic_ipc_led_gpio_table =
> > &simatic_ipc_led_gpio_table_227g;
> > +               break;
> > +       default:
> > +               return -ENODEV;
> > +       }  
>