Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 29 Jul 2022 09:07:08 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     <linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        "Bartosz Golaszewski" <brgl@bgdev.pl>,
        Linus Walleij <linus.walleij@linaro.org>,
        Tasanakorn Phaipool <tasanakorn@gmail.com>
Cc:     Sheng-Yuan Huang <syhuang3@nuvoton.com>,
        Pavel Machek <pavel@ucw.cz>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH 0/4] add support for another simatic board
Message-ID: <20220729090708.43d2658a@md1za8fc.ad001.siemens.net>
In-Reply-To: <20220728155652.29516-1-henning.schild@siemens.com>
References: <20220728155652.29516-1-henning.schild@siemens.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iapEYOSIaRWQytjVhHKOkfGwbVr8QRXTmcaD4cVkPoUMHW0bSqQZfCh5BgdK?=
 =?us-ascii?Q?TNLezY1MyEEjVW12TCQsBKqWbGU7E8vi249tOue1qdyYVDnp1NYLh/UXDsCs?=
 =?us-ascii?Q?2TcJb03XonARzqHOvOYps0WTVeu/d5PWmTNO80ISIC/rTez3zESwC+7DwwXK?=
 =?us-ascii?Q?wdW+UDIkqoP2yhfqCdvtT1KMki/mudFwi+LzP7LhXMmjQhDExLCy87AYFJ08?=
 =?us-ascii?Q?UBx3xKJbBSuG4/uDzy/a9jdM6vKYEdKh1PdIMLVPA4KOyeflW8GGmwAcMuzQ?=
 =?us-ascii?Q?n8/ckrZQldHQpiVLQ07ItUrn5lcaJV+ZPwB7WtfyPbsgsH1+DDMwgEcncjUJ?=
 =?us-ascii?Q?uwzsVQRjSOXbCavyE6DHBGMvanrpj8SrZ5w8ZSPrEqkd6gGYreAPvHEX0QT5?=
 =?us-ascii?Q?MSt2SzDI5sTMbt06aWitogPcRKrOLrNcio9KsgnWhnoLo5HwxpDN0GisDe4x?=
 =?us-ascii?Q?2+3PbNstY7mt+BXXqzv/x9Xp6sWDFZ+9MqDP8Jw01h/Bsv8+kEX0kNcZ7/iH?=
 =?us-ascii?Q?FhhgMBSzEtoqQK5ECZM+hVAp54y/W0cvoKLO6aXWtIUs9cDkNh8JTvYp7TTE?=
 =?us-ascii?Q?szvxVTK6GNVfOIr4LyeP6k3YuuYwtYpqfSZHxNFWKgzpjIKGjo4HoHn5qv0E?=
 =?us-ascii?Q?MPu6QtjFb9tVfOSwco2S3rs0GUghORiJsbdKFlkQx3pgpyafAkBJlApj5PcT?=
 =?us-ascii?Q?GrM57WfQtsntQaZ6RKQAeq3+9aZPAlMqcER75POkvk0t1AmsReiUELackWK4?=
 =?us-ascii?Q?9R641qePoWOG1T1ZLrShRrIyhLNjk09sJIRxOmTLgfQqjlaDfoGFUXuSo2P2?=
 =?us-ascii?Q?TZTYmmxPI5Jy0GrInQm1iKe8yFU+Ru44gBT+7/1nndavjFiENd0itCJ1htw3?=
 =?us-ascii?Q?SuaqQiKQMvoANDDH9SMVhuUYlpMA60+3Gzx90QKaBDwoTT2ut8iAS7F/cQTu?=
 =?us-ascii?Q?Eqx5vhIxiGD/YDUyRGjltJS42OYNDNBATVZGGz02uh8aOx5lL3hqYLsfsbp5?=
 =?us-ascii?Q?0ViQgREmQ7Kon9StKgG41fZrOk9dCz6a6AZ52tVQVwfnf4zc4uE6SAlajUaC?=
 =?us-ascii?Q?kQf45zo34a/G2Peh/oHsdfYX/zqrW8C7Bt65KxrMuC8Wa04UBqy5p6RhDaxr?=
 =?us-ascii?Q?o71jd9t0PZqzVRlj/KdmaruU7P7RM1cV2iGtDMN/h659UL9uSKerS3LSvQpm?=
 =?us-ascii?Q?94YEZIj/q9Und24xxzj1gwXDFnVjmcF2DdQVYVsqkfoSZvGFYZLjO+uP0gn2?=
 =?us-ascii?Q?pfkEcf+400TunD1hor2VVA1SVggkrNT9NZj5Cn9qZN3DpYp45h+Ja3Mx/nXy?=
 =?us-ascii?Q?Q7DE+sS0f2S+GWnKqlhsy5HwVcAFvFiYvf4qIOBN/con9Kj6l8Srtag52NaD?=
 =?us-ascii?Q?0YAX/D7Dff/+18HQ2/T2hITBDbeNp6HOBZvR9k2AHx/uOicq/0A0EuB2dheA?=
 =?us-ascii?Q?fCHCIvDtVegI1yE0c+GpXi9Qi8I6NFc5xH2oR9MCdaXvZNENUAH9eyXqfWJI?=
 =?us-ascii?Q?LGx3blCkTkEbFkIdNVXfTK+hF1yttBW2A34lvPT7tzmx0XAyHNM6JMTzWfLW?=
 =?us-ascii?Q?s7F7fH3xqY1pw90m6Yp9zRqOI++uHhuqvTv52c2jnnnROSKsQMnyAflv+d2r?=
 =?us-ascii?Q?voYEga7PIi119Tz7PLEI23nvUxWaAgfgtxzx7smbdf+BDwd8SpjJ7r9jyTvY?=
 =?us-ascii?Q?aZtjiA=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f163528-2606-4d1b-6f81-08da7130f958
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 07:07:18.4986
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 861yADOPEglKzc/lHnf3fkMeIM9BpRlfa0KZTlgmZR0ogbbkBxXqICR4t946YfC1haJxAJnc4xpGNlsazMYizOC4pjtu1RZhnGUkoEa0/ro=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR10MB4656
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I wanted to send this series to a wider audience, somehow i messed that
up and might have to send again. Maybe the v5, and if there is no
changes i might send again as v4.

Henning

Am Thu, 28 Jul 2022 17:56:48 +0200
schrieb Henning Schild <henning.schild@siemens.com>:

> This series first enables a SuperIO GPIO driver to support a chip from
> the vendor Nuvoton, the driver is for Fintek devices but those just
> are very similar. And in watchdog and hwmon subsystems these SuperIO
> drivers also share code and are sometimes called a family.
> 
> In another step the individual banks receive a label to tell them
> apart, a step which potentially changes an interface to legacy users
> that might rely on all banks having the same label, or an exact
> label. But since a later patch wants to use GPIO_LOOKUP unique labels
> are needed and i decided to assign them for all supported chips.
> 
> In a following patch the Simatic GPIO LED driver is extended to
> provide LEDs in case that SuperIO GPIO driver can be loaded.
> 
> Last but not least the watchdog module of that same SuperIO gets
> loaded on a best effort basis.
> 
> Note similar patches have appreared before as
>   "[PATCH v3 0/1] add device driver for Nuvoton SIO gpio function"
> The main difference here is that i added chip support to an existing
> driver instead of creating a new one. And that i actually propose all
> patches and do not just have the LED patch for Simatic as an example.
> Also note that the patches are based on
>   "[PATCH v6 00/12] platform/x86: introduce p2sb_bar() helper"
> 
> Henning Schild (4):
>   gpio-f7188x: Add GPIO support for Nuvoton NCT6116
>   gpio-f7188x: use unique labels for banks/chips
>   leds: simatic-ipc-leds-gpio: add new model 227G
>   platform/x86: simatic-ipc: enable watchdog for 227G
> 
>  drivers/gpio/gpio-f7188x.c                    | 192
> +++++++++++------- drivers/leds/simple/simatic-ipc-leds-gpio.c   |
> 42 +++- drivers/platform/x86/simatic-ipc.c            |   7 +-
>  .../platform_data/x86/simatic-ipc-base.h      |   1 +
>  include/linux/platform_data/x86/simatic-ipc.h |   1 +
>  5 files changed, 158 insertions(+), 85 deletions(-)
>