Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 29 Jul 2022 09:20:21 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Bart Van Assche <bvanassche@acm.org>
Cc:     Daniil Lunev <dlunev@chromium.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Avri Altman <avri.altman@wdc.com>,
        Bean Huo <beanhuo@micron.com>,
        Daejun Park <daejun7.park@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        Sohaib Mohamed <sohaib.amhmd@gmail.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2] ufs: core: print capabilities in controller's sysfs
 node
Message-ID: <YuOKNX4mWCb1LUrg@kroah.com>
References: <20220729090521.v2.1.Id612b86fd30936dfd4c456b3341547c15cecf321@changeid>
 <3f96d798-e9bb-15d8-65b9-2383e112c654@acm.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3f96d798-e9bb-15d8-65b9-2383e112c654@acm.org>
Precedence: bulk

On Thu, Jul 28, 2022 at 04:23:16PM -0700, Bart Van Assche wrote:
> On 7/28/22 16:05, Daniil Lunev wrote:
> > +What:		/sys/bus/platform/drivers/ufshcd/*/caps
> > +What:		/sys/bus/platform/devices/*.ufs/caps
> > +Date:		July 2022
> > +Contact:	Daniil Lunev <dlunev@chromium.org>
> > +Description:	Read-only attribute. Enabled capabilities of the UFS driver. The
> > +		enabled capabilities are determined by what is supported by the
> > +		host controller and the UFS device.
> > +		Format: 0x%08llx
> 
> This documentation is useless since the meaning of the individual bits has
> not been documented.

Yeah, that's not ok, where are these bits coming from and what userspace
tools will be using them?

thanks,

greg k-h