Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220729090521.v2.1.Id612b86fd30936dfd4c456b3341547c15cecf321@changeid>
 <3f96d798-e9bb-15d8-65b9-2383e112c654@acm.org> <YuOKNX4mWCb1LUrg@kroah.com>
In-Reply-To: <YuOKNX4mWCb1LUrg@kroah.com>
From:   Daniil Lunev <dlunev@chromium.org>
Date:   Fri, 29 Jul 2022 17:47:46 +1000
Message-ID: <CAONX=-eCX=n_JxHFTPHzLv+eaPpVs+Eqn+RF04FTdFgQzizC7w@mail.gmail.com>
Subject: Re: [PATCH v2] ufs: core: print capabilities in controller's sysfs node
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Bart Van Assche <bvanassche@acm.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Avri Altman <avri.altman@wdc.com>,
        Bean Huo <beanhuo@micron.com>,
        Daejun Park <daejun7.park@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        Sohaib Mohamed <sohaib.amhmd@gmail.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> Yeah, that's not ok, where are these bits coming from
There has been a few more iterations on the patch, in the latest state only
Clock Scaling and Write Booster are exposed as individual nodes.

> what userspace tools will be using them?
In ChromeOS we want to explicitly control WriteBooster state, but for that
the user space needs to know when it is supported but off, and when it is
not supported at all. On top of it, Clock Scaling complicates the story since
it disables the control via wb_on node. That is something I need to figure
out separately.

--Daniil