Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Fri, 29 Jul 2022 09:51:18 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Doug Anderson <dianders@chromium.org>
Cc:     Abhinav Kumar <quic_abhinavk@quicinc.com>,
        Rob Clark <robdclark@gmail.com>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        freedreno <freedreno@lists.freedesktop.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        LKML <linux-kernel@vger.kernel.org>,
        Sankeerth Billakanti <quic_sbillaka@quicinc.com>
Subject: Re: [RFC PATCH] drm/edid: Make 144 Hz not preferred on Sharp
 LQ140M1JW46
Message-ID: <20220729075118.ofnpk52tk4usm3n3@penduick>
References: <20220721152314.RFC.1.Ie333b3e4aff6e4a5b58c4aa805e030e561be8773@changeid>
 <269f2610-425b-f296-dcfc-89bdc2e1d587@quicinc.com>
 <CAD=FV=XSVXasU5PMR2kL0WQjQ458xDePuTGd1m14_v9JO5B6oA@mail.gmail.com>
 <CAF6AEGv_Vikf80v-7ccz90fvGPrk5pV1tOxRoWKxKHYuEW8=aA@mail.gmail.com>
 <5c8ca71c-5f0b-d5f5-9f16-e312dec0d01b@quicinc.com>
 <CAD=FV=UGYV1mZenDCRrbpC+gpE12-Uis7fm_=H3PeEjK=t36yA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="oklsttshcgwhfm5m"
Content-Disposition: inline
In-Reply-To: <CAD=FV=UGYV1mZenDCRrbpC+gpE12-Uis7fm_=H3PeEjK=t36yA@mail.gmail.com>
Precedence: bulk


--oklsttshcgwhfm5m
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 28, 2022 at 02:18:38PM -0700, Doug Anderson wrote:
> Hi,
>=20
> On Thu, Jul 28, 2022 at 10:34 AM Abhinav Kumar
> <quic_abhinavk@quicinc.com> wrote:
> >
> > Hi Rob and Doug
> >
> > On 7/22/2022 10:36 AM, Rob Clark wrote:
> > > On Fri, Jul 22, 2022 at 9:48 AM Doug Anderson <dianders@chromium.org>=
 wrote:
> > >>
> > >> Hi,
> > >>
> > >> On Fri, Jul 22, 2022 at 9:37 AM Abhinav Kumar <quic_abhinavk@quicinc=
=2Ecom> wrote:
> > >>>
> > >>> + sankeerth
> > >>>
> > >>> Hi Doug
> > >>>
> > >>> On 7/21/2022 3:23 PM, Douglas Anderson wrote:
> > >>>> The Sharp LQ140M1JW46 panel is on the Qualcomm sc7280 CRD reference
> > >>>> board. This panel supports 144 Hz and 60 Hz. In the EDID, the 144 =
Hz
> > >>>> mode is listed first and thus is marked preferred. The EDID decode=
 I
> > >>>> ran says:
> > >>>>
> > >>>>     First detailed timing includes the native pixel format and pre=
ferred
> > >>>>     refresh rate.
> > >>>>
> > >>>>     ...
> > >>>>
> > >>>>     Detailed Timing Descriptors:
> > >>>>       DTD 1:  1920x1080  143.981 Hz  16:9   166.587 kHz  346.500 M=
Hz
> > >>>>                    Hfront   48 Hsync  32 Hback  80 Hpol N
> > >>>>                    Vfront    3 Vsync   5 Vback  69 Vpol N
> > >>>>       DTD 2:  1920x1080   59.990 Hz  16:9    69.409 kHz  144.370 M=
Hz
> > >>>>                    Hfront   48 Hsync  32 Hback  80 Hpol N
> > >>>>                    Vfront    3 Vsync   5 Vback  69 Vpol N
> > >>>>
> > >>>> I'm proposing here that the above is actually a bug and that the 6=
0 Hz
> > >>>> mode really should be considered preferred by Linux.
> >
> > Its a bit tricky to say that this is a bug but I think we can certainly
> > add here that for an internal display we would have ideally had the
> > lower resolution first to indicate it as default.
>=20
> Yeah, it gets into the vagueness of the EDID spec in general. As far
> as I can find it's really up to the monitor to decide by what means it
> chooses the "preferred" refresh rate if the monitor can support many.
> Some displays may decide that the normal rate is "preferred" and some
> may decide that the high refresh rate is "preferred". Neither display
> is "wrong" per say, but it's nice to have some consistency here and to
> make it so that otherwise "dumb" userspace will get something
> reasonable by default. I'll change it to say:
>=20
> While the EDID spec appears to allow a display to use any criteria for
> picking which refresh mode is "preferred" or "optimal", that vagueness
> is a bit annoying. From Linux's point of view let's choose the 60 Hz
> one as the default.

And if we start making that decision, it should be for all panels with a
similar constraint, so most likely handled by the core, and the new
policy properly documented.

Doing that just for a single panel is weird.

Maxime

--oklsttshcgwhfm5m
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABMIAB0WIQTXEe0+DlZaRlgM8LOIQ8rmN6G3ywUCYuORdgAKCRCIQ8rmN6G3
y0z+AP9ojmTlQhu5iNapifR8TkVj5GwhktAW8TUwGoGL14Ci4QEA9Otjl7UEG2oM
Fy+ESHA52LQtiaNfS8fUHkPZnBQYz6Q=
=cdJ8
-----END PGP SIGNATURE-----

--oklsttshcgwhfm5m--