Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a006610c-f02d-4286-9187-1ffdd5759c81@amd.com>
Date:   Fri, 29 Jul 2022 16:47:39 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v3] ASoC: amd: acp: Initialize list to store acp_stream
 during pcm_open
Content-Language: en-US
To:     Takashi Iwai <tiwai@suse.de>
Cc:     Mark Brown <broonie@kernel.org>, alsa-devel@alsa-project.org,
        vsujithkumar.reddy@amd.com, Vijendar.Mukunda@amd.com,
        Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com,
        ssabakar@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20220728124057.54259-1-venkataprasad.potturu@amd.com>
 <YuKF4l68sLKkjcmQ@sirena.org.uk>
 <3d351235-c11a-234d-7722-447b4f0442e7@amd.com> <87sfmkp520.wl-tiwai@suse.de>
From:   Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
In-Reply-To: <87sfmkp520.wl-tiwai@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzJFNTZjWlFEZmRBQnUxTFV2UjArcFBsM3BMbml0U0FYeFErdUZDS3BJeFp3?=
 =?utf-8?B?N1BKT1RpaTNHL3dTWDd0bWpnVjJNTnBVdzRJTnhBeCs4ZFBHVXJtbXFsSGc5?=
 =?utf-8?B?NkIzVUJreVZQcmMraEtJSlU0bTZJQnVGbElCaSt1c0FlN0QydnBoRlpJamxw?=
 =?utf-8?B?M0ZmZk1ucS8vU0lnREJNbTZYUFpFZEpVUlZwdWNtRUlFRGhZRDE5WkJkZENO?=
 =?utf-8?B?YnFzVUJ1aU5SeHNGeWc4YndYcjlIVlNSMHI3T0krV2NkK3ZJdnNzbEg2V1Qw?=
 =?utf-8?B?WUZxTUpZQXhDYUlWOFc4RnA3M05FcTZOWUdrbWpVZ0k4amI3T1pEVkVncEs3?=
 =?utf-8?B?SHZyd3p1WFRYaDlMMWJEV2ZXcWNJV24yRlp5UU0rdUpVZEpZSXpGNEZSR0tQ?=
 =?utf-8?B?WmJrTUlwcWFvdHFLREI2Y0d5MkpiN29ic2FXY3Y4OUVjR1JTZDR3aytsK1dv?=
 =?utf-8?B?ZEpXZVIwblFqN2EwZmVYeGloN3Nza1lOU1N4c0lyQzc0UmtZc1l2V1hPTU9E?=
 =?utf-8?B?VllENHZOeE03ZTIyaW9kdWpubTBWSlhyRElSRmdJdVpOTDZmNi91K3BPL0kw?=
 =?utf-8?B?bVVWNWZTWTBZdUsvMEdwcmZOMXZMVzR5Mmg1TzJNNXVVR2VwczE1Nkw4Q25w?=
 =?utf-8?B?dUpHYndzSGNYaDQ2NnFOc3dtNVlFbmpQZDJRekpncmVXOEZEekRHRlEvSmZi?=
 =?utf-8?B?NnRhU1daZGZ0Q2M3VktNN1VkMjlqcmEzWmo4aG1MdS9kSkF2TkdVMEdUSkUr?=
 =?utf-8?B?R2ZiVjJxNUJ2MGhEbUZGdjlXM3YzanJxK3d1OFJsT25QYzJRK0FrNy82UGFj?=
 =?utf-8?B?dTI1cllQbUxUQkxDNDNRck1MNzhqSGRHYk5WWldNWU9YOG9TbUNJR2s4UC9w?=
 =?utf-8?B?ZWlTaDFvM0NUclZWcHlFMTBvdVc0VjlDL205SWtzNEk2a2UyQ2ZTaUYxckdz?=
 =?utf-8?B?T2YyeFI2aUN0bms2eTREWEg0d3BBbTdIcHYwRDNnaWRORE95UkR4cjlIdi93?=
 =?utf-8?B?RjVZTyt1MFBFMmVTV2RzcUxpb0xHUXY0N0piQzJFb1ZLYXh2cHA2c3dGbmx3?=
 =?utf-8?B?WmxFR1lveU4rcFZ1cnY5cWZmS1czUGxGRjZQb1U4U3RJb01xbngrd0dGZHAx?=
 =?utf-8?B?WERqaVVydk9lNmsxaFZpaUdmc1ZnVC9OSW1UWjB5SmpMUm4xMzlsMTltY0Vm?=
 =?utf-8?B?ZWVZbFZMRnM5UjVyM2JScldyNUZibzFiSmZISzF0cVlXQzZzR1B6bWN6UzJm?=
 =?utf-8?B?OEo1MEJRWUJEOTMzU2pScEhpTmRwaDZaQ2NJOFpZMkNZQ0p3S3lUS09BWTdn?=
 =?utf-8?B?UExwR1c5NE1yb1RLM1dvL2pyZDJjNHF3dmx5YkdndkdGNXNIVFArdm5uWHBm?=
 =?utf-8?B?bnB6c3Jadmh6eGFYeGllZ3RLUTh2UzFZSG5XYWJLWExwZVlZVi8rWnZjZnV0?=
 =?utf-8?B?c2pEQXQ1RTFzTEd1aWx0MVQvaWVBdUVJcmszd2pEaTZuU3ZtWFRFYmdpNDRI?=
 =?utf-8?B?NHovNHA1c0YwRzZ6enJnV0dNa1NvUE4xcHZ5YUNIK0dRMlVobms0bStGVjNr?=
 =?utf-8?B?eXZFM3JoKzA3ZktZRjc3aUpHZ0JiMUJLVlMrWHQzby9uaEJvS2kySTU3em1k?=
 =?utf-8?B?M0RrUXRFMlBka2xBQ09Zb0p1YktoOFVJQUdWdnBUL2lLN2ZZWEM5ejhaWWY2?=
 =?utf-8?B?UERjczRYNGhiQjZSNEdRVVFBU1RtVzh3eU12Y0VFLzJ4alI2aEsyUlNaTnVG?=
 =?utf-8?B?U0VjMEhTS1Y4Nm82NUxVT3FMU0M1Z2ZqcW11U3M0YTVGdkVVQ0xuNlBwZko3?=
 =?utf-8?B?cVI2Z0N2Vjl3RS9GLzIzS1N0T0lRQmw1Sy9UbjhiRWJwNjRKaThhbE1ydUNa?=
 =?utf-8?B?czJTOE9GdnpNVmtrRG84dUtvamVidlQ4VE81TWxHZnFKbmpQVkthUEhCOWFF?=
 =?utf-8?B?MFFicEtBNGczaUY0WG5ma3pObEFTMk00MlJrd3BMajBXVFpxMEpVU3lYdEhU?=
 =?utf-8?B?YXBuY1dZSTlBS1o4c1hmZkxmNUMva2VnVklXcTJvWjdRb0tWMzJnaXFDTWJt?=
 =?utf-8?B?L1hSeXN4NXNpZHlFU24wRVF3Uys4ZE5mMXZFbktkakUyYkxOQ29TeWRmUUVT?=
 =?utf-8?Q?UVJSteAjc5J5ppo4PngMqthRV?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bae2cfee-a598-4b91-aebb-08da71538579
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5951.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 11:14:36.5351
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bbpiKGFnVhfO/SvYGtxP6XpxSOR9NRrhMN4gnp6RJU+JA6gEyQyzqfujARuUCxrdqXepeb3FmMv2EOuOHJdpeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6245
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/29/22 16:19, Takashi Iwai wrote:
Thanks for your time.
> [CAUTION: External Email]
>
> On Fri, 29 Jul 2022 12:34:51 +0200,
> Venkata Prasad Potturu wrote:
>>
>> On 7/28/22 18:19, Mark Brown wrote:
>> Thanks for your time.
>>
>>      On Thu, Jul 28, 2022 at 06:10:50PM +0530, Venkata Prasad Potturu wrote:
>>
>>          @@ -104,14 +105,13 @@ static irqreturn_t i2s_irq_handler(int irq, void *data)
>>
>>                ext_intr_stat = readl(ACP_EXTERNAL_INTR_STAT(adata, rsrc->irqp_used));
>>
>>          -     for (i = 0; i < ACP_MAX_STREAM; i++) {
>>          -                           stream = adata->stream[i];
>>          +     spin_lock_irqsave(&adata->acp_lock, flags);
>>          +     list_for_each_entry(stream, &adata->stream_list, list) {
>>
>>      If we're already in an interrupt handler here (presumably not a threaded
>>      one) why are we using irqsave?
>>
>> Yes, your statement make sense, I have followed below statement in kernel
>> document. so used irqsave in interrupt context as well.
>>
>> We will change it to spin_lock() and send it in the next version.
>>
>> statement:- spin_lock_irqsave() will turn off interrupts if they are on,
>> otherwise does nothing (if we are already in an interrupt handler), hence
>> these functions are safe to call from any context.
> Also the open and close callbacks are certainly non-irq context, hence
> you can use spin_lock_irq() instead of irqsave(), too.

Okay. Thanks for your suggestion.

We will use accordingly.

>
>
> Takashi