Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 29 Jul 2022 15:03:05 +0300
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     Jarkko Sakkinen <jarkko@profian.com>,
        Harald Hoyer <harald@profian.com>,
        Sean Christopherson <seanjc@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "open list:KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86)" 
        <kvm@vger.kernel.org>,
        "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" 
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: SVM: Dump Virtual Machine Save Area (VMSA) to klog
Message-ID: <YuPMeWX4uuR1Tz3M@kernel.org>
References: <20220728050919.24113-1-jarkko@profian.com>
 <a9da5c1e-eca9-b3e7-3224-c9d5a26287fb@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a9da5c1e-eca9-b3e7-3224-c9d5a26287fb@redhat.com>
Precedence: bulk

On Thu, Jul 28, 2022 at 05:15:43PM +0200, Paolo Bonzini wrote:
> On 7/28/22 07:09, Jarkko Sakkinen wrote:
> > As Virtual Machine Save Area (VMSA) is essential in troubleshooting
> > attestation, dump it to the klog with the KERN_DEBUG level of priority.
> > 
> > Cc: Jarkko Sakkinen <jarkko@kernel.org>
> > Suggested-by: Harald Hoyer <harald@profian.com>
> > Signed-off-by: Jarkko Sakkinen <jarkko@profian.com>
> > ---
> >   arch/x86/kvm/svm/sev.c | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> > index 0c240ed04f96..6d44aaba321a 100644
> > --- a/arch/x86/kvm/svm/sev.c
> > +++ b/arch/x86/kvm/svm/sev.c
> > @@ -603,6 +603,9 @@ static int sev_es_sync_vmsa(struct vcpu_svm *svm)
> >   	save->xss  = svm->vcpu.arch.ia32_xss;
> >   	save->dr6  = svm->vcpu.arch.dr6;
> > +	pr_debug("Virtual Machine Save Area (VMSA):\n");
> > +	print_hex_dump(KERN_CONT, "", DUMP_PREFIX_NONE, 16, 1, save, sizeof(*save), false);
> > +
> >   	return 0;
> >   }
> 
> Queued, thanks.
> 
> Paolo

Ugh, I made a mistake, sorry. 

It should have been:

print_hex_dump(KERN_DEBUG, "VMSA:", DUMP_PREFIX_NONE, 16, 1, save, sizeof(*save), false);

I sent wrong version of the patch.

BR, Jarkko