Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Pandey, Radhey Shyam" <radhey.shyam.pandey@amd.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     "michal.simek@xilinx.com" <michal.simek@xilinx.com>,
        "nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
        "claudiu.beznea@microchip.com" <claudiu.beznea@microchip.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "ronak.jain@xilinx.com" <ronak.jain@xilinx.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "git@xilinx.com" <git@xilinx.com>, "git (AMD-Xilinx)" <git@amd.com>
Subject: RE: [PATCH net-next 2/2] net: macb: Add zynqmp SGMII dynamic
 configuration support
Thread-Topic: [PATCH net-next 2/2] net: macb: Add zynqmp SGMII dynamic
 configuration support
Thread-Index: AQHYnaLjy2AcewErSEyspw5q+NWPga2NwKqAgAFZDXCAAD4PgIABo9kwgARNpXA=
Date:   Fri, 29 Jul 2022 12:16:39 +0000
Message-ID: <MN0PR12MB59535036A5EA7F7EE488FC56B7999@MN0PR12MB5953.namprd12.prod.outlook.com>
References: <1658477520-13551-1-git-send-email-radhey.shyam.pandey@amd.com>
 <1658477520-13551-3-git-send-email-radhey.shyam.pandey@amd.com>
 <Yt15J6fO5j9jxFxp@lunn.ch>
 <MN0PR12MB59537FD82D25E5B6BE17D1B6B7959@MN0PR12MB5953.namprd12.prod.outlook.com>
 <Yt7OqU9LXl4SDqYx@lunn.ch>
 <MN0PR12MB5953571B73BE19D01BCF12D4B7949@MN0PR12MB5953.namprd12.prod.outlook.com>
In-Reply-To: <MN0PR12MB5953571B73BE19D01BCF12D4B7949@MN0PR12MB5953.namprd12.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?noYQZ2AawUd8OHjnSQzTFJohE1EsDWtZDU4aBKXSU36DAoxr3xMUb0b8JOdz?=
 =?us-ascii?Q?PBxNPiFdPCJwfXzQVqEeVnihJTXhXvvpV34IbKgCIfZ/zCfF3WRC1kgYnJ9X?=
 =?us-ascii?Q?8vOI/ciQgYKz9upq+3luDRH6xY1KAtpnvxh4y1/iTvqLZzYXY6rl3MAEM3Ln?=
 =?us-ascii?Q?Sw01IHHH1xJf61MbycVhGfvtEwNiyDOiFYsjW8kFt1BLzp22CNhBn+imcg7k?=
 =?us-ascii?Q?++BOlRHR2De3PRfGAwkLk598PDTR4bkH8w+A09fBa+ESSxc5F1KiqJBnCmlo?=
 =?us-ascii?Q?g1x/2Wm871FK+K5dgaxTQOLAAmE99bLyQTjDbiPLN63gB28mv7+vqaG33Rct?=
 =?us-ascii?Q?w9mUu1hCf3EvkK6L6ZGjBWEjZmzjcrziELCIuFiy/YTz97yiXiN1VlCIA+Ze?=
 =?us-ascii?Q?uVWkf2TrG3Y2lW8zgLrb6kIxh9QqXO5WqLwSRA8EL00xmArWIhYvb1mCYHxC?=
 =?us-ascii?Q?K/oqlzcd6tkwfdP1294rSkDv3htQWuqLhCDZktmg6J42zPL/MouRQ0a5O5si?=
 =?us-ascii?Q?eNEqqZfQzieWoIXRmiftBSdJlT1eVQ1XQJmJuQwKngP6HlW8Ftn/xo0dgXKo?=
 =?us-ascii?Q?Q4MyP0UgGbekl0mP33ijm8CpPMnXk0WXtFfF69pZ/OQzVu6kfCni1uH5wDJJ?=
 =?us-ascii?Q?3gnn5vD4KOY/qV2IMgAvekTbt08o0lk3FjZXH0cv2a7lKrhwl5NctsBfj3sU?=
 =?us-ascii?Q?Arcc7gSSburGmwhGWlgY1gNUvZu8Qfl1+ObrTN7l4vfsOvKrKTqDVmN1sNFZ?=
 =?us-ascii?Q?cNK9Bw7ZPz9JGp2ec3FckxGuxIlugtV13aXdQjizmE+lqDcECrpiPHfbM2Z9?=
 =?us-ascii?Q?VbkF/gM4UbUn6zDvMCihEJFohhYYmaAU1ISoxJ7A9lEAmGtDS+r7dtUQ1jSP?=
 =?us-ascii?Q?WP4tNJ8fb2/JAHv+v4jkOX+DEXYra5W6y3zoxblhu8IGyhlORIT5XhgI8RSo?=
 =?us-ascii?Q?sVA72YgTJGQI84/JOAoYDhD3kzELo1RbNHIQ/vdV2RzsCvq+5MxVtsp5fhme?=
 =?us-ascii?Q?xSYtKmD9VMeYDUyLtzFxtzRPw6FJFN/1SdcIzsHMMmrPVDnWjqn7l4fzCG/r?=
 =?us-ascii?Q?sxltXASQ+yMNdnYFnGBGU8jXDSz4U+nnagfgho/88rZRHywzTwG6XinSqEkY?=
 =?us-ascii?Q?V6osqVBhmUkZsF5QOrdGgABHJZNFS1E4A4tyl07Yynz9ZiPjz5MtK4gwq0wE?=
 =?us-ascii?Q?XuOgCAwZopGfs1jScm683Iq10NEH5piUut0GbT1s5LA10MnkiynnNit3vpi2?=
 =?us-ascii?Q?6jnaDLn+DzsugN/X4UnIumO27F552TzfRmV1aVEmfpcCI6WXgqmIl9UFCMcg?=
 =?us-ascii?Q?NYx9mXUj2zTnT4AClNmfTW+kRXdhLMcQNyGF+E79Iifcu3IVOWYdbia0JzsG?=
 =?us-ascii?Q?R5gXX2TsOqAWRn3pS/mp33rttoDoyBk1DDGSPTVzth2Az1TDqHuABLGlbmwK?=
 =?us-ascii?Q?WJjtnmiSbjY3KF3Hhq/xravPPryNbwG4gIF1EJf4/NSriM66ksE2VK4/sh2D?=
 =?us-ascii?Q?OkCAEQffcxddsHqiT9RVzg7XzFzw4pZKZUyFlHRA8ahkcYDpM5wnGnR20Ipo?=
 =?us-ascii?Q?s4C0qXraCrMyJv7M8NU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5953.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36345716-5fb6-4ee8-c462-08da715c3098
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2022 12:16:39.2438
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HrpajDpX8TmSL8AojHdTT0HHNNzZtSXxk6pZVNQ39Mepdm316DJKUXvEax1XVBFO
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1894
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>
> Sent: Wednesday, July 27, 2022 12:18 AM
> To: Andrew Lunn <andrew@lunn.ch>
> Cc: michal.simek@xilinx.com; nicolas.ferre@microchip.com;
> claudiu.beznea@microchip.com; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> gregkh@linuxfoundation.org; ronak.jain@xilinx.com; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; git@xilinx.com; git (AMD-Xilinx) <git@amd.com>
> Subject: RE: [PATCH net-next 2/2] net: macb: Add zynqmp SGMII dynamic
> configuration support
>=20
>=20
>=20
> > -----Original Message-----
> > From: Andrew Lunn <andrew@lunn.ch>
> > Sent: Monday, July 25, 2022 10:41 PM
> > To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>
> > Cc: michal.simek@xilinx.com; nicolas.ferre@microchip.com;
> > claudiu.beznea@microchip.com; davem@davemloft.net;
> > edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> > gregkh@linuxfoundation.org; ronak.jain@xilinx.com; linux-arm-
> > kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> > netdev@vger.kernel.org; git@xilinx.com; git (AMD-Xilinx) <git@amd.com>
> > Subject: Re: [PATCH net-next 2/2] net: macb: Add zynqmp SGMII dynamic
> > configuration support
> >
> > On Mon, Jul 25, 2022 at 02:34:51PM +0000, Pandey, Radhey Shyam wrote:
> > > > -----Original Message-----
> > > > From: Andrew Lunn <andrew@lunn.ch>
> > > > Sent: Sunday, July 24, 2022 10:24 PM
> > > > To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>
> > > > Cc: michal.simek@xilinx.com; nicolas.ferre@microchip.com;
> > > > claudiu.beznea@microchip.com; davem@davemloft.net;
> > > > edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> > > > gregkh@linuxfoundation.org; ronak.jain@xilinx.com; linux-arm-
> > > > kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> > > > netdev@vger.kernel.org; git@xilinx.com; git (AMD-Xilinx)
> > > > <git@amd.com>
> > > > Subject: Re: [PATCH net-next 2/2] net: macb: Add zynqmp SGMII
> > > > dynamic configuration support
> > > >
> > > > > +		ret =3D of_property_read_u32_array(pdev-
> >dev.of_node,
> > > > "power-domains",
> > > > > +						 pm_info,
> > > > ARRAY_SIZE(pm_info));
> > > > > +		if (ret < 0) {
> > > > > +			dev_err(&pdev->dev, "Failed to read power
> > > > management information\n");
> > > > > +			return ret;
> > > > > +		}
> > > > > +		ret =3D zynqmp_pm_set_gem_config(pm_info[1],
> > > > GEM_CONFIG_FIXED, 0);
> > > > > +		if (ret < 0)
> > > > > +			return ret;
> > > > > +
> > > >
> > > > Documentation/devicetree/bindings/net/cdns,macb.yaml says:
> > > >
> > > >   power-domains:
> > > >     maxItems: 1
> > > >
> > > > Yet you are using pm_info[1]?
> > >
> > > >From power-domain description - It's a phandle and PM domain
> > > specifier as defined by bindings of the power controller specified
> > > by phandle.
> > >
> > > I assume the numbers of cells is specified by "#power-domain-cells":
> > > Power-domain-cell is set to 1 in this case.
> > >
> > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> > > #power-domain-cells =3D <1>;
> > > power-domains =3D <&zynqmp_firmware PD_ETH_0>;
> > >
> > > Please let me know your thoughts.
> >
> > Ah, so you ignore the phandle value, and just use the PD_ETH_0?
> >
> > How robust is this? What if somebody specified a different power domain=
?
>=20
> Some background - init_reset_optional() fn is implemented for three
> platforms i.e., zynqmp, versal, MPFS.
>=20
> zynqmp_pm_set_gem_config API expect first argument as GEM node id so,
> power-domain DT property is passed to get node ID.
>=20
> However, power-domain property is read only if underlying firmware
> supports configuration of GEM secure space. It's only true for zynqmp SGM=
II
> case and for zynqmp power domain is fixed.
> In addition to it there is an error handling in power-domain property par=
sing.
> Hope this answers the question.

Please let me know the implementation looks fine or needs any modification?