Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp257312imn; Fri, 29 Jul 2022 06:06:19 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sAWjkrDGoiKskRjtC/lRGo+7z9mTjsReQYL6ewx1+l6Irw04f4/Xehvt3x4YBdBTP8uNOg X-Received: by 2002:a17:907:7ea7:b0:72b:6e6b:4895 with SMTP id qb39-20020a1709077ea700b0072b6e6b4895mr2825946ejc.338.1659099979189; Fri, 29 Jul 2022 06:06:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659099979; cv=none; d=google.com; s=arc-20160816; b=o0R99zujcoKvihxtMaXiQPLMgvIqRGAZH9FsjOrB80RFn4pYkpXI406gU+ugpZvgsJ FJzWNyO1Z+pNiUKb0Z05OVZtGiQAhB9o1VDz7ww1axkGObolKoOOZixfszp/RjLdolFv Y1YnLafIisUKj7muvokbOBmegGibd1WFYHpFEB0jOI9BVi3Y8tyBvudNEtt4qSmdPXMH YMTJYNiHpZaw1tMBgoApbgWzKWa6N9RNSIWszdto0baiq5kxZJy7ITqzkVxi/G0LrLeC 6vZfIlGQswm+DzEPMOj6j/BBLJJyB3sYdn8zThOssBKBPF89DiUMyIfnYKHWP8u3fBDJ SDRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=GrduTYQRXA22B8stEU4mNcBzVlElyXpqo+2yfzedofE=; b=pZvEkxzq1M6C9WDqDIgd0cXhaua2Wncqlgeyav1VDVjcQdhisCxGmXRTpwzQ9XqM25 QMsx6kPn4gg2Ygw+P480g87QEl0vojnn7xMMQbVX6UydeuE1cKHyWpPExdLto/a0USlZ ZcAse4jaavlDGh2irrcOJygI4Gr4ARa+A31BXIyOgdLNEotqwTIelSeGFFyC5pqVI2aA zSXW2hAqELAxZgvR6eHk/O9cHDfpzje1qR42OAMmWiyg8wHJMN4EysbZ/Ry7arAr3jaH vu3qM4bdOA4xJyPvH54D6KS0k2e2QZwo0Q0v+Rvcp2m+q4igpdjdJ7/HRP/99qNEqs5s S+Cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z60-20020a509e42000000b0043a4bc94f49si2197172ede.196.2022.07.29.06.05.52; Fri, 29 Jul 2022 06:06:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236267AbiG2NER (ORCPT + 99 others); Fri, 29 Jul 2022 09:04:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235851AbiG2NEF (ORCPT ); Fri, 29 Jul 2022 09:04:05 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8285947B82 for ; Fri, 29 Jul 2022 06:04:04 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHPeh-0006nS-9j; Fri, 29 Jul 2022 15:03:51 +0200 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oHPeg-000Vuk-4o; Fri, 29 Jul 2022 15:03:50 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oHPed-00CQYQ-IX; Fri, 29 Jul 2022 15:03:47 +0200 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v1 06/10] net: dsa: microchip: KSZ9893: do not write to not supported Output Clock Control Register Date: Fri, 29 Jul 2022 15:03:42 +0200 Message-Id: <20220729130346.2961889-7-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220729130346.2961889-1-o.rempel@pengutronix.de> References: <20220729130346.2961889-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This issue was detected after adding regmap register access validation. KSZ9893 compatible chips do not have "Output Clock Control Register 0x0103". So, avoid writing to it. Signed-off-by: Oleksij Rempel --- drivers/net/dsa/microchip/ksz9477.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index 074d4c16d427..a3ddc9021af3 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -193,6 +193,10 @@ int ksz9477_reset_switch(struct ksz_device *dev) ksz_write32(dev, REG_SW_PORT_INT_MASK__4, 0x7F); ksz_read32(dev, REG_SW_PORT_INT_STATUS__4, &data32); + /* KSZ9893 compatible chips do not support refclk configuration */ + if (dev->chip_id == KSZ9893_CHIP_ID) + return 0; + data8 = SW_ENABLE_REFCLKO; if (dev->synclko_disable) data8 = 0; -- 2.30.2