Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp261233imn; Fri, 29 Jul 2022 06:11:33 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vxe/2kiCVMYlkxCAnqhXoHmU7xZj+YDP+WFMrchH0NWYsGqqpAq1ufRhYd0tHLqOCGIhf3 X-Received: by 2002:a17:906:9b14:b0:72b:313b:2df4 with SMTP id eo20-20020a1709069b1400b0072b313b2df4mr2820930ejc.99.1659100292473; Fri, 29 Jul 2022 06:11:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659100292; cv=none; d=google.com; s=arc-20160816; b=StcyCsAW9GErTOU6ntCV+/Z2pRZYXO8EqJYN8EXDQgDFgw3+ME3cCo58C+Nsp5skj+ UwvAIBJW/hdvrN9alg9DC2QNIvN/EcXt68kj9bfZTXLgjuWVjHPThqvD77CP0kN1xojp 5zBqv1/6K4TFbeXZpzDYk/1bn8MD7rOUFCvIaqQ1GBQ8l1nHG0/16VWchwDA9+1d04z6 IigqezKBFh1NZJ2SCvw+kLRHegburodp1Q5jSTirCY9AHATIjZIVCHBxJMBMNXUL6VlH CH1IJk2Ao2WKKvCB3OXIZMF7wxtDAqLujvwno+2z72QLy7j8ZiWhpwzvnzNUMkBScRxJ lHfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=spdbuLGy972hykljHMOOY+f/Ib6xfaCyZd9WZ1pczys=; b=0mnicqelefa5S7TNWstLjNFqKFdO6/PSvlz69PFVrj0SxJ3xsV6LnpwWHDrSCTPV4i Ssn86sT1nXybsHbmnAP+fv8jZu8bX5hqjrvNi4UePWAdETcdycwt5ZwKRxqTzblMLtK+ fgwj9rkFPAo1ZnxKr290FjV9/cltMoPEXpfSGPQPBvza22zD6iyUWqcINv/+XpeXiIa8 L9radtkqkoJKJZsFegBNFlFjZQj1wOBmmwZHuJuDaEjpWy1iI/5jtz5ETn7GQSiZot6g owI56rJOV+kxS/5CIBieCxxnu2Zh2xy3kaK+Srpl+TbcEKU8Ae6Y7E3GPg9RjRSVfrzs eqgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z10-20020a056402274a00b0043c5a4dc3f1si1904346edd.31.2022.07.29.06.11.06; Fri, 29 Jul 2022 06:11:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236365AbiG2NEx (ORCPT + 99 others); Fri, 29 Jul 2022 09:04:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236193AbiG2NEL (ORCPT ); Fri, 29 Jul 2022 09:04:11 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CCA4481C8 for ; Fri, 29 Jul 2022 06:04:11 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHPeh-0006nM-9V; Fri, 29 Jul 2022 15:03:51 +0200 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oHPef-000VuS-2v; Fri, 29 Jul 2022 15:03:49 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oHPed-00CQZ0-Ks; Fri, 29 Jul 2022 15:03:47 +0200 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v1 10/10] net: dsa: microchip: ksz9477: remove MII_CTRL1000 check from ksz9477_w_phy() Date: Fri, 29 Jul 2022 15:03:46 +0200 Message-Id: <20220729130346.2961889-11-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220729130346.2961889-1-o.rempel@pengutronix.de> References: <20220729130346.2961889-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The reason why PHYlib may access MII_CTRL1000 on the chip without GBit support is only if chip provides wrong information about extended caps register. This issue is now handled by ksz9477_r_phy_quirks() With proper regmap_ranges provided for all chips we will be able to catch this kind of bugs any way. So, remove this sanity check. Signed-off-by: Oleksij Rempel --- drivers/net/dsa/microchip/ksz9477.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index a3ddc9021af3..caef13ae9070 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -346,10 +346,6 @@ int ksz9477_w_phy(struct ksz_device *dev, u16 addr, u16 reg, u16 val) if (addr >= dev->phy_port_cnt) return 0; - /* No gigabit support. Do not write to this register. */ - if (!(dev->features & GBIT_SUPPORT) && reg == MII_CTRL1000) - return -ENOTSUPP; - return ksz_pwrite16(dev, addr, 0x100 + (reg << 1), val); } -- 2.30.2