Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 29 Jul 2022 15:08:22 +0200
From:   Steffen Klassert <steffen.klassert@secunet.com>
To:     Xin Xiong <xiongx18@fudan.edu.cn>
CC:     Herbert Xu <herbert@gondor.apana.org.au>,
        "=?utf-8?B?4oCcRGF2aWQgUyAu?= Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        James Morris <jmorris@namei.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <yuanxzhang@fudan.edu.cn>,
        Xin Tan <tanxin.ctf@gmail.com>
Subject: Re: [PATCH] xfrm: fix refcount leak in __xfrm_policy_check()
Message-ID: <20220729130822.GC2602992@gauss3.secunet.de>
References: <20220724095557.4350-1-xiongx18@fudan.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220724095557.4350-1-xiongx18@fudan.edu.cn>
Precedence: bulk

On Sun, Jul 24, 2022 at 05:55:58PM +0800, Xin Xiong wrote:
> The issue happens on an error path in __xfrm_policy_check(). When the
> fetching process of the object `pols[1]` fails, the function simply
> returns 0, forgetting to decrement the reference count of `pols[0]`,
> which is incremented earlier by either xfrm_sk_policy_lookup() or
> xfrm_policy_lookup(). This may result in memory leaks.
> 
> Fix it by decreasing the reference count of `pols[0]` in that path.
> 
> Fixes: 134b0fc544ba ("IPsec: propagate security module errors up from flow_cache_lookup")
> Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
> Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>

Applied, thanks a lot Xin!