Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <42875ff3-04a2-c465-4063-1ce3b0b35dba@kali.org>
Date:   Fri, 29 Jul 2022 09:20:22 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: [PATCH v2 00/11] soc/arm64: qcom: Add LLCC BWMON on SDM845
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Georgi Djakov <djakov@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Rajendra Nayak <quic_rjendra@quicinc.com>,
        Sibi Sankar <quic_sibis@quicinc.com>
References: <20220728113748.170548-1-krzysztof.kozlowski@linaro.org>
From:   Steev Klimaszewski <steev@kali.org>
In-Reply-To: <20220728113748.170548-1-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 7/28/22 6:37 AM, Krzysztof Kozlowski wrote:
> Hi,
>
> Changes since v1
> ================
> 1. Patch #2: Drop also BWMON_GLOBAL_IRQ_STATUS (Sibi).
> 2. Minor rebasings because of above drop.
> 3. Patch #4: typo in subject (Sibi).
> 4. New patch: arm64: dts: qcom: sdm845: narrow LLCC address space (Sibi).
> 5. Add Rb tags.
>
> Description
> ===========
> BWMON is a data bandwidth monitor providing throughput/bandwidth over certain
> interconnect links in a SoC.  It might be used to gather current bus usage and
> vote for interconnect bandwidth, thus adjusting the bus speed based on actual
> usage.
>
> Qualcomm SoCs might several BWMON instances.  Extend existing support for CPU
> BWMON (called v4) to LLCC BWMON (called v5).
>
> Cc: Rajendra Nayak <quic_rjendra@quicinc.com>
> Cc: Sibi Sankar <quic_sibis@quicinc.com>
>
> Best regards,
> Krzysztof
>
> Krzysztof Kozlowski (11):
>    dt-bindings: interconnect: qcom,msm8998-bwmon: add support for SDM845
>      LLCC BWMON
>    soc: qcom: icc-bwmon: re-use IRQ enable/clear define
>    soc: qcom: icc-bwmon: drop unused registers
>    soc: qcom: icc-bwmon: store reference to variant data in container
>    soc: qcom: icc-bwmon: clear all registers on init
>    soc: qcom: icc-bwmon: store count unit per variant
>    soc: qcom: icc-bwmon: use regmap and prepare for BWMON v5
>    soc: qcom: icc-bwmon: add per-variant quirks
>    soc: qcom: icc-bwmon: add support for SDM845 LLCC BWMON
>    arm64: dts: qcom: sdm845: narrow LLCC address space
>    arm64: dts: qcom: sdm845: add LLCC BWMON
>
>   .../interconnect/qcom,msm8998-bwmon.yaml      |   1 +
>   arch/arm64/boot/dts/qcom/sdm845.dtsi          |  39 +-
>   drivers/soc/qcom/icc-bwmon.c                  | 460 ++++++++++++++----
>   3 files changed, 401 insertions(+), 99 deletions(-)
>
Tested on the Lenovo Yoga C630 with QCOM_LLCC=m and no longer see the 
previous error message.

Tested-by: Steev Klimaszewski <steev@kali.org>