Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp363941imn; Fri, 29 Jul 2022 09:10:14 -0700 (PDT) X-Google-Smtp-Source: AGRyM1txGeENqCs/im6rbwWcKk2eoiZUi0NE2+MXc5FmhDE+KiEFwzUR3/MKv3bCoKZwEr7zRlxK X-Received: by 2002:a05:6402:298a:b0:43a:76f8:a75c with SMTP id eq10-20020a056402298a00b0043a76f8a75cmr4319083edb.216.1659111014541; Fri, 29 Jul 2022 09:10:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659111014; cv=none; d=google.com; s=arc-20160816; b=nndScLRQNhnhgT8U4EIJisdBpL4hZ3LM/FsaaX53ELBIfbkkO2E56txPlFygRg4y0a f4LuZ27aef4B0sCknkr1fjnwFSaJo7mWOsl+XDrhNc7FsKOIqP6sZ0J1y+AtTZw3pgz3 7jHEpDY32pg2yCMp2bMLoCD9l9JVXtR4uziQF+a3krv+G5TMm1zwoS4l1ws09e+3rYlM 31fhFHtlcS//7iUku2Fhsl+BuZqBDe+uhbiUKOL417PAxYkmgWrQGQ3uuPSnCnXCsHIw Yx43/KwzOOevbux0rb/mCoAoOV4pmRd1f+dROasy1flPdepYePtVnbS+zzfs+KJ07hwQ 11gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=VxPHNTEAmNUWXO+PycFNRFVkE2T7hCZ8txSIsXrb1fI=; b=LZxKqeCqqcDU/eyvtX5viKp0Qvf0FkTAqccq46wjkd8+e4awXfowZsDEcGX0fl8DC1 v+DO6vtpj+PZySFzeeWSW039HpB3oHviEeXTIoKui7ti3G5xYvfLLthQUZQulIrB+xe6 VCaKkcDOLrrp6SIh0+6v6XJvBjkpD8WcPXRHrs7/e38alW3jwtI/Zf1/0eiq4w7mM4D3 B/VH32jGRwQ0eSnsLZOfjBhudN2x2OW2pH/PvhXTfG/FYo37HBhZuXSR4P84o+fZcW2Q tsyQ8G1IVJjwsSGciw9dLJqW+8HIqFjpLVVEWXlJfJ4IyRHQOzvy9h6atI21NZVs7Eeg bRWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Ev/fhjtf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nb30-20020a1709071c9e00b0071578ad44a1si4074618ejc.986.2022.07.29.09.09.48; Fri, 29 Jul 2022 09:10:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Ev/fhjtf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237693AbiG2PgR (ORCPT + 99 others); Fri, 29 Jul 2022 11:36:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236921AbiG2PgJ (ORCPT ); Fri, 29 Jul 2022 11:36:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9702A863E9 for ; Fri, 29 Jul 2022 08:36:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3312C61194 for ; Fri, 29 Jul 2022 15:36:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DABEC433C1; Fri, 29 Jul 2022 15:36:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1659108967; bh=dc+Yq1KU2LevdXHCY6u4sGEuoDgnzP0NMKytWaNyyMo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ev/fhjtfSa1TXvCqtpE5mVwsv7VgFjLuWQEk5xDO0/M+CjbMQ4hax4v2SOm5/fW+L /aRCdmFSZ7/hAfn6szljNfpyKvz2bCVAC4T9tCaHT8rJwOif+uACq0PKObaUPS7wf/ uFB0iZxHp/CpX2xqj9Ajr+ulRt34cPuMS8M8hWqQ= Date: Fri, 29 Jul 2022 17:36:04 +0200 From: Greg Kroah-Hartman To: Sidong Yang Cc: Paulo Miguel Almeida , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: pi433: fix wrong comment Message-ID: References: <20220729152554.8211-1-realwakka@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220729152554.8211-1-realwakka@gmail.com> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 29, 2022 at 04:25:54PM +0100, Sidong Yang wrote: > The comment should describe the error when user calls rf69_write_fifo() > not rf69_write_fifo(). > > Signed-off-by: Sidong Yang > --- > drivers/staging/pi433/rf69.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c > index 659c8c1b38fd..8c7fab6a46bb 100644 > --- a/drivers/staging/pi433/rf69.c > +++ b/drivers/staging/pi433/rf69.c > @@ -816,7 +816,7 @@ int rf69_write_fifo(struct spi_device *spi, u8 *buffer, unsigned int size) > > if (size > FIFO_SIZE) { > dev_dbg(&spi->dev, > - "read fifo: passed in buffer bigger then internal buffer\n"); > + "write fifo: passed in buffer bigger then internal buffer\n"); This is not a comment.