Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d71dc25e-ef26-b6c3-6c8e-fc5727b76a23@intel.com>
Date:   Fri, 29 Jul 2022 11:02:30 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RESEND RFC PATCH] x86/bugs: Add "unknown" reporting for MMIO
 Stale Data
Content-Language: en-US
To:     Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Cc:     Jonathan Corbet <corbet@lwn.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        tony.luck@intel.com, antonio.gomez.iglesias@linux.intel.com,
        Daniel Sneddon <daniel.sneddon@linux.intel.com>,
        andrew.cooper3@citrix.com, Josh Poimboeuf <jpoimboe@kernel.org>
References: <a932c154772f2121794a5f2eded1a11013114711.1657846269.git.pawan.kumar.gupta@linux.intel.com>
 <f173a7c0-b4f8-17f3-a65d-e581fed32368@intel.com>
 <20220729175959.w7gd5z7dsbxrnydn@desk>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <20220729175959.w7gd5z7dsbxrnydn@desk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/29/22 10:59, Pawan Gupta wrote:
>> +       if (!boot_cpu_unknown_bug(bug))
>> +               return sprintf(buf, "Unknown\n");
>>
>> Thoughts?
> Sounds good. Similar to this Borislav suggested to add
> X86_BUG_MMIO_UNKNOWN. I will see if I can combine both approaches.

I'd say Borislav's is better if there is going to be a small number of
"unknown" things in total.  Mine might be better if we expect a *bunch*
of them.

In other words, I'm rooting for Borislav's.