Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp495204imn; Fri, 29 Jul 2022 13:34:17 -0700 (PDT) X-Google-Smtp-Source: AA6agR7/aRguiNdG53QyZh2BCeWXDRzD5hQCf78XQPg+6KyctSZpcTOqONRwSQIWKbsozKbCWqjK X-Received: by 2002:a17:903:22d0:b0:16d:20f6:b859 with SMTP id y16-20020a17090322d000b0016d20f6b859mr5671248plg.2.1659126856974; Fri, 29 Jul 2022 13:34:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659126856; cv=none; d=google.com; s=arc-20160816; b=iNcYTvUnz180gN4XGP2jNf8qeN4ToNTGTfG/MFeMujoePH708PRQkDLPM2UHMUUIil IopCAYLfxko8wh2FmOfJGJQS3FiTambuLcdywc9TZnFlRPhHN5a/T3APTqHB2vriAVY5 ZI8iMi2DiZXIUhP4RCdqa+oQNctNY6s+tPp5XQzTnDVwUN9a+dutRTX+rJQfFSz9cR1f AuG6KYXrdVreiuKufWzB6vylFLG65uTn+YqXbkOQYtU8T7koNT/LzSoUQpLrP9RajJ5j G+P2dCEVQJOIb/ajfsCiVNRSX2QlN2wh295lyci1mUB8dXVFEoPm69AbuZ0pWWTpO+tf LzTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id; bh=QweBZid8fEFhqfcZZCVMDIwbgQR4peQaMt1LEKBD3lk=; b=CLYDu/kjCAHtirhx4RLchx/qJ431mcGzTdq6GNeNeTnqKgCisMYukCLgQoiYCJQHpK Lingi4GQ0dF0fbH11uE+oOP0Q89Uv+jg/pOwbAU0K5t98tLpw29MSSxaR6NvWtjV7fRA fiGuMa7kL7RmUxDHIN+R57SBACL0D1dWgK94rMKnIwbkgOaUSXUcEzNuPNr2U0uGLKrC BL3C3SvBiCUOB7bQEtzGfl9/Xq3F9xBjH/ApcByLF2HuixGTUWxSNfsmLQdPQXNK2REb 3Kb2nC5C+HEGYP4b92d0qIEsnQ3mJBfwm8sE1rIW/Tf1q4bqOlTpkR8615Uaq9ITsb3M Hovg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x11-20020a170902a38b00b0016dc4217314si4733126pla.150.2022.07.29.13.34.00; Fri, 29 Jul 2022 13:34:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239198AbiG2UWo (ORCPT + 99 others); Fri, 29 Jul 2022 16:22:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230499AbiG2UWn (ORCPT ); Fri, 29 Jul 2022 16:22:43 -0400 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8ED066A4AE; Fri, 29 Jul 2022 13:22:42 -0700 (PDT) Received: by mail-pf1-f173.google.com with SMTP id w185so5576887pfb.4; Fri, 29 Jul 2022 13:22:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=QweBZid8fEFhqfcZZCVMDIwbgQR4peQaMt1LEKBD3lk=; b=UiMrZTuEKtgGfTXQyaowyOS2yqbsrCibOHwnEmJuIGilVkDOWt/jDaTux+wjNG1YJe wm72spLfS3nB7YWDhH4xW2T1ucK5HiOgWip+IAvC/TfkfJXs3dahcWMtP6t3sDuSW0o+ wILkWVcFpYAjPTQQqO6VFFgQDYo+OfgJde/6yoNcDoRVGSpD4DJ8UPZ0PUORqJqP6laH wG3ytkUQMhIJMcO/+ynT35XUMG3wSdoP8anR6rIttVYuYysdINC0wUhqsdrybxFAVuAo OdrjT4Vk/6PuSWPcQlGaUADritTbAGZh29oMWe4piP2SSpUoFTlm7EQvHF/ywMuAoOAQ 7+Hg== X-Gm-Message-State: AJIora+E+yQGGinRs+DZ/foAx/ktN/QCxA2d0l7RpZ/X/3LI91KpPN4q Rf50qcSD+PdhFbpt/eYWaic= X-Received: by 2002:a05:6a00:1307:b0:52c:62a6:686e with SMTP id j7-20020a056a00130700b0052c62a6686emr5047614pfu.24.1659126161944; Fri, 29 Jul 2022 13:22:41 -0700 (PDT) Received: from ?IPV6:2620:15c:211:201:f090:7a49:3465:6a5? ([2620:15c:211:201:f090:7a49:3465:6a5]) by smtp.gmail.com with ESMTPSA id u8-20020a17090a1f0800b001f2fa5262d7sm3547204pja.14.2022.07.29.13.22.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jul 2022 13:22:41 -0700 (PDT) Message-ID: <01a30932-adae-a499-1194-57c925a3633f@acm.org> Date: Fri, 29 Jul 2022 13:22:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v5 2/6] scsi: ufs: wb: Change functions name and modify parameter name Content-Language: en-US To: j-young.choi@samsung.com, ALIM AKHTAR , "avri.altman@wdc.com" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "beanhuo@micron.com" , "adrian.hunter@intel.com" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20220729045252epcms2p7fee5c1cdca5e4bef02a833e40f80649b@epcms2p7> <20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p8> <20220729045433epcms2p77ff2cdde6ddffd9ab0b0810ebe84f0e5@epcms2p7> From: Bart Van Assche In-Reply-To: <20220729045433epcms2p77ff2cdde6ddffd9ab0b0810ebe84f0e5@epcms2p7> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/28/22 21:54, Jinyoung CHOI wrote: > -static inline void ufshcd_wb_config(struct ufs_hba *hba) > +static void ufshcd_wb_set_default_flags(struct ufs_hba *hba) It is not clear to me why the new name is considered an improvement? The old name looks better to me. If you want to rename this function anyway, how about ufshcd_configure_wb()? Thanks, Bart.