Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <2c105a1ff3071796189093c536218e44ea3b1aa0.1659122785.git.dxu@dxuuu.xyz>
In-Reply-To: <2c105a1ff3071796189093c536218e44ea3b1aa0.1659122785.git.dxu@dxuuu.xyz>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Fri, 29 Jul 2022 15:27:11 -0700
Message-ID: <CAEf4BzbnQJ0cTU6NsaLSTVs6CB-JTmoXpR_aWRVO-V1GppNPKg@mail.gmail.com>
Subject: Re: [PATCH bpf] bpf: Fix oudated __bpf_skc_lookup() comment
To:     Daniel Xu <dxu@dxuuu.xyz>
Cc:     bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jul 29, 2022 at 12:47 PM Daniel Xu <dxu@dxuuu.xyz> wrote:
>
> The function returns a pointer now.
>
> Fixes: edbf8c01de5a ("bpf: add skc_lookup_tcp helper")
> Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
> ---

This was already done in [0] in bpf-next.

  [0] f5be22c64bd6 ("bpf: Fix bpf_skc_lookup comment wrt. return type")


>  net/core/filter.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 5d16d66727fc..866ca05f95e0 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -6463,8 +6463,6 @@ static struct sock *sk_lookup(struct net *net, struct bpf_sock_tuple *tuple,
>
>  /* bpf_skc_lookup performs the core lookup for different types of sockets,
>   * taking a reference on the socket if it doesn't have the flag SOCK_RCU_FREE.
> - * Returns the socket as an 'unsigned long' to simplify the casting in the
> - * callers to satisfy BPF_CALL declarations.
>   */
>  static struct sock *
>  __bpf_skc_lookup(struct sk_buff *skb, struct bpf_sock_tuple *tuple, u32 len,
> --
> 2.37.1
>