Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp565400imn; Fri, 29 Jul 2022 16:06:07 -0700 (PDT) X-Google-Smtp-Source: AA6agR4ivDjqp5KjEpo9yFN00oq0GbvWSRYdRCO4HNsISDh+c61w4tlekx0bUG0iMwDPb/vqm6kN X-Received: by 2002:a05:6402:4310:b0:43d:4a82:869f with SMTP id m16-20020a056402431000b0043d4a82869fmr747529edc.205.1659135967458; Fri, 29 Jul 2022 16:06:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659135967; cv=none; d=google.com; s=arc-20160816; b=xwM+uj81XUOn97VGE+k2LcrQR43dW44a+arCwokkeqelRbMGpACyiNOfAY4Dg1Jcwi 2ooJ2jI2LphUwoAHJBy/N6zgvexAQMiV4or+JIiCL18xyAkjqiguyWK+jpOFn56/Epcf l8hUWkETrSYNeqwQMVvKdvOV1mAHXUDG1atP8QuOnr06Vj7TpDg32m03xWxG4CXNU7f1 U5IHnnC6XwL6s3FyMYTwL+2hiFjNZGQpNs/TRyulc7zfRHsyGrSOsOohFn/kGgNuL0L4 KXqJ3JnKZ3NVxgAY7AJjMdbfirGNS99DjXZmTdo9wmxRWWBsElAAVDxLSn9qphtcUyzn kHYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1rD+aoO58/UXvvvt/aND0JlhDHBAo4vbm4X2nBeuMrk=; b=MLP6oM6aRzi+ufCwrvRbIbjmZ7Gz11QfmffmhPwRKBGo1w7j17RWV7lBtueebPyCIU Fsrr7kuuI3yechGh0lluZpgUSZrO5SLBxg00lYrQOm1ruZKfMCNzhMNs2cVQ+x+7wkRX 9jmkuCuYwYnWY5jmSRV2ezDqy+S4nyzySDrzrYX/IGcHe4hvHEUuQWSZIISdO0FxjCRj 9euNRQMwJ8oNDtt+iLp+etYDlZd5zoqZdn8tNChnhsyzanarD5R6I7L55jSrHwFFUtKn xuA3H7vM2dJpEsLPVZ7/s16YbWvEG+qD1hVP1Qayu5z33V7cFrIxyZx2CE5UZ1NxwWR5 2nGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=nbv4TSFz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qb2-20020a1709077e8200b00726e0ea1733si5040744ejc.993.2022.07.29.16.05.42; Fri, 29 Jul 2022 16:06:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=nbv4TSFz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239003AbiG2WmR (ORCPT + 99 others); Fri, 29 Jul 2022 18:42:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbiG2WmP (ORCPT ); Fri, 29 Jul 2022 18:42:15 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E8358AED8; Fri, 29 Jul 2022 15:42:14 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CCC9335079; Fri, 29 Jul 2022 22:42:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1659134531; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1rD+aoO58/UXvvvt/aND0JlhDHBAo4vbm4X2nBeuMrk=; b=nbv4TSFz/AnJ67K2qEUp0Et7jSzrGj8ODP/vQ+wQ5NbNs4GVIu4Lic3m9pVH14mB7IAxPw 38W7rHxJ+F4RbBLqFG1hS1HjDT6b+uI46lCtzHEHYaMDAlDCS1Yd3ZVU+mq1C96HfSj08e 2PxnIbPcmNaWI+rlSU4gbKxre7POMmQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 92CFE13A1B; Fri, 29 Jul 2022 22:42:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mIGaIkNi5GJJfwAAMHmgww (envelope-from ); Fri, 29 Jul 2022 22:42:11 +0000 Date: Sat, 30 Jul 2022 00:42:09 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Tejun Heo Cc: cgroups@vger.kernel.org, Zefan Li , Christian Brauner , linux-kernel@vger.kernel.org, kernel-team@fb.com, Namhyung Kim , Pablo Neira Ayuso Subject: Re: [PATCH v2 cgroup/for-5.20] cgroup: Replace cgroup->ancestor_ids[] with ->ancestors[] Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 29, 2022 at 10:58:22AM -1000, Tejun Heo wrote: > @@ -520,8 +520,8 @@ struct cgroup_root { > /* The root cgroup. Root is destroyed on its release. */ > struct cgroup cgrp; > > - /* for cgrp->ancestor_ids[0] */ > - u64 cgrp_ancestor_id_storage; > + /* for cgrp->ancestors[0] */ > + u64 cgrp_ancestor_storage; Just noticed, this member is (and was AFAICS) superfluous. Michal