Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Fri, 29 Jul 2022 13:02:10 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Michal =?iso-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>
Cc:     cgroups@vger.kernel.org, Zefan Li <lizefan.x@bytedance.com>,
        Christian Brauner <brauner@kernel.org>,
        linux-kernel@vger.kernel.org, kernel-team@fb.com,
        Namhyung Kim <namhyung@kernel.org>,
        Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH v2 cgroup/for-5.20] cgroup: Replace
 cgroup->ancestor_ids[] with ->ancestors[]
Message-ID: <YuRm8s/CFmGKYPc1@slm.duckdns.org>
References: <YuQvcCrcgNWbtndU@slm.duckdns.org>
 <YuRJ7uzKY5/fokH5@slm.duckdns.org>
 <YuRiQc35guAWcbjt@blackbook>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YuRiQc35guAWcbjt@blackbook>
Precedence: bulk

On Sat, Jul 30, 2022 at 12:42:09AM +0200, Michal Koutn? wrote:
> On Fri, Jul 29, 2022 at 10:58:22AM -1000, Tejun Heo <tj@kernel.org> wrote:
> > @@ -520,8 +520,8 @@ struct cgroup_root {
> >  	/* The root cgroup.  Root is destroyed on its release. */
> >  	struct cgroup cgrp;
> >  
> > -	/* for cgrp->ancestor_ids[0] */
> > -	u64 cgrp_ancestor_id_storage;
> > +	/* for cgrp->ancestors[0] */
> > +	u64 cgrp_ancestor_storage;
> 
> Just noticed, this member is (and was AFAICS) superfluous.

I should have changed the type to struct cgroup * but that's the space into
which cgroup_root->cgrp->ancestors[] stretch into.

Thanks.

-- 
tejun