Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <CAOX2RU7NaJL5dTrjz26oiz0psvXKV8C-7HGMmJ-rfNJ3r=y2qg@mail.gmail.com>
References: <20220515210048.483898-1-robimarko@gmail.com> <20220515210048.483898-10-robimarko@gmail.com> <20220711211047.952F4C34115@smtp.kernel.org> <CAOX2RU7NaJL5dTrjz26oiz0psvXKV8C-7HGMmJ-rfNJ3r=y2qg@mail.gmail.com>
Subject: Re: [PATCH v4 10/11] clk: qcom: ipq8074: dont disable gcc_sleep_clk_src
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Abhishek Sahu <absahu@codeaurora.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Devicetree List <devicetree@vger.kernel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        krzysztof.kozlowski+dt@linaro.org,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        linux-clk@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>, tdas@codeaurora.org
To:     Robert Marko <robimarko@gmail.com>
Date:   Fri, 29 Jul 2022 16:27:48 -0700
User-Agent: alot/0.10
Message-Id: <20220729232750.8EAADC433D6@smtp.kernel.org>
Precedence: bulk

Quoting Robert Marko (2022-07-11 14:14:38)
> On Mon, 11 Jul 2022 at 23:10, Stephen Boyd <sboyd@kernel.org> wrote:
> >
> > Quoting Robert Marko (2022-05-15 14:00:47)
> > > diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ip=
q8074.c
> > > index 3204d550ff76..42d185fe19c8 100644
> > > --- a/drivers/clk/qcom/gcc-ipq8074.c
> > > +++ b/drivers/clk/qcom/gcc-ipq8074.c
> > > @@ -663,6 +663,7 @@ static struct clk_branch gcc_sleep_clk_src =3D {
> > >                         },
> > >                         .num_parents =3D 1,
> > >                         .ops =3D &clk_branch2_ops,
> > > +                       .flags =3D CLK_IS_CRITICAL,
> > >                 },
> >
> > Why not just remove the clk from the driver? Is anything using it?
>=20
> Hi Stephen, USB sleep clocks are derived from it so it cant be dropped.
>=20

And we can't return NULL clks to USB for the sleep clk?