Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp669507imn; Fri, 29 Jul 2022 20:55:29 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uG8UgcIvWLt9k4QZrw7z0gI/Vw5X0qBa3l8L/SO1LFFEahvM8A2euPa4JwTm7DMqIgSVFe X-Received: by 2002:a17:907:28d4:b0:72b:49c0:d04a with SMTP id en20-20020a17090728d400b0072b49c0d04amr5244869ejc.141.1659153328815; Fri, 29 Jul 2022 20:55:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659153328; cv=none; d=google.com; s=arc-20160816; b=ngn9JK6Fyr9BJLxpzeGXAM8mTPffXJgp9aK3ktNkft0WxFxjI2Z3JWrg68vrTtTL3A MUvjMICf7ipGv33dT8c/pg3OB1q3GpyKV/xSbu3IFJKl65iMf3Pvu+sXKnU36Beyt7el DSx9quTyQ0YssksnJkdhT00LF4zaVzdNgfWu/ydtzhy9i9WC6m8Eqd8uPh54tlQuXmEK eT2ytolqXCJHiBBUGfWRll5lBYPcjL9SsMJYNB2rwZsVQvtqeyJrm6H3nQxm4yO0RQZt tIOBo/WClOLQvVEcpoIHT5sUeZdTP182c8K64vZ7ytBU3Pig3gc9xqF7FK7f5++XOjA8 NxWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=wQPQlV7apFmdAUsFT8uJyYaVCkVufIRKulfJqIm3SSw=; b=bu5AUsYaZsgEPWsm5JWHzfwG435bVIjLs5QCYZFz2EsuXFI7376ImMTHWcAAVV2c7U CmU2xk5hfgPB8mJW0SbnZGytPS/KrZd1ZLvz6aJPH5IIYQFj2XkeI8wOJBiM7BtH9Fdk WGR1Quqk684uX7NtbFIVLtI+dm2YiPdYE0hxb6rGfhEjZh3PO6onvBpM1U2BpQD89rHx eMZuXrtwReUEWW8Z9TVseg326UuhXBJxfdpA3r7nHRiNuxKKawNLG/Coy2/z/6WkJYHS XcojlM/K1DmzD5eIvGBxclM1avyXE4e1xmShxhawT8+fcsm5iDQnn4FUC3s6Xb76SIki TELA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ZT2MMNv6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w26-20020a170906385a00b0072b2377bab0si4396611ejc.649.2022.07.29.20.55.00; Fri, 29 Jul 2022 20:55:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ZT2MMNv6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239797AbiG3Df5 (ORCPT + 99 others); Fri, 29 Jul 2022 23:35:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240117AbiG3Dfk (ORCPT ); Fri, 29 Jul 2022 23:35:40 -0400 Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 937BB1901A for ; Fri, 29 Jul 2022 20:35:30 -0700 (PDT) Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-31f41584236so67315457b3.5 for ; Fri, 29 Jul 2022 20:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=wQPQlV7apFmdAUsFT8uJyYaVCkVufIRKulfJqIm3SSw=; b=ZT2MMNv6qiCqlI600Ig6b2L8iRnFwfJquxCn1XYJzn0H8G46TfJLCNCKWvF0n2jPKE cL1xo4u/MpaZUgHgaUrvdLfSGN52FTRzbY32HyFlsPIN013qaIfEaGcgVz9/OOZ9frNE giYlc1jSqeXT1gmIiCPlerAuNKKTOxpFIUNJq6xNHdLSzBRHq/mcpFd10jN8j/SlQKT7 Ic69vavUNAwl/q73AmgP5ql7tw964rTvC5zclj9oYv8C7MY6YcWfp6rbmXeQtB8WYFWu Oj+YL4y4t4c40uPwcl9vcZgXpDAH8CMdZr0UCO05HH0ghYJzgfFspgTTdlJ96/Brz+Cm UioA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=wQPQlV7apFmdAUsFT8uJyYaVCkVufIRKulfJqIm3SSw=; b=L45B+f0x05UAPNRxBJ/62noGFHILg7Cu+dlFbiGQj/4Q1hPtx97QcdQx6WjSBP9+lK +Y41dc1Bd18hItNJKPbu1zl+ZklDn/4E3Aw89q0m40K8psDVDTsh/WkXKe269ga7gRgf KByIU9WiqIYFCBZF+jobkVyJdU8iDM3Ds8iKNlea9k6GhbcGvc6WIr/VinNiKRqsICgC cYncv/PAgcFaPuBuhMUKKwkPiRdjq9gqzQ+j0FQh61D3RfZ99Ya9akP+RpEeMoxbm1vZ 7itjel/wxDw/dTO7LUvgnKcg4JKJShI8WFKjaQfl7+/rlHmMzvqG3tN/uZG4wunl1xbH zQJQ== X-Gm-Message-State: ACgBeo3/vurXS1S1b13jebl0XpqgjrG44LyxxizBw1VNNjwycc5B4U5E XimU4djJJw81Hrhzj6J+yRC5I8bQjYfa2XxZCXc= X-Received: by 2002:a81:4845:0:b0:322:ae4a:f3de with SMTP id v66-20020a814845000000b00322ae4af3demr5560045ywa.398.1659152129678; Fri, 29 Jul 2022 20:35:29 -0700 (PDT) MIME-Version: 1.0 References: <20220729035230.226172-1-ztong0001@gmail.com> <20220729035230.226172-2-ztong0001@gmail.com> <90a16ffd-5a08-0ed3-280e-bd5c4522525c@gmail.com> In-Reply-To: <90a16ffd-5a08-0ed3-280e-bd5c4522525c@gmail.com> From: Tong Zhang Date: Fri, 29 Jul 2022 20:35:18 -0700 Message-ID: Subject: Re: [PATCH v3 1/3] staging: rtl8192u: move debug stuff to its own file To: Philipp Hortmann Cc: Greg Kroah-Hartman , Dan Carpenter , Jakub Kicinski , Saurav Girepunje , Colin Ian King , Nathan Chancellor , Johan Hovold , open list , linux-staging@lists.linux.dev Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 28, 2022 at 11:23 PM Philipp Hortmann wrote: > > On 7/29/22 05:52, Tong Zhang wrote: > > This is to prepare for moving them to debugfs and fix rmmod warn issue > > when wlan0 is renamed to something else. > > > > Reviewed-by: Dan Carpenter > > Signed-off-by: Tong Zhang > > --- > > When I applied your first patch I got this hint: > > Applying: staging: rtl8192u: move debug stuff to its own file > .git/rebase-apply/patch:399: new blank line at EOF. > + > warning: 1 line adds whitespace errors. > > Not really an functional issue...but > > By Philipp Hi Philipp, Thanks for the review. I fixed it in v4. Thanks and have a good one! - Tong