Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp779509imn; Sat, 30 Jul 2022 02:45:38 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uqV3TXRTJBE4CyDbo9jSYl6W9+0Vejak89Tew2TBEZi75oH5mocNv/UvSmOGQK+Hwn7Ci4 X-Received: by 2002:a17:907:760d:b0:730:3da3:facd with SMTP id jx13-20020a170907760d00b007303da3facdmr2674530ejc.5.1659174338322; Sat, 30 Jul 2022 02:45:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659174338; cv=none; d=google.com; s=arc-20160816; b=sF9IZ3M5YH41wjEsRfmSQNPUNy86E6OODoxqbp/GFjgcw6VOA4xdw0l7AuNPWXX1Vm TYUfHj2VLg8D5UM0G0nCllG69wPK1IEukfEs/5ss3Yg1almJ+DNge/qvppwlIL1BB7S5 yTXF+GLm8hJIOxQUEvyKSxz/EkJfkIbiCyXQAOZ4hSRHjlD4Le/AaozQCJZnk9mk+PUJ 5tGPR0H3aRypvCnzNuX3Y1uZrDvja70ork818twSjRhoa+6Bv1I5oax+faxc3J+jyg9t Uf1F1QzmDIzvyM4rZYt5fggvFxxFX3dy9urll7Lsx5x2kDMzPVHLvZRhLhY7CGN4rooa 8Vtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=+nv5k6cElBg65M4Dh82ondzpZeLgEEYFpmWR1ufVNmc=; b=jGUdcuqaPE+UwMzdBxrmF4V9w8Jkv+7Hf8PQR8d9RYryp0pccALE92HEsxsqyr0EA2 SafAKhkUAuWXWrs6G7z6oL+g8NYg9gJ0pCeqpL6PoOg0bAJf6uFpNw+hdCJBb36PYYE+ xXKUMWnvyrOAGoO8ofZDhDDNtAbdoyhGKAfoM+1zpQgNv1CXYHDfycWAcWYc5IhYp1PJ Wf+muInx4J0hhpD3H0a5jRfnIvniq4J/2Uc6gm4EP7ZBxSyYkAa4IC8uaI9rmQacaPxd dy5XC97HWnylyVqNZoagTj8HejoeXYZMox4l+6apfC2iRY6pBHmlmfXG0ejCh1FomUjG mAmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=KlUa1wVh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ce26-20020a170906b25a00b0072b67b81430si4513433ejb.577.2022.07.30.02.45.13; Sat, 30 Jul 2022 02:45:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=KlUa1wVh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232785AbiG3JmQ (ORCPT + 99 others); Sat, 30 Jul 2022 05:42:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237184AbiG3Jlv (ORCPT ); Sat, 30 Jul 2022 05:41:51 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6615E45F5B; Sat, 30 Jul 2022 02:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1659174105; x=1690710105; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=+nv5k6cElBg65M4Dh82ondzpZeLgEEYFpmWR1ufVNmc=; b=KlUa1wVhAS3sO52fX6WnL28qLD1HSx8Y1sv6HbLl+5oqysqDGyPIH4sH l+mclZ/BXg/a9szLVRsCsm9iIfQF0zJglqxu6e3NelZ2GoaAtHo5SkCfb h5dpLRSLgNKeJ+3B0TQYzKztq4NW4+ukb/iypkh/qJH0lp4vdqNSF1x6K o=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-02.qualcomm.com with ESMTP; 30 Jul 2022 02:41:44 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2022 02:41:44 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Sat, 30 Jul 2022 02:41:43 -0700 Received: from hyd-lnxbld559.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Sat, 30 Jul 2022 02:41:38 -0700 From: Akhil P Oommen To: freedreno , , , Rob Clark , Bjorn Andersson CC: Jordan Crouse , Jonathan Marek , Douglas Anderson , "Matthias Kaehlcke" , Akhil P Oommen , Abhinav Kumar , AngeloGioacchino Del Regno , Daniel Vetter , David Airlie , Dmitry Baryshkov , Nathan Chancellor , "Sean Paul" , Vladimir Lypak , Subject: [PATCH v3 6/8] drm/msm/adreno: Remove a WARN() during runtime_suspend Date: Sat, 30 Jul 2022 15:10:49 +0530 Message-ID: <20220730150952.v3.6.I3329f9e803d8c09bd017d777e5bbd2a80080295f@changeid> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1659174051-27816-1-git-send-email-quic_akhilpo@quicinc.com> References: <1659174051-27816-1-git-send-email-quic_akhilpo@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org WARN(gpu->active_submits) during runtime_suspend doesn't make sense now because we force runtime suspend during a gpu recovery when there are active submissions pending. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/adreno_device.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index 8706bcd..d1e1e8e 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -610,13 +610,6 @@ static int adreno_runtime_suspend(struct device *dev) { struct msm_gpu *gpu = dev_to_gpu(dev); - /* - * We should be holding a runpm ref, which will prevent - * runtime suspend. In the system suspend path, we've - * already waited for active jobs to complete. - */ - WARN_ON_ONCE(gpu->active_submits); - return gpu->funcs->pm_suspend(gpu); } -- 2.7.4