Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp794022imn; Sat, 30 Jul 2022 03:24:49 -0700 (PDT) X-Google-Smtp-Source: AA6agR7bVbeUP0mq7P3LPqvLViBFHJrPyaHqIRz2i30xaBHkAAMbTlBs4ZCpN3tSLU8WeMubjA/X X-Received: by 2002:a63:8048:0:b0:41b:d355:c02c with SMTP id j69-20020a638048000000b0041bd355c02cmr475257pgd.405.1659176689340; Sat, 30 Jul 2022 03:24:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659176689; cv=none; d=google.com; s=arc-20160816; b=Bzef8KrCaNPIY011UTlj2T2u/Hp9z1EwfjYlX9nRfP1CymOzcn54kHiFR8ow0Y0dbV 0Kq5YT+Mxabt6kF86X/Xcj1kGjNYzsX+9mxm3w9NbdGydgr4sSKb7ihmsBjVZz6/U02F YYpNvNa3CzqhxJ+k84kzVr+cNFEzAjSndMO128M8Y7ja1kLDb6Hp4Kr6kE1Ustg/obd2 fzR+ZkaXwIGA+hUd9PHclACSIfJhcFOdkEJ9yp5lMPuZN8VB10DXT+pCFfew9EvT6UjY nKUfXU8SLNpI6lmq/58mYyeh7FRrhJflvyyx5uSlArJLV7lpCKSF1YjyZe2Q8htzaEIm KS3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Nx33hXN1LossIpCnrHswpELkvsLkDlmpBkfWihCZXuM=; b=Kjj7jZFq/dSNohWrKxwM6FGpnWEqiTNtPOF9Hs+Wx1cijlGixiqxOMP5Kus0NEnXd6 VH/IyOu5GgIFkMv8TtpT/uyyp9HONeHLOzj5EvX4fCW+KVHPPmLnccNWbib91QQw6N3I iZnn8bA8nF3qNCbM5aeevCSAPN8ImLc+tsVI0UhQ+1GDfO8asx3lNAGdSLIPQCNygtRs AUggl05xVsmHe/qGn2NU5rP+RJMQhUXsAA2arzSjDZdWNC7wbhaJ48UE1JKNEfvT+mCc 5Gj5H/b/4TC97I4vrhTg2QImDiAJrUHdievUo/VIgUpw7GFQzXOa8nKVNfKQZI2VXpI6 donA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=HOBD5ORs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o64-20020a634143000000b0041ad92b64c4si7266011pga.55.2022.07.30.03.24.27; Sat, 30 Jul 2022 03:24:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=HOBD5ORs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236407AbiG3Jlc (ORCPT + 99 others); Sat, 30 Jul 2022 05:41:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236430AbiG3JlR (ORCPT ); Sat, 30 Jul 2022 05:41:17 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D42811A3C; Sat, 30 Jul 2022 02:41:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1659174076; x=1690710076; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=Nx33hXN1LossIpCnrHswpELkvsLkDlmpBkfWihCZXuM=; b=HOBD5ORseN2WuQMaO9M3KfJadt1CLtpjJouJDKH8IdU6TcEbz3k0WKId KRQLm2DM9s/TBqnSKm4g7iyIfjGzlzXoULMOnWoiQ7T+cRoDG5PLYUGqM RK9oa4shfE1ocmD2GohlsgH6ZKKa9M7wWIloQZ+rvpXBu6j8qvOdfmmOS Q=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-01.qualcomm.com with ESMTP; 30 Jul 2022 02:41:16 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2022 02:41:15 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Sat, 30 Jul 2022 02:41:15 -0700 Received: from hyd-lnxbld559.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Sat, 30 Jul 2022 02:41:10 -0700 From: Akhil P Oommen To: freedreno , , , Rob Clark , Bjorn Andersson CC: Jordan Crouse , Jonathan Marek , Douglas Anderson , "Matthias Kaehlcke" , Akhil P Oommen , Abhinav Kumar , Daniel Vetter , David Airlie , Dmitry Baryshkov , Sean Paul , Subject: [PATCH v3 1/8] drm/msm: Remove unnecessary pm_runtime_get/put Date: Sat, 30 Jul 2022 15:10:44 +0530 Message-ID: <20220730150952.v3.1.Icf1e8f0c9b3e7e9933c3b48c70477d0582f3243f@changeid> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1659174051-27816-1-git-send-email-quic_akhilpo@quicinc.com> References: <1659174051-27816-1-git-send-email-quic_akhilpo@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We already enable gpu power from msm_gpu_submit(), so avoid a duplicate pm_runtime_get/put from msm_job_run(). Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/msm_ringbuffer.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_ringbuffer.c b/drivers/gpu/drm/msm/msm_ringbuffer.c index 56eecb4..cad4c35 100644 --- a/drivers/gpu/drm/msm/msm_ringbuffer.c +++ b/drivers/gpu/drm/msm/msm_ringbuffer.c @@ -29,8 +29,6 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job) msm_gem_unlock(obj); } - pm_runtime_get_sync(&gpu->pdev->dev); - /* TODO move submit path over to using a per-ring lock.. */ mutex_lock(&gpu->lock); @@ -38,8 +36,6 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job) mutex_unlock(&gpu->lock); - pm_runtime_put(&gpu->pdev->dev); - return dma_fence_get(submit->hw_fence); } -- 2.7.4