Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp890444imn; Sat, 30 Jul 2022 07:02:11 -0700 (PDT) X-Google-Smtp-Source: AA6agR7urc0cmbhGnlG5LxuDt0036E8oPCkrcnxZNWqk8eHMUupV8aeFojRXag757z7EObrlm9gY X-Received: by 2002:a17:902:b58e:b0:16c:489e:7a0b with SMTP id a14-20020a170902b58e00b0016c489e7a0bmr8396926pls.145.1659189730831; Sat, 30 Jul 2022 07:02:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659189730; cv=none; d=google.com; s=arc-20160816; b=PbV+5/x5aE1i7pz9LW9mV8gSU9QBDzR8Iz9q/AcFJs+RwVUVYW3q+Mdboe2UmnJQqH Qf/99L+6irwHSEpf8ejzJ0U/IvkJH0apVR6/SrSZDUHzAaiVoeIq+PpOmYzAaRK8dDEN Y3+Ws++BZDLFDWPrUDHmAE1SAcPTb+pPOSSb02Z/d82Qn+8/O2KFPfIQvYTjLwnvqIce UmzUnFPOryZUOLzhao9tfb3xIi78Zs1LjyInWtKuecYP4cmwX92ZkC1RoqUfHazXaqCv OL/xyp+45Yn9g4BxCVrY5EHM0ZJXHXaAT5HSfbGyPwmS/7+zHUxt5soMI3Om22FhBjuB IYhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:in-reply-to :from:references:to:content-language:cc:user-agent:mime-version:date :message-id:dkim-signature; bh=aSywYrwf15BzW6MvNi6pyYXRXgcXxNaIrSSYrdc6ocA=; b=x2lomlSKPDoqXVAxGsFWmhX0Ny8MUSrxMa88/cjMpPy4wH4uM/eb6O8DA0uZ3uTZGl slvE3spNI0GKif3q9seJ3mbekYCGSn+KrHU7Xd1t90dyrnwDokaiJIegsqNDSgAUVs5B UfF9Z9iflcMmN6fYWVRN69GC3cAvD8lQaMtR5TpEid64qxI02+vvF3IYggutKyXXsQgd cbJZEAZUVRof3Sr7MuVal0Nqd4DsEYcdshfnrm3mrc4powmbLUjBNtEIot4S5BBzTUUg DCIoTep3taVSYSAgwsandhut6rY5TMjBiVzQx9x3fCsSYtIRZ/2cSlbN+IyyMFpRzvaI NcLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@ext.kapsi.fi header.s=20161220 header.b=Md3+EonK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pj1-20020a17090b4f4100b001f0f378afa0si12180265pjb.172.2022.07.30.07.01.46; Sat, 30 Jul 2022 07:02:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@ext.kapsi.fi header.s=20161220 header.b=Md3+EonK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234456AbiG3NWV (ORCPT + 99 others); Sat, 30 Jul 2022 09:22:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232230AbiG3NWU (ORCPT ); Sat, 30 Jul 2022 09:22:20 -0400 Received: from mailserv1.kapsi.fi (mailserv1.kapsi.fi [IPv6:2001:67c:1be8::25:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCDF51834B; Sat, 30 Jul 2022 06:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ext.kapsi.fi; s=20161220; h=Subject:Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:To:Cc:MIME-Version:Date:Message-ID:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aSywYrwf15BzW6MvNi6pyYXRXgcXxNaIrSSYrdc6ocA=; b=Md3+EonKfWw4OKarokgWoQ8pQN qG/WdCaH8ZbNrYJ2XTGW5lOXrCkAcU2ckWIkQ6H8UZARydrcymwEnjKM6K7Q3zp2UVmvyCMD9WvdA oef89z5sznf9lD0LXSa0iA4FT1wKADamB4RW22QrXcAFrdbzMKrUNqjbeZIoXkS2CQ5Har8rGU1od uiI5GvTJwyNg5Wlv25NdLifiItj1sTfmSTB3o5n6aIpuCo9NF7aXeRl3ziuXLciVxxvTeVxVUvo3W 7vU5ekKY0ctjtXC8MTFlAdd29FjTws4OwQi4CnNi2fHsk07mBJHnrJ72jpV+pcfHwRVolmm8pD6do lgAiW8pQ==; Received: from a82-197-11-249.mpynet.fi ([82.197.11.249]:65186 helo=[10.0.2.15]) by mailserv1.kapsi.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1oHmPP-006Mvo-Nw; Sat, 30 Jul 2022 16:21:36 +0300 Message-ID: Date: Sat, 30 Jul 2022 16:21:32 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Cc: maukka@ext.kapsi.fi, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bhelgaas@google.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, gregory.clement@bootlin.com, linux@armlinux.org.uk, lpieralisi@kernel.org, kw@linux.com, thomas.petazzoni@bootlin.com, pali@kernel.org Content-Language: en-US To: Bjorn Helgaas References: <20220729172251.GA465917@bhelgaas> From: Mauri Sandberg In-Reply-To: <20220729172251.GA465917@bhelgaas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 82.197.11.249 X-SA-Exim-Mail-From: maukka@ext.kapsi.fi X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Subject: Re: [PATCH 0/2] PCI: mvebu: add support for orion soc X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000) X-SA-Exim-Scanned: Yes (on mailserv1.kapsi.fi) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn! On 29.07.22 20:22, Bjorn Helgaas wrote: > On Mon, Jul 18, 2022 at 11:28:40PM +0300, Mauri Sandberg wrote: >> Hello all! >> >> Working in close co-operation with Pali we made an initial attempt at bringing >> support for orion PCIe into mvebu PCIe driver. Currently the address of >> workaround memory range is hard coded and based on compatible string only. As >> Pali describes in another thread, we were not able to figure out what's the >> correct way to configure a configuration space. That discussion is here: >> https://lore.kernel.org/linux-pci/20220710225108.bgedria6igtqpz5l@pali/T/#u >> >> I tested this with D-Link DNS-323 rev A1 and it's working. As usual, all >> comments and feedback is welcome. >> >> Thanks, >> Mauri >> >> Mauri Sandberg (2): >> dt-bindings: PCI: mvebu: Add orion5x compatible >> PCI: mvebu: add support for orion5x >> >> .../devicetree/bindings/pci/mvebu-pci.txt | 1 + >> arch/arm/mach-orion5x/common.c | 13 ---- >> drivers/pci/controller/Kconfig | 2 +- >> drivers/pci/controller/pci-mvebu.c | 59 +++++++++++++++++++ >> 4 files changed, 61 insertions(+), 14 deletions(-) > > Hi Mauri, > > Can you address anything in 2/2 (if necessary), incorporate any acks, > and post a v2? There was some confusion around the first patch (there > are two in the thread, likely the same?), and I didn't read the 2/2 > feedback in detail to see if any changes were needed. > I give it a little bit time to see if the discussion on how to configure the configuration space would pick up, but I'll attend to the comments and post a clean v2 soonish.