Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 31 Jul 2022 16:16:25 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     "Sang, Oliver" <oliver.sang@intel.com>
CC:     lkp <lkp@intel.com>, Vlastimil Babka <vbabka@suse.cz>,
        LKML <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "lkp@lists.01.org" <lkp@lists.01.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        Robin Murphy <robin.murphy@arm.com>,
        John Garry <john.garry@huawei.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: Re: [mm/slub]  3616799128:
 BUG_kmalloc-#(Not_tainted):kmalloc_Redzone_overwritten
Message-ID: <YuY6Wc39DbL3YmGi@feng-skl>
References: <20220727071042.8796-4-feng.tang@intel.com>
 <YuYm3dWwpZwH58Hu@xsang-OptiPlex-9020>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YuYm3dWwpZwH58Hu@xsang-OptiPlex-9020>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hJXB0pPfR2+OEkmUZR8a5RZqjAq2V9ThUr7Gv6PIqAtasfy1piAH8i4ZfZw+?=
 =?us-ascii?Q?SWeed1LivdpeHJMljITiGq0mUKrwDhAxJjAnLK3kTRfwVFOLPed7q+zIvawf?=
 =?us-ascii?Q?CHk+aydXlS/nN11SBd/ElHu70C8Mi1pk5uu5HzMpuchWSFOJQHsiT6SqEXJa?=
 =?us-ascii?Q?JEv7f0TWd082L83y74YuxP+oPfj/8XNKv2NHzjXi9Lnt+0yihYZmT1dZla5v?=
 =?us-ascii?Q?OLMzwvvBVileHcZi+8+6KOTqKU/jKUvvgdxI8w5BW7isTQRSZMk7ZO55K1Ko?=
 =?us-ascii?Q?prgoObPXPw8abvBQFETgoABIxuytjrw4SO3vpH4CFnjAnqBlOMVUw9XN2clu?=
 =?us-ascii?Q?JoUCBdeRzxe+CMjIUtuoPSfLikdvRzue+ZV7u7fiV7HqXZCmfDaKZHHiof3r?=
 =?us-ascii?Q?KQWYm7ySRx3FAGggMhgPtZ5hNEeoBlw8h7oeM3cCsVmYyx0FzK5YJiy2dvsl?=
 =?us-ascii?Q?pBEivaRK03bZL3AiD+Ic8em7lzDBH6271m8wGuWkRAwQ8hGla4nxKHsShNxF?=
 =?us-ascii?Q?SGgpH+csf80KlD7BVOfccObpq5iHOFACM2rthPxHqjM69nboOGGw9ctes88l?=
 =?us-ascii?Q?3XhGBI7G1+KsVmlB4nunrzktjCVTAL1SzXSN6+05GJkNnhzli/msIwqLgwwL?=
 =?us-ascii?Q?//OUYTIj30INpCBkW/JWACAKYjeH/y8ildqPqkWRMHKm/mDL70eo1etcGRJ2?=
 =?us-ascii?Q?VjKyPX7biErgxhwAOzNteznn+AiRiACcgBD7kuWjB0JWg3CnNgsxyZjqfi8i?=
 =?us-ascii?Q?4kXBQ1zVCGLcrUpi8V9cGDU0eGOITHli7RT3fIBp6/Oo4llTlD1PEDoSusBi?=
 =?us-ascii?Q?s1Mmu1T/81T+P7S4LA6poGKGK9e0w4rvRGSuJi9nWBi7oQIG515UBmSQWRaQ?=
 =?us-ascii?Q?WYXExcvtQSCdI2M4n5luQtbsPXz4HApHRu+2C8ozLxOsv+oEKFu8KwTbnU6K?=
 =?us-ascii?Q?0BdvX4ps9V98Bwja8Qy5Ld6B4XnFFzqivxd7yvi82o0yunPyh1rqwHi0VtEq?=
 =?us-ascii?Q?rAXJf/sgUveSqx1b7LYtXCPZtG+wrsO3ShKdzO4zvr3IXGVtlLecIDowkYJi?=
 =?us-ascii?Q?yP28W9qTYb1RZ7EmlyScot4SiLUVreVA+izwzP5XBWWKUxnHScy7Wc+lE8QP?=
 =?us-ascii?Q?ITvTV3KpzKyqopqnnCdMEMG8xmIv4VEU6h64i6uuQhGfyKB+iwW6Cn6hbDmX?=
 =?us-ascii?Q?n5D79dJQrqrxGKx876o57FyJ3Gox/JAoEg0+Yg8iRhc8SGdgnn3CQFB9jVVc?=
 =?us-ascii?Q?D4CbACWfDKhn41GKEZ5fB8nPo+2+Jqu3UW1g0u+/c/ovMJSSbvyTjOH/vtmt?=
 =?us-ascii?Q?g7f67Wqq2ZO1ILBmrLxizvFQes0co7BQiCleDv56aWBDVZ2Ip1LZ+vr1u7pg?=
 =?us-ascii?Q?PLqeXHvT8JQhCT18QeKX9ZASAG8nPD0MHxaNrmz214Q4YV0FTEDl0HTlp/Mr?=
 =?us-ascii?Q?+sKX14B3Zsv8p2PdO0wshwQ2xbMRjpQXErTI1/za/DEArsMYuhpiFN+5ykNi?=
 =?us-ascii?Q?aZkaVAYEHboS6lfzkE4VdqqHWeFGF9w65kWdLuGta3Kqvon6puArZtLi9hju?=
 =?us-ascii?Q?EJMNEliilTrK8XhNOVXfU7nMP20cFaB/MXAWkGsJ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e95b43ee-f771-4cf3-bf72-08da72cd06fe
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2022 08:16:53.9285
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3tUdkUW6dMlH5ZSe/Z8AUAcxlHz+kLWKh7vpEJ2teMuVPLf6omCNLXdnJN2xArsJ4eE+ry/cuN/FXcd9W+g6hg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3083
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Oliver,

On Sun, Jul 31, 2022 at 02:53:17PM +0800, Sang, Oliver wrote:
> 
> 
> Greeting,
> 
> FYI, we noticed the following commit (built with gcc-11):
> 
> commit: 3616799128612e04ed919579e2c7b0dccf6bcb00 ("[PATCH v3 3/3] mm/slub: extend redzone check to cover extra allocated kmalloc space than requested")
> url: https://github.com/intel-lab-lkp/linux/commits/Feng-Tang/mm-slub-some-debug-enhancements/20220727-151318
> base: git://git.kernel.org/cgit/linux/kernel/git/vbabka/slab.git for-next
> patch link: https://lore.kernel.org/linux-mm/20220727071042.8796-4-feng.tang@intel.com
> 
> in testcase: boot
> 
> on test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G
> 
> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
> 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kernel test robot <oliver.sang@intel.com>
> 
> 
> [   50.637839][  T154] =============================================================================
> [   50.639937][  T154] BUG kmalloc-16 (Not tainted): kmalloc Redzone overwritten
> [   50.641291][  T154] -----------------------------------------------------------------------------
> [   50.641291][  T154]
> [   50.643617][  T154] 0xffff88810018464c-0xffff88810018464f @offset=1612. First byte 0x7 instead of 0xcc
> [   50.645311][  T154] Allocated in __sdt_alloc+0x258/0x457 age=14287 cpu=0 pid=1
> [   50.646584][  T154]  ___slab_alloc+0x52b/0x5b6
> [   50.647411][  T154]  __slab_alloc+0x1a/0x22
> [   50.648374][  T154]  __kmalloc_node+0x10c/0x1e1
> [   50.649237][  T154]  __sdt_alloc+0x258/0x457
> [   50.650060][  T154]  build_sched_domains+0xae/0x10e8
> [   50.650981][  T154]  sched_init_smp+0x30/0xa5
> [   50.651805][  T154]  kernel_init_freeable+0x1c6/0x23b
> [   50.652767][  T154]  kernel_init+0x14/0x127
> [   50.653594][  T154]  ret_from_fork+0x1f/0x30
> [   50.654414][  T154] Slab 0xffffea0004006100 objects=28 used=28 fp=0x0000000000000000 flags=0x1fffc0000000201(locked|slab|node=0|zone=1|lastcpupid=0x3fff)
> [   50.656866][  T154] Object 0xffff888100184640 @offset=1600 fp=0xffff888100184520
> [   50.656866][  T154]
> [   50.658410][  T154] Redzone  ffff888100184630: cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc  ................
> [   50.660047][  T154] Object   ffff888100184640: 00 32 80 00 81 88 ff ff 01 00 00 00 07 00 80 8a  .2..............
> [   50.661837][  T154] Redzone  ffff888100184650: cc cc cc cc cc cc cc cc                          ........
> [   50.663454][  T154] Padding  ffff8881001846b4: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a              ZZZZZZZZZZZZ
> [   50.665225][  T154] CPU: 0 PID: 154 Comm: systemd-udevd Not tainted 5.19.0-rc5-00010-g361679912861 #1
> [   50.666861][  T154] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.0-debian-1.16.0-4 04/01/2014
> [   50.668694][  T154] Call Trace:
> [   50.669331][  T154]  <TASK>
> [   50.669832][  T154]  dump_stack_lvl+0x57/0x7d
> [   50.670601][  T154]  check_bytes_and_report+0xca/0xfe
> [   50.671436][  T154]  check_object+0xdc/0x24d
> [   50.672163][  T154]  free_debug_processing+0x98/0x210
> [   50.673904][  T154]  __slab_free+0x46/0x198
> [   50.675746][  T154]  qlist_free_all+0xae/0xde
> [   50.676552][  T154]  kasan_quarantine_reduce+0x10d/0x145
> [   50.677507][  T154]  __kasan_slab_alloc+0x1c/0x5a
> [   50.678327][  T154]  slab_post_alloc_hook+0x5a/0xa2
> [   50.680069][  T154]  kmem_cache_alloc+0x102/0x135
> [   50.680938][  T154]  getname_flags+0x4b/0x314
> [   50.681781][  T154]  do_sys_openat2+0x7a/0x15c
> [   50.706848][  T154] Disabling lock debugging due to kernel taint
> [   50.707913][  T154] FIX kmalloc-16: Restoring kmalloc Redzone 0xffff88810018464c-0xffff88810018464f=0xcc

Thanks for the report!

From the log it happened when kasan is enabled, and my first guess is
the data processing from kmalloc redzone handling had some conflict
with kasan's in allocation path (though I tested some kernel config
with KASAN enabled)

Will study more about kasan and reproduce/debug this. thanks

- Feng
 
> 
> To reproduce:
> 
>         # build kernel
> 	cd linux
> 	cp config-5.19.0-rc5-00010-g361679912861 .config
> 	make HOSTCC=gcc-11 CC=gcc-11 ARCH=x86_64 olddefconfig prepare modules_prepare bzImage modules
> 	make HOSTCC=gcc-11 CC=gcc-11 ARCH=x86_64 INSTALL_MOD_PATH=<mod-install-dir> modules_install
> 	cd <mod-install-dir>
> 	find lib/ | cpio -o -H newc --quiet | gzip > modules.cgz
> 
> 
>         git clone https://github.com/intel/lkp-tests.git
>         cd lkp-tests
>         bin/lkp qemu -k <bzImage> -m modules.cgz job-script # job-script is attached in this email
> 
>         # if come across any failure that blocks the test,
>         # please remove ~/.lkp and /lkp dir to run from a clean state.
> 
> 
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://01.org/lkp