Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 31 Jul 2022 12:51:26 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Tianchen Ding <dtcccc@linux.alibaba.com>
Cc:     ast@kernel.org, linux-kernel@vger.kernel.org, lmb@cloudflare.com,
        sashal@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 5.10 373/575] selftests: bpf: Convert sk_lookup ctx
 access tests to PROG_TEST_RUN
Message-ID: <YuZervPnZnCV32LA@kroah.com>
References: <20211115165356.685521944@linuxfoundation.org>
 <6258c4a1-0132-5afe-8dab-afa4ca3c49d6@linux.alibaba.com>
 <YuEPI/8xAMPl5XDw@kroah.com>
 <d6740ddd-c154-0cba-9ab3-34b55822402a@linux.alibaba.com>
 <2ace00b0-c2db-536f-e55b-f13e02165a8b@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2ace00b0-c2db-536f-e55b-f13e02165a8b@linux.alibaba.com>
Precedence: bulk

On Thu, Jul 28, 2022 at 11:09:32AM +0800, Tianchen Ding wrote:
> On 2022/7/28 11:03, Tianchen Ding wrote:
> > On 2022/7/27 18:10, Greg KH wrote:
> > > On Mon, Jul 25, 2022 at 10:53:38AM +0800, Tianchen Ding wrote:
> > > > Hi Greg.
> > > > 
> > > > We found a compile error when building tools/testing/selftests/bpf/ on 5.10.
> > > > 
> > > > tools/testing/selftests/bpf/prog_tests/sk_lookup.c:1092:15: error: 'struct bpf_sk_lookup' has no member named 'cookie'
> > > > ? 1092 |? if (CHECK(ctx.cookie == 0, "ctx.cookie", "no socket selected\n"))
> > > > 
> > > > It requires 7c32e8f8bc33 ("bpf: Add PROG_TEST_RUN support for sk_lookup programs") from upstream.
> > > > 
> > > > Maybe the left patches of this patchset are needed for 5.10 LTS?
> > > > https://lore.kernel.org/bpf/20210303101816.36774-1-lmb@cloudflare.com/
> > > 
> > > If so, please submit them with the git commit ids so that I can fix this
> > > up.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > These 2 commits from upstream are necessary for bpf selftests build pass on 5.10.y:
> > 607b9cc92bd7208338d714a22b8082fe83bcb177 bpf: Consolidate shared test timing code
> > 7c32e8f8bc33a5f4b113a630857e46634e3e143b bpf: Add PROG_TEST_RUN support for sk_lookup programs
> > 
> > This commit does not impact building stage, but can avoid a test case failure (by skipping it):
> > b4f894633fa14d7d46ba7676f950b90a401504bb selftests: bpf: Don't run sk_lookup in verifier tests
> > 
> > Thanks.
> 
> Or should I submit complete patches?

Yes, please submit complete patches.

thanks,

greg k-h