Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <17aefaaa-ef95-016e-e028-f8091829a508@intel.com>
Date:   Sun, 31 Jul 2022 19:55:15 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.9.1
Subject: Re: [PATCH v10 02/12] iommu: Add max_pasids field in struct dev_iommu
Content-Language: en-US
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Jason Gunthorpe" <jgg@nvidia.com>,
        Christoph Hellwig <hch@infradead.org>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>
CC:     Eric Auger <eric.auger@redhat.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Zhu Tony <tony.zhu@intel.com>, <iommu@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>
References: <20220705050710.2887204-1-baolu.lu@linux.intel.com>
 <20220705050710.2887204-3-baolu.lu@linux.intel.com>
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <20220705050710.2887204-3-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3RKaXNJcHIweW53NDc5SU5TM2FVWTRUN3NVNzV1czBJNUpneW1MTjkrYXRz?=
 =?utf-8?B?cjdFVnkzakJyUHF0cDVkMHByZGZrNFRmd2JwWmc4RkZLd29ERHdSOEUxRmQ4?=
 =?utf-8?B?b1c4TUFzRnJRWlo4ZjEwRCtxM1djQU5rM0N5QWdkNTc3V0ZnM3dMdXZ6bERn?=
 =?utf-8?B?MUpSS2ZnSXgraWM0ZHY2RjJocTZBdUdib0p5YU5PemRzcUdSTUQ4YnBCUUU3?=
 =?utf-8?B?MmdyT2FuWnV3R1hRS1FYbHlDNHFhTUlMSWJjNytUdGVvWkVYbVV4Tm9KTVBl?=
 =?utf-8?B?Z0ExeDMzZGhEM0dqUHFBUEV6SkZLYm5ST0kxa3lSWDJFTzZlMFdzMllqRWk4?=
 =?utf-8?B?TEovUEVBVEFnMjF2bENDNnYzSk5XS2hvRmtNdVZjYi90LzZyNTdWdHVmZUth?=
 =?utf-8?B?a2tVdHlpNWFoWkttT01GY3I5K0haTGdWQlVjTi9RMWpXUXVCYTYxRTZBUk9v?=
 =?utf-8?B?d0k2K2xHMnBXQjg2WS91NWk4NzV5VXFEZHU5UzNLaXdzNGJCV0pRMTVEOE1a?=
 =?utf-8?B?S2VEN1g2a1RJbTlacC9YbHU5VWFhM1JPREQ4TnNDeDRDTVBOcGI3VVQ4bXZq?=
 =?utf-8?B?VnlLaS9QMTl6Ui9SU0xDYnJkV1N2a3F4WnFaRVBITnhkaEhRaGNaM3BVK1dn?=
 =?utf-8?B?djVxR2o0aFZwMDNpaGhoaEJUSXNEL20ydk5GanBNblhaRFdEM1RrclhnVmU1?=
 =?utf-8?B?cHpNWGdaUHNyakZLcU1WS1NNdjNMS0RSREYrUTFBMVEyVUdtOExxWnVLNThG?=
 =?utf-8?B?N0U1RytvZ05UMyt0UFZqaDlPd283c1pXZlk3WURta01HcnZhMmlCNklvU0du?=
 =?utf-8?B?L3JWL2NWeXJVTzRFU3haZXNIYmp1VER2UXh3ck9TbGlPajJFb0tMSjFSMjYx?=
 =?utf-8?B?YlZjcThzTjgrYVdEOVdUcGg5bjh5OTFoYWFXZlBjcDAvMkZYTVI0QkYrbUkr?=
 =?utf-8?B?MUpnYWVxYnhscTFnQ2QzU2FSbmJ4Wk9WQk4vZ0Z2SlJaQXpUbjIrYm16WVMy?=
 =?utf-8?B?QjhXdXdjdmZQTXh0ZWdHT2FpNlo1ZVR6ZUI2WXZQNkM3U0Q4dVplOVMzNlhn?=
 =?utf-8?B?eGdYRFdTSFdDS3hmcXNzd1J2LyszQ0JIREU1R0JFOFprZFA5U1hKOHBCTGF4?=
 =?utf-8?B?MzVRRHVKaWQ5TUNYY3V2eGV4SEplNk8yQmlhMGQ3VVBsL0d5Y01JMklNZDFi?=
 =?utf-8?B?TEIvQVVBWW9ZOXhvV0VuZ2dETnIyTk1NeHE5T1loQzdKVjlYKzFOU3Z2YS9p?=
 =?utf-8?B?alZsMHZZemlIMFRuV0p1WlczWVpwNnN4enFqS3dRc2pGZndTb3RpQXd1Nllv?=
 =?utf-8?B?akhhM2VRSUZQV3lpQXdHSVFxNStzTDFTN0RKa1l2K1Z4VENZd0k5cHovSGpa?=
 =?utf-8?B?SmxqWGIwaDIybVMxNHduL1RsdDZ4M2gxU1lVK3M4Y2NRcHhLZ3grVnRuUHRO?=
 =?utf-8?B?Q2xaRVdjVjVPUVkrRklpUDFRSWJId0h3TGlHbURCWHN3WmhxZGJkYnB4SU9S?=
 =?utf-8?B?WExIRjQvcmhBUmYzS28vaGlTWWwzOUcvV1JZRjJjOHg2NmZtbVlzQnMvbnlD?=
 =?utf-8?B?bjhJVzlOaDlUTW9hNklHQ1BZM0tZeHFyWDRYRml6blNEazA1L0NQVEVlVU5X?=
 =?utf-8?B?aGVYa2pZRkx3eWpJWUIxZUV6RHBDeU1iMHZhNzRvRGJDSjErdkp6M0tUNXdK?=
 =?utf-8?B?V240NDZIWEEvMFR1V0x5WTN5ckw0RXlQTmZtT0hEYWdtSkJVMVJqeDVOaklE?=
 =?utf-8?B?ZjJaODdnaFBJT1FJUFUrU0FjSVl0TmZ3RUVzUFlOUmJPWnU5dXdsOWhMbkx5?=
 =?utf-8?B?MU9tejVqcnJNamR4bzZKZlFIejBkcXZ5NDBFcjNEUDErUW5rbTZvVUZlQStX?=
 =?utf-8?B?UjhHaXhEblR4TURIbmFQTkpNOEpFSWZvQ1F4eURNOXdrTWNjazBRbFBwdTlm?=
 =?utf-8?B?YW1hRlNIS0FOZSt6L0VWd0x1ZVRzbWRFa3pjTmRuR3Q2TFN5YmdQdjAvakVm?=
 =?utf-8?B?YjNua3BUeWFHSS9PTW9jN0FmaDJDOTVhK0NsK3NyWEpTVUd3QzVWYWZSejNH?=
 =?utf-8?B?MmFLUVplcCsyeXNUSmRrTHBMMC9EakpibFIrNVZPWmpYcktJV0MrRGEybUhw?=
 =?utf-8?Q?RpXd4XWxwdQ20q8v4gkG1FOtm?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 090a663f-d358-4a34-66d3-08da72eb85da
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5658.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2022 11:55:11.7722
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LWLKBiXCv1ZidOVPP5FqKozVeRwTjFnyIPx5PWDFfaywtpzD/xHb1PjWNw+WLvximLpvtdYlqglEUXLZQYS1jQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3174
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022/7/5 13:07, Lu Baolu wrote:
> Use this field to save the number of PASIDs that a device is able to
> consume. It is a generic attribute of a device and lifting it into the
> per-device dev_iommu struct could help to avoid the boilerplate code
> in various IOMMU drivers.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Tested-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> Tested-by: Tony Zhu <tony.zhu@intel.com>
> ---
>   include/linux/iommu.h |  2 ++
>   drivers/iommu/iommu.c | 20 ++++++++++++++++++++
>   2 files changed, 22 insertions(+)

Reviewed-by: Yi Liu <yi.l.liu@intel.com>

> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 03fbb1b71536..418a1914a041 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -364,6 +364,7 @@ struct iommu_fault_param {
>    * @fwspec:	 IOMMU fwspec data
>    * @iommu_dev:	 IOMMU device this device is linked to
>    * @priv:	 IOMMU Driver private data
> + * @max_pasids:  number of PASIDs this device can consume
>    *
>    * TODO: migrate other per device data pointers under iommu_dev_data, e.g.
>    *	struct iommu_group	*iommu_group;
> @@ -375,6 +376,7 @@ struct dev_iommu {
>   	struct iommu_fwspec		*fwspec;
>   	struct iommu_device		*iommu_dev;
>   	void				*priv;
> +	u32				max_pasids;
>   };
>   
>   int iommu_device_register(struct iommu_device *iommu,
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index cdc86c39954e..0cb0750f61e8 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -20,6 +20,7 @@
>   #include <linux/idr.h>
>   #include <linux/err.h>
>   #include <linux/pci.h>
> +#include <linux/pci-ats.h>
>   #include <linux/bitops.h>
>   #include <linux/property.h>
>   #include <linux/fsl/mc.h>
> @@ -218,6 +219,24 @@ static void dev_iommu_free(struct device *dev)
>   	kfree(param);
>   }
>   
> +static u32 dev_iommu_get_max_pasids(struct device *dev)
> +{
> +	u32 max_pasids = 0, bits = 0;
> +	int ret;
> +
> +	if (dev_is_pci(dev)) {
> +		ret = pci_max_pasids(to_pci_dev(dev));
> +		if (ret > 0)
> +			max_pasids = ret;
> +	} else {
> +		ret = device_property_read_u32(dev, "pasid-num-bits", &bits);
> +		if (!ret)
> +			max_pasids = 1UL << bits;
> +	}
> +
> +	return min_t(u32, max_pasids, dev->iommu->iommu_dev->max_pasids);
> +}
> +
>   static int __iommu_probe_device(struct device *dev, struct list_head *group_list)
>   {
>   	const struct iommu_ops *ops = dev->bus->iommu_ops;
> @@ -243,6 +262,7 @@ static int __iommu_probe_device(struct device *dev, struct list_head *group_list
>   	}
>   
>   	dev->iommu->iommu_dev = iommu_dev;
> +	dev->iommu->max_pasids = dev_iommu_get_max_pasids(dev);
>   
>   	group = iommu_group_get_for_dev(dev);
>   	if (IS_ERR(group)) {

-- 
Regards,
Yi Liu