Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dd14366b-0b2f-7662-6af9-4ba85848cd9e@intel.com>
Date:   Sun, 31 Jul 2022 20:20:36 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.9.1
Subject: Re: [PATCH v10 06/12] iommu/vt-d: Add SVA domain support
Content-Language: en-US
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Jason Gunthorpe" <jgg@nvidia.com>,
        Christoph Hellwig <hch@infradead.org>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>
CC:     Eric Auger <eric.auger@redhat.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Zhu Tony <tony.zhu@intel.com>, <iommu@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>
References: <20220705050710.2887204-1-baolu.lu@linux.intel.com>
 <20220705050710.2887204-7-baolu.lu@linux.intel.com>
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <20220705050710.2887204-7-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkYvRURSQVZDMDV2SVl2OUNGeXZJNmRaRUg3UmI5NzVRR0hzaW1ybDFmZUh6?=
 =?utf-8?B?WTdiRklZQitlenhEUnFKWGhIWFFGTnl2eDlYNjZnVW0ydkRGd2R2UEF3Uk5P?=
 =?utf-8?B?eUt1Z21TVXZ1bEFtSzJubUpheWF1ZDZPbEMxcnRFNFF6bEdGTnQ0NG9XTGdK?=
 =?utf-8?B?THhScWI0QUdwZGdnZ21EZExnNCtpQk1LVDVJT0hxaTg0ODFpTmpBQ3diSkZk?=
 =?utf-8?B?WHFsZk9SMVRZc1MzTnRnczcvRnFYL1ZWc1NvWTUyaE4rcmRXUnJnT3kvcjVT?=
 =?utf-8?B?ZHdQdVZQNnlxSDdCVEZvWFhpbGFqR1VYYXpzQjB2T3czRHdSYyt4RXZkZVFq?=
 =?utf-8?B?dGZsSVh2Q1N1ZG5YbzZjQkdCaTNrbUxlZE5QSjZsUEhKNi9QTXRXVVlmcERp?=
 =?utf-8?B?QmpTZnlyL0hGQTVFZjB4OXZWTVN2bkFPL3JVQ3c5TWpUdkplQUlCeCsvczlW?=
 =?utf-8?B?Mmx4WHkzZElqSFNlZzJjL3dqMDNBL01aRlZqWm5JWXdkQUwrTFRZQTRIRjk5?=
 =?utf-8?B?bUdtOXRoNXdhelZ5NmkxeU1vSkJwVzdWRDdoSysrVU5sajRibXpkRkU0UmpP?=
 =?utf-8?B?N0Z1SGNpbTE1anB6bkdVM25YaEFaOVorQmhaZk05UndQYmprdlllc0k5T3o2?=
 =?utf-8?B?OGVsRDU5NGVRY0haclBLd2ZMWmJnQzVBQ2xqcm8xTUZMcW40M25NdmV5amlB?=
 =?utf-8?B?R2dvVHZ5K05la1NxZDlMdmdqUGIzTDgzZFJWQzBRUXM5V1BxVHg4SXExRS9q?=
 =?utf-8?B?b3FFaElkdmxuVTJpTkNjNEQwZmhSZmVxcnBQa1N6amdhaEt5K2dNVjAyOExs?=
 =?utf-8?B?RERRT0wrYzZtMnMyeWpjRVE2aHpjNzlUZmhTTUUwNDhaU0l2QXIzQ0w4Ujgz?=
 =?utf-8?B?L1BvNVY0NmdWUzU3SHQ5end3MjFtcHFVZ044d0dubGZFSHcwTTVIYUdHK01R?=
 =?utf-8?B?QTFQdk54MmI5MmUvTnVrdWdmeDFEaWlwakl2R2dHRGhwbndLdk5tYnBiLzhl?=
 =?utf-8?B?aStiUDYwSGlGbVVBcFRVQTIxa3VuQkRyWnRkNnJweGpLajhpWXdFWWRtYlFZ?=
 =?utf-8?B?K0FjWWxVN1dTb3RSMTRJbUpWSkpKVDI0TVZGajZLQ0R3WmlGdllqRThzQkU5?=
 =?utf-8?B?S3MwR1hDREN4ZCtoYkhaVk91MTU2a0Z3RSt4dmUyS2taYWIzQ3pvWkFhTFNC?=
 =?utf-8?B?VWpQemNhV3V1YjJvOG5idmRuM2tyMmI5d0gwa3JoRW1PWk8zV3ZsU0ZiQWRJ?=
 =?utf-8?B?b2grUUxQZGVNRHlWOTE4Ynd0WmRsZ3ZPenFSRytrT1BpWTJNTEdSQ3YvZThp?=
 =?utf-8?B?NmhkSGpEZFJNcSsrK1lTU3RVUUZyNGNVZFRHVmczT0t5cmlqRUFCRC95QTM4?=
 =?utf-8?B?T1BibXdwK043VDRBbllRaEZCeURjMjlxZnJkM0R3Q0RqeE9jYVByV1ZWSUVV?=
 =?utf-8?B?anEwQ0c1VzNNOEtCVk1uSFpSMVBxV2pmV2hQbGZwRU1UYittRVo2cmZteE5r?=
 =?utf-8?B?NDk3UFhRcUVoZ0hkR01FVWhZT0JCbTJCcXprRFZCNUE1ZmlZaDVlNHVpVktO?=
 =?utf-8?B?bi9JVTc4QWtmSXNYL1hwdTV3eWRpSExhRkZmZE56NVRNUHdQWWxwT1lpenhB?=
 =?utf-8?B?Y1U3bUJ3OTh5UDlrVjVScjVXMXQwMUJMVE56N0lMQnJnRm93U0J6czJ1ZHdV?=
 =?utf-8?B?OExTbXJkY3Ayd1ZvT0NheXBlbXZ3eHkzOGIzTVZUMmFqcVhmeDZUWjFHQitP?=
 =?utf-8?B?ejh5SmpLUUNKMElCUGVUTDlvVUVIUGRDYStaVDE3K25wSm1xNStGdmhjQnVj?=
 =?utf-8?B?cDVnQnJySkhHM1gvcXBSTGhwUWhPQWQ0ZTgvRTcrUnVWZ2x0S2oxM2U4NkNW?=
 =?utf-8?B?VUU1RjdWYkVGcmU3YlUzc0d5K2hsemdRZFRMMjd2cDVZN2hMWmY5WjlDb0Fl?=
 =?utf-8?B?K08zQjFHRllieUtMNFE1dHBQYXovOHBSdTZBRDJES1FTUndOeXYzcnhRMWtr?=
 =?utf-8?B?VkhscTRHc2hjZEEzT2ZxejNzOHVYL3dlbDZLUjdDVkllazQwdmd6OGJMaTl6?=
 =?utf-8?B?SkNqc1IvakFXN3VIbE45ZDIzNStiTzJOTkRoQTY3SWxnMGhzTGF6aVA0NDl2?=
 =?utf-8?Q?3bn2jJUxmPIcE5Hk3StG9zF7O?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d12824a-0170-4fc6-7053-08da72ef1043
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5658.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2022 12:20:32.4763
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oQl49b7Lv49XDdTqtdunEUiPEvFRUUDZ9SaHeix40es3XbbJq6uVTqnEXDihdyVHpCJm2Iuq1LtLa646mMxquw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB0026
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022/7/5 13:07, Lu Baolu wrote:
> Add support for SVA domain allocation and provide an SVA-specific
> iommu_domain_ops.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Tested-by: Tony Zhu <tony.zhu@intel.com>
> ---
>   include/linux/intel-iommu.h |  5 ++++
>   drivers/iommu/intel/iommu.c |  2 ++
>   drivers/iommu/intel/svm.c   | 49 +++++++++++++++++++++++++++++++++++++
>   3 files changed, 56 insertions(+)

Reviewed-by: Yi Liu <yi.l.liu@intel.com>

> diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h
> index 31e3edc0fc7e..9007428a68f1 100644
> --- a/include/linux/intel-iommu.h
> +++ b/include/linux/intel-iommu.h
> @@ -743,6 +743,7 @@ void intel_svm_unbind(struct iommu_sva *handle);
>   u32 intel_svm_get_pasid(struct iommu_sva *handle);
>   int intel_svm_page_response(struct device *dev, struct iommu_fault_event *evt,
>   			    struct iommu_page_response *msg);
> +struct iommu_domain *intel_svm_domain_alloc(void);
>   
>   struct intel_svm_dev {
>   	struct list_head list;
> @@ -768,6 +769,10 @@ struct intel_svm {
>   };
>   #else
>   static inline void intel_svm_check(struct intel_iommu *iommu) {}
> +static inline struct iommu_domain *intel_svm_domain_alloc(void)
> +{
> +	return NULL;
> +}
>   #endif
>   
>   #ifdef CONFIG_INTEL_IOMMU_DEBUGFS
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index 44016594831d..993a1ce509a8 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -4298,6 +4298,8 @@ static struct iommu_domain *intel_iommu_domain_alloc(unsigned type)
>   		return domain;
>   	case IOMMU_DOMAIN_IDENTITY:
>   		return &si_domain->domain;
> +	case IOMMU_DOMAIN_SVA:
> +		return intel_svm_domain_alloc();
>   	default:
>   		return NULL;
>   	}
> diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c
> index d04880a291c3..7d4f9d173013 100644
> --- a/drivers/iommu/intel/svm.c
> +++ b/drivers/iommu/intel/svm.c
> @@ -931,3 +931,52 @@ int intel_svm_page_response(struct device *dev,
>   	mutex_unlock(&pasid_mutex);
>   	return ret;
>   }
> +
> +static int intel_svm_set_dev_pasid(struct iommu_domain *domain,
> +				   struct device *dev, ioasid_t pasid)
> +{
> +	struct device_domain_info *info = dev_iommu_priv_get(dev);
> +	struct intel_iommu *iommu = info->iommu;
> +	struct mm_struct *mm = domain->mm;
> +	struct iommu_sva *sva;
> +	int ret = 0;
> +
> +	mutex_lock(&pasid_mutex);
> +	sva = intel_svm_bind_mm(iommu, dev, mm);
> +	if (IS_ERR(sva))
> +		ret = PTR_ERR(sva);
> +	mutex_unlock(&pasid_mutex);
> +
> +	return ret;
> +}
> +
> +static void intel_svm_block_dev_pasid(struct iommu_domain *domain,
> +				      struct device *dev, ioasid_t pasid)
> +{
> +	mutex_lock(&pasid_mutex);
> +	intel_svm_unbind_mm(dev, pasid);
> +	mutex_unlock(&pasid_mutex);
> +}
> +
> +static void intel_svm_domain_free(struct iommu_domain *domain)
> +{
> +	kfree(to_dmar_domain(domain));
> +}
> +
> +static const struct iommu_domain_ops intel_svm_domain_ops = {
> +	.set_dev_pasid		= intel_svm_set_dev_pasid,
> +	.block_dev_pasid	= intel_svm_block_dev_pasid,
> +	.free			= intel_svm_domain_free,
> +};
> +
> +struct iommu_domain *intel_svm_domain_alloc(void)
> +{
> +	struct dmar_domain *domain;
> +
> +	domain = kzalloc(sizeof(*domain), GFP_KERNEL);
> +	if (!domain)
> +		return NULL;
> +	domain->domain.ops = &intel_svm_domain_ops;
> +
> +	return &domain->domain;
> +}

-- 
Regards,
Yi Liu