Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 31 Jul 2022 17:00:57 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Matti =?UTF-8?B?TGVodGltw6RraQ==?= <matti.lehtimaki@gmail.com>
Cc:     linux-iio@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht,
        Lars-Peter Clausen <lars@metafoo.de>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Alexandru Ardelean <aardelean@deviqon.com>,
        Cai Huoqing <cai.huoqing@linux.dev>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: st_sensors: Retry ID verification on failure
Message-ID: <20220731170057.2b8ac00e@jic23-huawei>
In-Reply-To: <20220724164316.68393-1-matti.lehtimaki@gmail.com>
References: <20220724164316.68393-1-matti.lehtimaki@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, 24 Jul 2022 19:43:15 +0300
Matti Lehtim=C3=A4ki <matti.lehtimaki@gmail.com> wrote:

> Some sensors do not always start fast enough to read a valid ID from
> registers at first attempt. Let's retry at most 3 times with short sleep
> in between to fix random timing issues.
>=20
> Signed-off-by: Matti Lehtim=C3=A4ki <matti.lehtimaki@gmail.com>
Hi Matti,

My gut feeling is this isn't in a fast path, so why not just wait
for whatever the documented power up time of the sensor is?

I'd expect to see a sleep in st_sensors_power_enable() if one is
required.

Jonathan

> ---
>  drivers/iio/common/st_sensors/st_sensors_core.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/ii=
o/common/st_sensors/st_sensors_core.c
> index 9910ba1da085..106f7953683e 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_core.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_core.c
> @@ -21,6 +21,8 @@
> =20
>  #include "st_sensors_core.h"
> =20
> +#define VERIFY_ID_RETRY_COUNT 3
> +
>  int st_sensors_write_data_with_mask(struct iio_dev *indio_dev,
>  				    u8 reg_addr, u8 mask, u8 data)
>  {
> @@ -619,11 +621,18 @@ EXPORT_SYMBOL_NS(st_sensors_get_settings_index, IIO=
_ST_SENSORS);
>  int st_sensors_verify_id(struct iio_dev *indio_dev)
>  {
>  	struct st_sensor_data *sdata =3D iio_priv(indio_dev);
> -	int wai, err;
> +	int wai, err, i;
> =20
>  	if (sdata->sensor_settings->wai_addr) {
> -		err =3D regmap_read(sdata->regmap,
> -				  sdata->sensor_settings->wai_addr, &wai);
> +		for (i =3D 0; i < VERIFY_ID_RETRY_COUNT; i++) {
> +			err =3D regmap_read(sdata->regmap,
> +					  sdata->sensor_settings->wai_addr, &wai);
> +
> +			if (!err && sdata->sensor_settings->wai =3D=3D wai)
> +				return 0;
> +
> +			msleep(20);
How do we know 60msecs is long enough for all sensors?

> +		}
>  		if (err < 0) {
>  			dev_err(&indio_dev->dev,
>  				"failed to read Who-Am-I register.\n");