Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1ad99cc0df85c932a7df18f67560930e37976e2b.camel@svanheule.net>
Subject: Re: [PATCH v5 4/5] lib/test: introduce cpumask KUnit test suite
From:   Sander Vanheule <sander@svanheule.net>
To:     =?ISO-8859-1?Q?Ma=EDra?= Canal <mairacanal@riseup.net>,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Brendan Higgins <brendanhiggins@google.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        David Gow <davidgow@google.com>,
        Borislav Petkov <bp@alien8.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "H . Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
        Marco Elver <elver@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Valentin Schneider <vschneid@redhat.com>,
        Yury Norov <yury.norov@gmail.com>
Date:   Sun, 31 Jul 2022 17:42:03 +0200
In-Reply-To: <b6b20883-3fe7-9a5d-ab55-b5a61cef996c@riseup.net>
References: <cover.1659077534.git.sander@svanheule.net>
         <85217b5de6d62257313ad7fde3e1969421acad75.1659077534.git.sander@svanheule.net>
         <b6b20883-3fe7-9a5d-ab55-b5a61cef996c@riseup.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.3 (3.44.3-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Sun, 2022-07-31 at 12:23 -0300, Ma=C3=ADra Canal wrote:
> Hi Sander
>=20
> On 7/29/22 04:01, Sander Vanheule wrote:
> > Add a basic suite of tests for cpumask, providing some tests for empty =
and
> > completely filled cpumasks.
> >=20
> > Signed-off-by: Sander Vanheule <sander@svanheule.net>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Suggested-by: Yury Norov <yury.norov@gmail.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Marco Elver <elver@google.com>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Valentin Schneider <vschneid@redhat.com>
> > Cc: Brendan Higgins <brendanhiggins@google.com>
> > Cc: David Gow <davidgow@google.com>
> > Cc: Ma=C3=ADra Canal <mairacanal@riseup.net>
> > ---
> > Changes since v4:
> > - Belated addition of Yury's Suggested-by:
> > - Follow KUnit style more closely
> > - Drop full check on cpu_possible_mask
> > - Update last check on cpu_possible_mask
> > - Log masks when starting test
> > - Update commit message=20
> > =C2=A0=20
> > Changes since v3:
> > - Test for_each_cpu*() over empty mask and cpu_possible_mask
> > - Add Andy's Reviewed-by
> > - Use num_{online,present,possible}_cpus() for builtin masks
> > - Guard against CPU hotplugging during test for dynamic builtin CPU mas=
ks
> > =C2=A0
> > Changes since v2:
> > - Rework for_each_* test macros, as suggested by Yury
> >=20
> > Changes since v1:
> > - New patch
> >=20
> > =C2=A0lib/Kconfig.debug=C2=A0 |=C2=A0 12 ++++
> > =C2=A0lib/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 1 =
+
> > =C2=A0lib/cpumask_test.c | 147 ++++++++++++++++++++++++++++++++++++++++=
+++++
> > =C2=A03 files changed, 160 insertions(+)
> > =C2=A0create mode 100644 lib/cpumask_test.c
> >=20
> > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > index 2e24db4bff19..e85e74646178 100644
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -2021,6 +2021,18 @@ config LKDTM
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Documentation on how to=
 use the module can be found in
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Documentation/fault-inj=
ection/provoke-crashes.rst
> > =C2=A0
> > +config CPUMASK_KUNIT_TEST
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0tristate "KUnit test for cpu=
mask" if !KUNIT_ALL_TESTS
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0depends on KUNIT
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0default KUNIT_ALL_TESTS
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0help
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Enable to turn on cpu=
mask tests, running at boot or module load
> > time.
> > +
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 For more information =
on KUnit and unit tests in general, please
> > refer
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 to the KUnit document=
ation in Documentation/dev-tools/kunit/.
> > +
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 If unsure, say N.
> > +
> > =C2=A0config TEST_LIST_SORT
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0tristate "Linked list s=
orting test" if !KUNIT_ALL_TESTS
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0depends on KUNIT
> > diff --git a/lib/Makefile b/lib/Makefile
> > index bcc7e8ea0cde..9f9db1376538 100644
> > --- a/lib/Makefile
> > +++ b/lib/Makefile
> > @@ -59,6 +59,7 @@ obj-$(CONFIG_TEST_BPF) +=3D test_bpf.o
> > =C2=A0obj-$(CONFIG_TEST_FIRMWARE) +=3D test_firmware.o
> > =C2=A0obj-$(CONFIG_TEST_BITOPS) +=3D test_bitops.o
> > =C2=A0CFLAGS_test_bitops.o +=3D -Werror
> > +obj-$(CONFIG_CPUMASK_KUNIT_TEST) +=3D cpumask_test.o
> > =C2=A0obj-$(CONFIG_TEST_SYSCTL) +=3D test_sysctl.o
> > =C2=A0obj-$(CONFIG_TEST_SIPHASH) +=3D test_siphash.o
> > =C2=A0obj-$(CONFIG_HASH_KUNIT_TEST) +=3D test_hash.o
> > diff --git a/lib/cpumask_test.c b/lib/cpumask_test.c
> > new file mode 100644
> > index 000000000000..0f8059a5e93b
> > --- /dev/null
> > +++ b/lib/cpumask_test.c
>=20
> In order to make the tests at lib/ with more compliant naming, it would
> make more sense to name it test_cpumask.c.

That's what I had originally, exactly because I copied the naming from othe=
r
files in lib/. That didn't match the style guide [1] which proposes the _te=
st.c
or _kunit.c suffix.

Most files in lib/ use the test_ prefix (45), but some use the  _test.c suf=
fix
(4), or _kunit.c suffix (6). Of the "test_" ones, only 8 are actually KUnit=
 test
suites. I personally think the style guide makes a good argument to use a
suffix, as that clearly places the test suite next to the relevant file in =
an
alphabetic listing.

Based on the above, would you agree with using "cpumask_kunit.c" as the
filename? That distinguishes it from the non-KUnit test files, and follows =
the
style guide.

[1] https://docs.kernel.org/dev-tools/kunit/style.html#test-file-and-module=
-names

>=20
> Thank you for the respin to the series! All tests are passing now.
>=20
> Tested-by: Ma=C3=ADra Canal <mairacanal@riseup.net>

Thank you for testing!

Best,
Sander