Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755970AbXFFOVT (ORCPT ); Wed, 6 Jun 2007 10:21:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761585AbXFFOVD (ORCPT ); Wed, 6 Jun 2007 10:21:03 -0400 Received: from e3.ny.us.ibm.com ([32.97.182.143]:52869 "EHLO e3.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761681AbXFFOVA (ORCPT ); Wed, 6 Jun 2007 10:21:00 -0400 Message-ID: <4666C1AB.2070209@linux.vnet.ibm.com> Date: Wed, 06 Jun 2007 09:16:11 -0500 From: "V. Ananda Krishnan" User-Agent: Thunderbird 1.5.0.12 (X11/20070509) MIME-Version: 1.0 To: linux-serial@vger.kernel.org CC: Chris Snook , linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH TRIVIAL] icom whitespace cleanups References: <4665D3EC.60404@redhat.com> <18021.55632.359206.105260@cargo.ozlabs.ibm.com> In-Reply-To: <18021.55632.359206.105260@cargo.ozlabs.ibm.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 47 Paul Mackerras wrote: > Chris Snook writes: > >> Clean up whitespace and comments in drivers/serial/icom.c > > These changes seem totally unnecessary, as the existing indentation is > according to a commonly-accepted style and is quite reasonable: > I agree with Paul. >> @@ -149,23 +149,23 @@ static void free_port_memory(struct icom >> trace(icom_port, "RET_PORT_MEM", 0); >> if (icom_port->recv_buf) { >> pci_free_consistent(dev, 4096, icom_port->recv_buf, >> - icom_port->recv_buf_pci); >> + icom_port->recv_buf_pci); >> icom_port->recv_buf = NULL; >> } >> if (icom_port->xmit_buf) { >> pci_free_consistent(dev, 4096, icom_port->xmit_buf, >> - icom_port->xmit_buf_pci); >> + icom_port->xmit_buf_pci); > > etc. etc. The comment changes I agree on but not most of the other > whitespace changes. The comment changes are fine with me too. > > Also you don't seem to have cc'd the driver author. > Current contacts for the driver are: Ananda (mansarov@us.ibm.com) and Wendy (wenxiong@us.ibm.com) :- Ananda > Paul. > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/