Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp1534637imn; Sun, 31 Jul 2022 10:50:36 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vxO7OCY3CeJZIYThT6rHnzq6JwrDcnjIZMndjLV2cMjsiclNdYPntD5XrskDuwFLx/jDkj X-Received: by 2002:a05:6a00:f85:b0:52a:c718:ff9 with SMTP id ct5-20020a056a000f8500b0052ac7180ff9mr12559544pfb.85.1659289836210; Sun, 31 Jul 2022 10:50:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659289836; cv=none; d=google.com; s=arc-20160816; b=cXSxQASfzCsKSHhF2w4OAxZWrbAJX1YnCDq7JXe2BXrLF++Ehn7WXi9E8gRnxNKRBS NF64heEIVMzjV76TthdISal2rE6Y0AQmAyTptFz09C+fISjhHCLPorEoZyWXl4kx7i40 O7JdSRg+1weZ+72hYfIakYRFr5XIAwfiR/XKNJCPL/ZdDmpgbiYthv6Q30fBq5DEyBLj /744tekNrHp7SwoG4X8NWs1T/X86upSO6rzm2F3yicbA8o/Z3IuhfJlgyGodeeFoMQzc 4s7xP7MiUwQp24JBa2eBLr+lA5KEEDJrufYalKf+f5iOW0/xxqEiwkNbAQTb8890eNtt 0kcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=qETYSfZ6q4u7uDWODOAGDerJeYCRda63JuWIzekUf08=; b=fi786l2WPcxRt7YOugIv5BtDPGz1BIyfdfNK7+U+jILm7QEPziduSRLM2Rte2tYvjC 3Cvp9lnK3JAEw4c8lCfkyR4dVmgvnVtFCVLEUGTMtjmYr2xltTdWfc6D39toPq4h6ByV StbIAHXICwSIFDIWqWqV77MJcAujeC1p2mdsXfpqxIdF+V5IOVx/ab2JU0jmuxdp/EKp zdMxr4JHJebHaO1fmIXP/gdNHnJ7i1y5Nx4UG2AMDb91LqchCZpAGwusIC+Floo/vGXB g+hQSldBJ5ymXZGsE4OIt54ZQAT97h6Ie1Vd5MuhngmSk3sBfw8eMh/G9VBtZkyNmY6Z Vp8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FP5onuuD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s22-20020a63dc16000000b00411ef13f705si10395774pgg.296.2022.07.31.10.50.21; Sun, 31 Jul 2022 10:50:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FP5onuuD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234198AbiGaRtj (ORCPT + 99 others); Sun, 31 Jul 2022 13:49:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbiGaRth (ORCPT ); Sun, 31 Jul 2022 13:49:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7998DB4A9; Sun, 31 Jul 2022 10:49:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C697260FEB; Sun, 31 Jul 2022 17:49:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD7C1C433D6; Sun, 31 Jul 2022 17:49:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659289772; bh=3A75P4su/8E8y0yASTst8ObkOtAbAvd6xg9cUj4Lnl0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FP5onuuDGImR7EX5M/M6q1jONwRdIgLbCc3URSda8B83ujN+FuZUBt896XxObyGat Y3Zg0Oq/ZT4tKNn+DUDAfR37zHEtBtpCCnJI6xtdSRDQk8TdSIX9+tfwO9T6PM9ymw JXHw6d7/kQsGlsUE1nCLFNhzyUewU3aykapVm9bC2xBgUanobR1trQajZsc2yL3Kh9 An/F1TQdq78gZw7YHPzIlFS8/V0CcdUSGkS+d4lmuc9subCB9j6Pyit9l3MXMNew/0 hXgsyiLBEd7dKXrAZM6QKHUhGyJ8A/oLkP5UMfaJhSnZHaAInKYgL6Ws/LizpNvhJz E7aJzLObwjJQA== Message-ID: <5431c5e4-a8b0-738c-5143-3976cb904b9a@kernel.org> Date: Sun, 31 Jul 2022 19:49:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V9 01/16] rv: Add Runtime Verification (RV) interface Content-Language: en-US To: Steven Rostedt , Tao Zhou Cc: Wim Van Sebroeck , Guenter Roeck , Jonathan Corbet , Ingo Molnar , Thomas Gleixner , Peter Zijlstra , Will Deacon , Catalin Marinas , Marco Elver , Dmitry Vyukov , "Paul E. McKenney" , Shuah Khan , Gabriele Paoloni , Juri Lelli , Clark Williams , Randy Dunlap , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org References: <0197dd47-ea15-4d8b-5fc7-e466d8a501a7@kernel.org> <20220731124730.311c8207@rorschach.local.home> <20220731130144.26576a6a@rorschach.local.home> From: Daniel Bristot de Oliveira In-Reply-To: <20220731130144.26576a6a@rorschach.local.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/31/22 19:01, Steven Rostedt wrote: > static int da_monitor_init_##name(void) \ > { \ > int slot; \ > \ > slot = rv_get_task_monitor_slot(); <- if this returns positive, things break \ > if (slot < 0 || slot >= RV_PER_TASK_MONITOR_INIT) \ > > And we probably need slot to be negative if it is greater or equal to RV_PER_TASK_MONITOR_INIT. > > return slot; \ > ok, there will be a problem when RV_PER_TASK_MONITOR_INIT changes to > 1. This will need to be patched to return negative. So far we have only one because there is only one per task monitor. -- Daniel