Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 31 Jul 2022 13:53:55 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Daniel Bristot de Oliveira <bristot@kernel.org>
Cc:     Tao Zhou <tao.zhou@linux.dev>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Jonathan Corbet <corbet@lwn.net>,
        Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Will Deacon <will@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Marco Elver <elver@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Gabriele Paoloni <gpaoloni@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Clark Williams <williams@redhat.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH V9 01/16] rv: Add Runtime Verification (RV) interface
Message-ID: <20220731135355.713859c5@rorschach.local.home>
In-Reply-To: <5431c5e4-a8b0-738c-5143-3976cb904b9a@kernel.org>
References: <cover.1659052063.git.bristot@kernel.org>
        <a4bfe038f50cb047bfb343ad0e12b0e646ab308b.1659052063.git.bristot@kernel.org>
        <YuU7TGxm5pzmBFTx@geo.homenetwork>
        <0197dd47-ea15-4d8b-5fc7-e466d8a501a7@kernel.org>
        <YuaadlzgSJLtzOUw@geo.homenetwork>
        <20220731124730.311c8207@rorschach.local.home>
        <20220731130144.26576a6a@rorschach.local.home>
        <5431c5e4-a8b0-738c-5143-3976cb904b9a@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 31 Jul 2022 19:49:23 +0200
Daniel Bristot de Oliveira <bristot@kernel.org> wrote:

> On 7/31/22 19:01, Steven Rostedt wrote:
> > static int da_monitor_init_##name(void)                                                         \
> > {                                                                                               \
> >         int slot;                                                                               \
> >                                                                                                 \
> >         slot = rv_get_task_monitor_slot();  <- if this returns positive, things break           \
> >         if (slot < 0 || slot >= RV_PER_TASK_MONITOR_INIT)                                       \
> > 
> > And we probably need slot to be negative if it is greater or equal to RV_PER_TASK_MONITOR_INIT.
> > 
> >                 return slot;                                                                    \
> >                                   
> 
> ok, there will be a problem when RV_PER_TASK_MONITOR_INIT changes to > 1. This will need to be patched to
> return negative. So far we have only one because there is only one per task monitor.
> 

Exactly. And reviewers like Tao and myself are going to continue to
flag it as a bug as we don't assume that RV_PER_TASK_MONITOR_INIT will
stay 1 ;-)

-- Steve