Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 1 Aug 2022 02:17:49 +0800
From:   Tao Zhou <tao.zhou@linux.dev>
To:     Daniel Bristot de Oliveira <bristot@kernel.org>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Jonathan Corbet <corbet@lwn.net>,
        Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Will Deacon <will@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Marco Elver <elver@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Gabriele Paoloni <gpaoloni@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Clark Williams <williams@redhat.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-trace-devel@vger.kernel.org, Tao Zhou <tao.zhou@linux.dev>
Subject: Re: [PATCH V9 03/16] rv/include: Add helper functions for
 deterministic automata
Message-ID: <YubHTTjXez6n8KkN@geo.homenetwork>
References: <cover.1659052063.git.bristot@kernel.org>
 <563234f2bfa84b540f60cf9e39c2d9f0eea95a55.1659052063.git.bristot@kernel.org>
 <YuacJsPya8PSE8qt@geo.homenetwork>
 <7b3f7ec1-a479-f3ed-42b3-ddead0f9b427@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7b3f7ec1-a479-f3ed-42b3-ddead0f9b427@kernel.org>
Precedence: bulk

On Sun, Jul 31, 2022 at 06:02:47PM +0200, Daniel Bristot de Oliveira wrote:
> On 7/31/22 17:13, Tao Zhou wrote:
> > On Fri, Jul 29, 2022 at 11:38:42AM +0200, Daniel Bristot de Oliveira wrote:
> > 
> > [...]
> > 
> >> +static inline type model_get_next_state_##name(enum states_##name curr_state,	\
> >> +					       enum events_##name event)	\
> >> +{										\
> >> +	if ((curr_state < 0) || (curr_state >= state_max_##name))		\
> >> +		return INVALID_STATE;						\
> >> +										\
> >> +	if ((event < 0) || (event >= event_max_##name))				\
> >> +		return INVALID_STATE;						\
> > 
> > Should define the INVALID_EVENT corresponding to event invalid case.
> 
> no.

Absolutly I lost here, this is for *get next state*, must return
a state info.

> 
> -- Daniel