Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <7c3918d7cce9643414697cef02ef636f05efb003.1659266359.git.christophe.jaillet@wanadoo.fr>
 <CAHp75VfHBvpy-u766n7A8HYEcWBZGrqsyi2mOnh96oPTSOuVdw@mail.gmail.com>
In-Reply-To: <CAHp75VfHBvpy-u766n7A8HYEcWBZGrqsyi2mOnh96oPTSOuVdw@mail.gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sun, 31 Jul 2022 21:49:11 +0200
Message-ID: <CAHp75VfwOEyFENgj8C+nPpgYmCw39s5Sg1jrLaCV-RHob0EVPQ@mail.gmail.com>
Subject: Re: [PATCH] mfd: intel_soc_pmic: Fix an error handling path in intel_soc_pmic_i2c_probe()
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Andy Shevchenko <andy@kernel.org>, Lee Jones <lee@kernel.org>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Shobhit Kumar <shobhit.kumar@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kernel-janitors <kernel-janitors@vger.kernel.org>,
        Lee Jones <lee.jones@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Jul 31, 2022 at 9:37 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Sun, Jul 31, 2022 at 1:19 PM Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
> >
> > The commit in Fixes: has added a pwm_add_table() call in the probe() and
> > a pwm_remove_table() call in the remove(), but forget to update the error
> > handling path of the probe.
> >
> > Add the missing pwm_remove_table() call.
>
> ...
>
> I guess it should be rebased on top of [1] which I assume will go into v5.20...
>
> [1]: https://lore.kernel.org/lkml/20220718122328.8287-1-andriy.shevchenko@linux.intel.com/

...And now I realize that I have sent some BS there, heh...
I need to send a v2, so I will take your patch as a precursor.


-- 
With Best Regards,
Andy Shevchenko