Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c7a0251b-403b-37b4-6b17-5e5e2b7c318a@wanadoo.fr>
Date:   Sun, 31 Jul 2022 22:24:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2 02/10] mfd: intel_soc_pmic_crc: Merge Intel PMIC core
 to crc
Content-Language: fr
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Lee Jones <lee.jones@linaro.org>,
        Hans de Goede <hdegoede@redhat.com>,
        linux-kernel@vger.kernel.org
Cc:     Lee Jones <lee@kernel.org>, Andy Shevchenko <andy@kernel.org>
References: <20220731201258.11262-1-andriy.shevchenko@linux.intel.com>
 <20220731201258.11262-2-andriy.shevchenko@linux.intel.com>
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <20220731201258.11262-2-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 31/07/2022 à 22:12, Andy Shevchenko a écrit :
> The core part is misleading since its only purpose to serve Crystal Cove PMIC,
> although for couple of different platforms. Merge core part into crc one.
> 
> Advantages among others are:
> - speed up a compilation and build
> - decreasing the code base
> - reducing noise in the namespace by making some data static and const
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Tested-by: Hans de Goede <hdegoede@redhat.com>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> ---
> v2: added tags and rebased on top of new patch 1
> 
>   drivers/mfd/Makefile              |   3 +-
>   drivers/mfd/intel_soc_pmic_core.h |  25 -----
>   drivers/mfd/intel_soc_pmic_crc.c  | 163 ++++++++++++++++++++++++++++--
>   3 files changed, 158 insertions(+), 33 deletions(-)
>   delete mode 100644 drivers/mfd/intel_soc_pmic_core.h
> 

Hi,

in v1, there was a:
    drivers/mfd/intel_soc_pmic_core.c | 160 -----------------------------
    delete mode 100644 drivers/mfd/intel_soc_pmic_core.c

Is it expected not to have it in v2?

CJ