Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <294083c1-2049-350c-52a8-5a39a7a7d229@linux.alibaba.com>
Date:   Mon, 1 Aug 2022 10:33:41 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] mm: migrate: Do not retry 10 times for the subpages of
 fail-to-migrate THP
To:     "Huang, Ying" <ying.huang@intel.com>
Cc:     akpm@linux-foundation.org, ziy@nvidia.com, shy828301@gmail.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <1658405108-100658-1-git-send-email-baolin.wang@linux.alibaba.com>
 <875yjhoj7g.fsf@yhuang6-desk2.ccr.corp.intel.com>
From:   Baolin Wang <baolin.wang@linux.alibaba.com>
In-Reply-To: <875yjhoj7g.fsf@yhuang6-desk2.ccr.corp.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/28/2022 2:16 PM, Huang, Ying wrote:
> Hi, Baolin,
> 
> Baolin Wang <baolin.wang@linux.alibaba.com> writes:
> 
>> If THP is failed to migrate due to -ENOSYS or -ENOMEM case, the THP will
>> be split, and the subpages of fail-to-migrate THP will be tried to migrate
>> again, so we should not account the retry counter in the second loop, since
>> we already accounted 'nr_thp_failed' in the first loop.
>>
>> Moreover we also do not need retry 10 times for -EAGAIN case for the subpages
>> of fail-to-migrate THP in the second loop, since we already regarded the
>> THP as migration failure, and save some migration time (for the worst case,
>> will try 512 * 10 times) according to previous discussion [1].
>>
>> [1] https://lore.kernel.org/linux-mm/87r13a7n04.fsf@yhuang6-desk2.ccr.corp.intel.com/
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> 
> I have tested this patch, and it works as expected.
> 
> Tested-by: "Huang, Ying" <ying.huang@intel.com>

Thanks.

> 
>> ---
>> Note, this patch is based on the patch set [1] from Huang Ying.
>> [1] https://lore.kernel.org/linux-mm/20220711084948.274787-1-ying.huang@intel.com/
> 
> Please this patch is based on my patchset that hasn't been merged.  I
> can add it as the last patch of my migrate_pages failure path fixing
> patchset if you don't object.

Sure, please fold it into your series. Thanks for helping.