Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c5968cf4-c63f-eb70-136b-cb002810f115@nvidia.com>
Date:   Mon, 1 Aug 2022 10:41:59 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH linux-next] IB/cm:Change the conditional statements
Content-Language: en-US
To:     cgel.zte@gmail.com, linux-kernel@vger.kernel.org
Cc:     linux-rdma@vger.kernel.org, ye xingchen <ye.xingchen@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
References: <20220801023146.1594841-1-ye.xingchen@zte.com.cn>
From:   Mark Zhang <markzhang@nvidia.com>
In-Reply-To: <20220801023146.1594841-1-ye.xingchen@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aU5HLzN6TzUwRlZ5dDVKZW1KdjNadHhvYUFYNCtmcTE0eURIMzY2c0U0emE0?=
 =?utf-8?B?QVpNSlRsQU5mcXdiS0xBbklHOW9MMXdPQXdyNDJKUVJjMnVCN0tWRlNNOE9L?=
 =?utf-8?B?RmhEdFBUMXFweWx3bGxzL3ZybGtNMGdpcW4veTNJUnBKK3N3VGRoRHZzNjly?=
 =?utf-8?B?WVJ5OFVxT2FqUVNtSGdLUHduY20zS0dvUmVaYUV4QUU4Z2pzSGtVVzBBemF4?=
 =?utf-8?B?ZWFyMExqTE1Xd1hGQkluNHg4TUFSZ05Jbm5DYnRkdGNWdHpNdTRDUlVTdDln?=
 =?utf-8?B?aFFPYk1xMGFBU0kxWTRmbHViWlgxYTdqL1FQZ2E0a2lqN2doeUtIckxhSCsx?=
 =?utf-8?B?aGRVeVBUWXVPRjlWVmV1ZEswSTZFL1FNOFpFUlIvTGNDYzQ5ZGJuVWt4Rk03?=
 =?utf-8?B?Qmx0SDdiQTZ2cUo2SWZMZFhXcmowbXFDdlJJMU5qaDFEZnI3MnBPUDRlb2Uw?=
 =?utf-8?B?NVVRME1rbGxpU1oySXIxTkJFZmJWZVEzZGRWOUFwcVhyMEZRd3NTUEhUbmRn?=
 =?utf-8?B?Z0ZFcTFqREFJb01xV2prOFA0RU0zejVDY0RwcTJ3VzF1T25LM1hCb25ZZ2Uw?=
 =?utf-8?B?d0dOVUZTaVM5Qi9FSDhNRkVlbHdudmhwMTlLb0grcE5CZkR3RDAxS0hOZkly?=
 =?utf-8?B?b2ZKL0o4a05OK2ZZVmc0ZGtkT2pxaW94SlZockJLZUVJbEdCWVMzVTRqQXhE?=
 =?utf-8?B?ZWZzbkh6TllKYzlmRDYraDdvZmw0LzNoc0p1ZU5MdU9MeHpjL0xNbVZ4OGJh?=
 =?utf-8?B?djMrKzJ0N2owdjE3RThQb1hGN1NGclQ5UjRvdmRlRmx5NkdBbWlhODdEOE1o?=
 =?utf-8?B?U1EvMUNiVEdNUmVsWmpQWGNCeTJmYWpzN215YkhjZ3hqaU41MVhsYTUyU2pU?=
 =?utf-8?B?MXJCcHpscUpjVVZxaW44QVc5anpwdHB5d3J5TjhpQWgxYWp4RVhOV3V1MUND?=
 =?utf-8?B?VlNsQTArZVBpZzFpdE5hck1nOWhyZXViY0FqWFBXR0lFUjd0WTZ4b2FQUUlj?=
 =?utf-8?B?cDNRTy9vTm96YkYvQnY2RDY5QkFTRHAzekRZU25BQURIMnpXYmN3dm4wVzVV?=
 =?utf-8?B?K1hXUDRFb0tzUVB2TjE5MUtMK3ZHWlc0ZWFRK3R2dWFwWVFjbWRVVURZZ0RK?=
 =?utf-8?B?cHJXM25Da2lnenRXdkIvd29OZ29PM0l6M0RjOXFmNVZXL3Y0VVYwb2xYVmFL?=
 =?utf-8?B?TjJmaExhdjEwaFNRVmNBMzZ4NnN0UEtZRG5VcHdCM3YvK0F0cVRBNDNCM05z?=
 =?utf-8?B?ZHZCSWFobkwwaDB3WkNRWTdDejBqaW55VEpROTNYZzRRclNoOFBuOXdRbG1T?=
 =?utf-8?B?QnhwNUYranhYa1dZb21xc29zT2ptUUo5T1h1bXRlK3hYRmxtTEE3NGMzUFM3?=
 =?utf-8?B?U2JQM04xcUFISUNWZG5DZVY2WEJ0YVcvSmk2d245cW5rMTRmdzYxRVpSOEwy?=
 =?utf-8?B?ZEh3Ykg4d3hLMDQ3cGp5eW10amVtZTArU3BoZU95c2V3NEhmUXM1dU5Wdmti?=
 =?utf-8?B?SG8xN1JBd05GNGFpRzVhZkJYYUZMMEgzajVrMVdCYTlPOFdOdjNuRDI2WjZ3?=
 =?utf-8?B?cDNvdUFhNitrQVZtdzByb0QvWFovdnpRMy9WTVphZ1Z3S09TRVJPTXdha2Vm?=
 =?utf-8?B?SCs3TTlIOVJ0QmlFc0ZzUUNFeHVZalRBOWhtaXpQMUw3cm9VUFBaNGZxdit5?=
 =?utf-8?B?b01LR2dNN0lNb24wSnRKNWV3dm1BSS9TeEk1enRiRWJSN0JrWXE3RnJ1RGdv?=
 =?utf-8?B?ZTllUUNRZzhQTGprZ2dQd3JVMXpnbUFhZEFERGhoR0FISEh3TmpEeUtvU3Vt?=
 =?utf-8?B?NUNOUDZHb0hyQWNaYnk5TG1udVhUQkR5TXVOOEVjZW94RUR6NDRFUjVYMW1m?=
 =?utf-8?B?QUJqOFYxMnZMVytTRWRoSnVQcUdsN1BvanpXdG9QYUJwUiszWlpJOGdiV1cw?=
 =?utf-8?B?SVYxZk9mdnFWY0VnMVJoOHZpL0RLTXlBUUZXQTllTVZtWDR6bXlzVDk4NjZt?=
 =?utf-8?B?U1JzVElTSEJCL0ljZGNKTms3TmZ1YXhBYTA4eSszak52S0xBUzdYQXNheGg4?=
 =?utf-8?B?eVdlK1BDRHFkeVZDdHFaVEI5eVhMSkc2bk9QM3QzdUtlZEFlZjAxVHYra1BI?=
 =?utf-8?Q?4Osda7oYU7/TDDjJ5gsWtpD4X?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7e30c1b-652b-4fa2-f092-08da73676d24
X-MS-Exchange-CrossTenant-AuthSource: CY4PR12MB1366.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2022 02:42:07.9590
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nGpDvvdkt1xVCR6gyLKAtaLKew8FcZPf+Hc5duJiKdykT3Fbz9+yEFHEo8ippPFkM8jqFjXqbSl3aQW9l90ZZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4283
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/1/2022 10:31 AM, cgel.zte@gmail.com wrote:
> External email: Use caution opening links or attachments
> 
> 
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Conditional statements could changed to be easier explain.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
>   drivers/infiniband/core/cm.c | 9 ++-------
>   1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
> index b985e0d9bc05..6e323d0c0fce 100644
> --- a/drivers/infiniband/core/cm.c
> +++ b/drivers/infiniband/core/cm.c
> @@ -676,14 +676,9 @@ static struct cm_id_private *cm_find_listen(struct ib_device *device,
>                          refcount_inc(&cm_id_priv->refcount);
>                          return cm_id_priv;
>                  }
> -               if (device < cm_id_priv->id.device)
> +               if (device < cm_id_priv->id.device ||
> +                   be64_lt(service_id, cm_id_priv->id.service_id))
>                          node = node->rb_left;
> -               else if (device > cm_id_priv->id.device)
> -                       node = node->rb_right;
> -               else if (be64_lt(service_id, cm_id_priv->id.service_id))
> -                       node = node->rb_left;
> -               else if (be64_gt(service_id, cm_id_priv->id.service_id))
> -                       node = node->rb_right;
>                  else
>                          node = node->rb_right;
>          }
> --
> 2.25.1

This is not correct, ref.:
https://lore.kernel.org/lkml/20220624201733.GA284068@nvidia.com/t/