Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <yuji2.ishikawa@toshiba.co.jp>
To:     <gregkh@linuxfoundation.org>, <oded.gabbay@gmail.com>
CC:     <jiho.chu@samsung.com>, <arnd@arndb.de>,
        <linux-kernel@vger.kernel.org>
Subject: RE: New subsystem for acceleration devices
Thread-Topic: New subsystem for acceleration devices
Thread-Index: AQHYpNMiuKJkJQ8DYkaebqXY59xh6q2YnUkAgACqcZA=
Date:   Mon, 1 Aug 2022 02:29:52 +0000
Message-ID: <TYAPR01MB62013A228CD094847524F8D8929A9@TYAPR01MB6201.jpnprd01.prod.outlook.com>
References: <CAFCwf11=9qpNAepL7NL+YAV_QO=Wv6pnWPhKHKAepK3fNn+2Dg@mail.gmail.com>
 <YuahxB6geST6ZtGN@kroah.com>
In-Reply-To: <YuahxB6geST6ZtGN@kroah.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?WG14WVc5MUxuN2FBVWVpWUczcFo2a1M5SFNiazhtYy9kZXJ0RTY0VGU5?=
 =?iso-2022-jp?B?MFRXMkdYSHhXR1dDSW5TUmN3Q295ZXNtRm9ROExSNkZYVmtyNnpBSThh?=
 =?iso-2022-jp?B?VGQ3NnFUQmZUaW9aVjdxVTZrR3V3dlF0UDMrZTlyQlRWcndJZUpsYytn?=
 =?iso-2022-jp?B?S2JIMEdyd29ObmZmSnFVMkJJNndqMWNQUkRYNmFNc0VnWmtVS1ZnS2Fx?=
 =?iso-2022-jp?B?NWQ3WUc2bEpPeXBkcHNyNTQrKzFiWVlCT3libmlpQWs5bWtIUFNBWUEw?=
 =?iso-2022-jp?B?MnlpVUZtT3FrdHhSRUhvZzFiUk5yTUpYQW5MVndvMkhLRndCdmZRRE03?=
 =?iso-2022-jp?B?TThBdVdKbGlrTTV4b1dTdTI3YzNUWXBReXMrbUhmQjJPRnlha2FWUFdZ?=
 =?iso-2022-jp?B?RDk2dHFhZFlPVmpoelpEdng2UlZLRGN3UnU4a0twQWZ2VWo4QTFCRGls?=
 =?iso-2022-jp?B?aG1GeDhDOTQxTUxSbkxrWVZjbXNNSzRUNkxOeGk4bzZXTGdoYm9MS2R0?=
 =?iso-2022-jp?B?SmFmeW5CUis1anZLdHROMjFEVGZFd0lXV0lmQUIvSmJLY2RHUi9BaXR4?=
 =?iso-2022-jp?B?TndEU3ZiUEhjeS9qQVFjenpwTTByYmE3Z3hXMFhLbE5lc3ZkZnJJV1NH?=
 =?iso-2022-jp?B?bTFIbGFTanVsYTc3Y2VPQ1hlZzIvMGx4ZjR5eWxzM3FGMkhaeFVuSVlo?=
 =?iso-2022-jp?B?MldYMmZBd2JOQVFzVVQrd0kvSEs5cnUwQjdOVGtHVHRsMFJZOW9zTU9J?=
 =?iso-2022-jp?B?NDNZOFpmWUlLdEYyTHRhMmRIdlpaTk1rQ3pKMXJ6aUVoOEJhKzg1bzhy?=
 =?iso-2022-jp?B?c1JmTnJVcFkxY2wvRHdxR0N5REJTVm0rd0l2S1AvUXh0OFVhcVdwcEZX?=
 =?iso-2022-jp?B?b0c3elVQQytLSHhzZCs3WTFYQWlYcllpR2lDZ29sdy9mNEpFTENZbWcz?=
 =?iso-2022-jp?B?VkxBNUdtWWRISlZrdnZRNm9NR3hNYjVOY1ZEWVhGUFB3ZXdhbTNmNkhn?=
 =?iso-2022-jp?B?RTJtQmpiYTNKdkthekIyQXlibVJyV3F1TUcyL3lJdENBUkRvdHgzK3pa?=
 =?iso-2022-jp?B?WjhiRzhjaWNoYmNNbnVBTUR5VmFweC8yenRidTlmSUE5dC83NkFKL3RG?=
 =?iso-2022-jp?B?a0c0MGJOVXVCT0txWEs4Ny9zdy9KYnlQU0Y1clVGdmMyMWdtRjNuWVM5?=
 =?iso-2022-jp?B?MzIyTTU5Nm1qd0VzNDNOeEI1RzFrQzJxa3Irc2JkK3dlQUF6M3hoN2FE?=
 =?iso-2022-jp?B?TlI5SHpKZlpDbWl0ZUk1akhiaThpM0lROVlUWE1KVjBJR2dKczNzRWg2?=
 =?iso-2022-jp?B?bEVWMHp4SnIybHFuSFM0cDd0UnBmVW0wMTlvcmJGZXprbW54ZnlvbjRN?=
 =?iso-2022-jp?B?Smd1dHJrVkdmRDVhandnWkdhRUhVSWtaWEZKempkWEtzdUNSVmN2UWFV?=
 =?iso-2022-jp?B?UWtMb0Q4TmtabkRwc3pBRm5NZnlHcWs5R01ZNkt3T0gzbG0yMnhlV094?=
 =?iso-2022-jp?B?VDc4ckZQV0lPUytwY3lhWXBpVVN4dVR5THJkazdMQUNNa3pJemNtUEt3?=
 =?iso-2022-jp?B?SzlYNm55N2sydmFFTFpLTHk3ejhuVzZTOFRyTzdaa29nM2hyd05qckhN?=
 =?iso-2022-jp?B?SnhpWS9POFVIbndiSjRkc1FOMU9GVWdRZWZ6QTRSTlJHSGZ4bnl3bTBt?=
 =?iso-2022-jp?B?bFZrRFdvMERWRU9WNysyMk1tTTA5TE4zM0p0MWZvdWpwbVQyVUFzSEUw?=
 =?iso-2022-jp?B?VU41b2Q1Tlg3U3J2b1ptVjF5dzN3a1c3WEgyeWJUOHFKUjJNVzlHMFpi?=
 =?iso-2022-jp?B?WTZ2Zmt1ZWRFRDlFaXlxcm50MElLaVdFaVFRcUNkb3VYbmV2YmNHcmJm?=
 =?iso-2022-jp?B?L3NzZlZxa1pLWUU0QmZRNkx2L2l5ZUpqR3B2RXNDdkVIS2w4aVhzTkxu?=
 =?iso-2022-jp?B?a216a0VSK2xzYjlWRndrNkt0ckl5dnRiZFQwR29RZktxTXpCMnVMeHQy?=
 =?iso-2022-jp?B?dTZYdVJWbXJpZWZTK0hCenl1ZHl5MTlKY1hDRlFSTTVHN0dHcll3MXBQ?=
 =?iso-2022-jp?B?b3BNTXliYXk2NXg2aUNMWU5MV04zT1JscTRLbHFvMHptTlI5Y1hsT1Zt?=
 =?iso-2022-jp?B?S3BoM3ZsdnlNVU9aTk5ubTJqUDU2R2JJNC9vSzFuWS9kZEJpeXBBdmxy?=
 =?iso-2022-jp?B?Z3hvdFEzM0lOZWFFYjFHYmxDUnVZdThxQ040dGtnVk9uVmlPVmMwVkx5?=
 =?iso-2022-jp?B?MXVPckVPekZVNGZHQ0E3K2s4UVovMklvTmo3eGZHVWlxZW9EV2NSeks5?=
 =?iso-2022-jp?B?dWVqRHBPY1BmR3pnUWZhRkVnc0tZbGdSb0E9PQ==?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYAPR01MB6201.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e61a0f6-7084-4de0-6467-08da7365b6cb
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2022 02:29:52.1708
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f109924e-fb71-4ba0-b2cc-65dcdf6fbe4f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VwVlEBEdQrVzrNcoehJ9x6d99OStKmxaADnEkIn/DK+X6bYNhlR32WYAQupLEN7MSHRYonhNFABs3Wh3RZDkwtEBqDjAYieAPCLEw96tz6g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB2458
X-OriginatorOrg: toshiba.co.jp
MSSCP.TransferMailToMossAgent: 103
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Sent: Monday, August 1, 2022 12:38 AM
> To: Oded Gabbay <oded.gabbay@gmail.com>
> Cc: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
> <yuji2.ishikawa@toshiba.co.jp>; Jiho Chu <jiho.chu@samsung.com>; Arnd
> Bergmann <arnd@arndb.de>; Linux-Kernel@Vger. Kernel. Org
> <linux-kernel@vger.kernel.org>
> Subject: Re: New subsystem for acceleration devices
> 
> On Sun, Jul 31, 2022 at 02:45:34PM +0300, Oded Gabbay wrote:
> > Hi,
> > Greg and I talked a couple of months ago about preparing a new accel
> > subsystem for compute/acceleration devices that are not GPUs and I
> > think your drivers that you are now trying to upstream fit it as well.
> >
> > Would you be open/interested in migrating your drivers to this new
> subsystem ?
> >
> > Because there were no outstanding candidates, I have done so far only
> > a basic and partial implementation of the infrastructure for this
> > subsystem, but if you are willing to join I believe I can finish it
> > rather quickly.
> >
> > At start, the new subsystem will provide only a common device
> > character (e.g. /dev/acX) so everyone will do open/close/ioctl on the
> > same device character. Also sysfs/debugfs entries will be under that
> > device and maybe an IOCTL to retrieve information.
> >
> > In the future I plan to move some of habanalabs driver's code into the
> > subsystem itself, for common tasks such as memory management, dma
> > memory allocation, etc.
> >
> > Of course, you will be able to add your own IOCTLs as you see fit.
> > There will be a range of IOCTLs which are device-specific (similar to
> > drm).
> >
> > wdyt ?
> 
> That sounds reasonable to me as a sane plan forward, thanks for working on
> this.
> 
> greg k-h

Hi,
Thank you for your suggestion.
I'm really interested in the idea to have a dedicated subsystem for accelerators.
Let me challenge if the Visconti DNN driver can be re-written to the framework.
As Visconti SoC has several accelerators as well as DNN,
having a general/common interface will be a big benefit for us to maintain drivers for a long time.

I've heard that the framework has some basic implementation.
Do you have some sample code or enumeration of idea to describe the framework?
Would you share them with me? if that does not bother you.

If you need further information on the current DNN driver, please let me know.
Also, I can provide some for other accelerator drivers which are currently under cleaning up for contribution.

Regards,
	Yuji