Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20220729024645.764366-1-apopple@nvidia.com>
 <YuQ4mJqjIUncf7iF@nvidia.com>
 <8f1f3278-ce9e-e328-6a8b-a793bc7f950f@nvidia.com>
User-agent: mu4e 1.6.9; emacs 27.1
From:   Alistair Popple <apopple@nvidia.com>
To:     John Hubbard <jhubbard@nvidia.com>
Cc:     Jason Gunthorpe <jgg@nvidia.com>, akpm@linux-foundation.org,
        minchan@kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, pasha.tatashin@soleen.com
Subject: Re: [PATCH] mm/gup.c: Simplify and fix
 check_and_migrate_movable_pages() return codes
Date:   Mon, 01 Aug 2022 12:38:05 +1000
In-reply-to: <8f1f3278-ce9e-e328-6a8b-a793bc7f950f@nvidia.com>
Message-ID: <87sfmgd6l0.fsf@nvdebian.thelocal>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?84WVe6+dCTPzfrX0LKtqXRJpAXAGLRb3liiRtzHgsExjf6KyjUjnnPkt6DaI?=
 =?us-ascii?Q?F9vhZoBSc4MdYy+xgNZRy2Ej9yNr7E9QsjMRBwoG/arHlowwZsGLE6dXCp5P?=
 =?us-ascii?Q?zP8aSH5A9lnGqXY2Z6r9nfR26JmYlxtQKCEpbGYxTrMcLblz1576w6Co1yW7?=
 =?us-ascii?Q?dvu/GvNxRUCv6lRQqv8+mFK+4TKBC4z5sMf7OjHUgFozw5mZxiLHx46Whcfj?=
 =?us-ascii?Q?M1Qr3jsmRsRsWVfHpioO+EsK/tbjrAS4j5kgYcDD4jbwY3Wa57gk7VzSHhIS?=
 =?us-ascii?Q?7DDXxNlTOlRDP1EVQrmGo5khMkmylBBNTwQbRMVWTRK198pzVdhr2UfwntbA?=
 =?us-ascii?Q?nT+hU5Ypmcbs7Qs2U56nhDToCJAGnykXecpjOBL9HuxwKBRxGkN86Fq6zzVz?=
 =?us-ascii?Q?Ro10bbg5HugNE2rQHz5ILxNbPoG3KfjOmUut/PSQ4mmAqKAnnzSxxPLPfDr5?=
 =?us-ascii?Q?HCYwgzYs0uKXP6lIy/M+5oQGrNR2tARUbLmi8TA8fqFUspVTtuKEemHOknfa?=
 =?us-ascii?Q?revttH7Byy0F8h0OSIf6GV6sQutKdaKPR+QYdTqBJxQz+6gdg+mKXqnDDc8e?=
 =?us-ascii?Q?TgmurO++yhk3hs8I3uoaa26oiC7RzUqwVDR9L+HZ3mbkPS67L02t6Hz66zBO?=
 =?us-ascii?Q?qLn5G/c67lgwvWP2jtm9wZlCWvb12nmaBYxpkTHeT2BeM0XeHYIwX24LWIqB?=
 =?us-ascii?Q?vI6Z9hCnABiQQljx9TnnQmJT+/FiI6BPlQL9ZIoUW/Z5jW77weoERVjMVFo8?=
 =?us-ascii?Q?ImucVxWbQugLKhiTaYyCR9nCutK2L9fFlN1e5+rmtILV1VG8xSKzdnsJBkSP?=
 =?us-ascii?Q?hq/B1+hNNuZDSUELC4rVyQ9gAIvSz7rrpyl0bn6dQ2asf6FHhrunmQQ0PpEX?=
 =?us-ascii?Q?3piINKj2XrSD09s6SOJPsMymSQyck6bddqK2MtXj5cy/W+FDngXzsB1IkgmE?=
 =?us-ascii?Q?pSeU16rGN5G4qVjmGvBQ4LJSVpFByO1xirW9G5/tCuQRveAPX5ToFGq7Aray?=
 =?us-ascii?Q?Cg2Dts7pkEDbDk2ojS+osJvX5dGDyhCnlgqhLy2aBPBXLNYCXh71qXBORWw0?=
 =?us-ascii?Q?Q4fSkI/JnGJuZWBxd54Mes7IxwNbhahQ/MA8wijbg+mFvlgtRlMZdDV4pr+t?=
 =?us-ascii?Q?LCUbpNafG5x+F14ECOFFhheXk1rCNMfSPxYL7q2wuOOTmQmo1LdDQOUw+MxF?=
 =?us-ascii?Q?RpDMFPDxD7cvcJziJ7/E69hX+R79C7Y7+xBuvOPlZjuSJz1LOTonJV3b1II8?=
 =?us-ascii?Q?80p1Ng0dLpMLvZDsq1iQnfB8eJ5i/w+KJbaePpl8D5GsLALtmNtTjqb3Yh+4?=
 =?us-ascii?Q?C39s5b2CJzavv4A93T0Lk6c+SCks+Po3mp/vUkPnamJ0hxqm1BdFuVpG2jiE?=
 =?us-ascii?Q?2xPbXOqDZj4FYzAqc+1zSDVEKBj8WNARUbSJ9ERQNUJbOMM3Xeca6sQNYXp2?=
 =?us-ascii?Q?+y/dEVRNrTPslpnU8kzNeqQH542GUs0/GgKMzpHigsZHFSktK4rDxNjjJmMA?=
 =?us-ascii?Q?2kpsf7OtvXgJmsnCtMNzEyjs6JbO9kk18Bj/zoaYtIwtzHoALrSeThH+Vklj?=
 =?us-ascii?Q?j0ZdT1NywUMi/LRicG4q1euPrM0OhF56G0DSzQtv?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2c3bff8-868d-4436-0dfa-08da7367fc85
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2022 02:46:08.2844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2zcFb3yzgAAPT47WpoLc9T6HTcgImmz2jDpX6Z24IwXNXbdsYSwKaYUqeUQYy6xgV9DsKtnMspWHojMrDVDUWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1584
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


John Hubbard <jhubbard@nvidia.com> writes:

> On 7/29/22 12:44, Jason Gunthorpe wrote:
>
>> I came up with this ontop:
>>
> That cleans it up even more, looks nice. I'd go just a touch further,
> and also (unless there is some odd reason?) stay with -EAGAIN rather
> than -EBUSY, because otherwise both the function's comment header, and
> the caller, should change from -EBUSY to -EAGAIN just for consistency.

We return both:

-EBUSY to indicate that we should fail the entire PUP operation. -EAGAIN
 to indicate to __gup_longterm_locked() that the pages have been
 unpinned and it should repin them and check again.

> And also because the way it's used: the caller is literally "trying
> again".
>
> So on top of the ontop:
>
> diff --git a/mm/gup.c b/mm/gup.c
> index 43c1fc532842..5f04033ee0ed 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -1901,10 +1901,12 @@ struct page *get_dump_page(unsigned long addr)
>
>  #ifdef CONFIG_MIGRATION
>  /*
> - * Check whether all pages are pinnable. If some pages are not pinnable migrate
> - * them and unpin all the pages. Returns -EAGAIN if pages were unpinned or zero
> - * if all pages are pinnable and in the right zone. Other errors indicate
> - * migration failure.
> + * Check whether all pages are pinnable. If some pages are not pinnable, migrate
> + * them and unpin all the pages.
> + * Return values:
> + *       0:      all pages are already pinnable and in the right zone
> + *      -EAGAIN: some pages were unpinned or were zero
> + *      -ENOMEM: migration of some pages failed
>   */
>  static long check_and_migrate_movable_pages(unsigned long nr_pages,
>  					    struct page **pages,
> @@ -1914,11 +1916,11 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
>  		.nid = NUMA_NO_NODE,
>  		.gfp_mask = GFP_USER | __GFP_NOWARN,
>  	};
> -	unsigned long i;
> +	unsigned long i, not_migrated;
>  	struct folio *prev_folio = NULL;
>  	LIST_HEAD(movable_page_list);
>  	bool drain_allow = true, coherent_pages = false;
> -	int ret = -EBUSY;
> +	int ret = -EAGAIN;
>
>  	for (i = 0; i < nr_pages; i++) {
>  		struct folio *folio = page_folio(pages[i]);
> @@ -1990,7 +1992,7 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
>
>  	/*
>  	 * Unpin all pages. If device coherent pages were found
> -	 * migrate_deivce_coherent_page() will have dropped the pin and set
> +	 * migrate_device_coherent_page() will have dropped the pin and set
>  	 * pages[i] == NULL.
>  	 */
>  	for (i = 0; i < nr_pages; i++) {
>
>
> thanks,