Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp1739297imn; Sun, 31 Jul 2022 20:32:05 -0700 (PDT) X-Google-Smtp-Source: AA6agR5DpTPGHpmnwptj2qq+aCOtfsSZirensI0kNNfGalTaG1bpITvg9naIJiHjd/eao30l1MeG X-Received: by 2002:a17:90a:8001:b0:1f4:fe95:c420 with SMTP id b1-20020a17090a800100b001f4fe95c420mr3653306pjn.146.1659324725202; Sun, 31 Jul 2022 20:32:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659324725; cv=none; d=google.com; s=arc-20160816; b=bHuQvHDakZXBbgUZ/CAcA8B4hVygMvUUpHfSPk/U2GpBGD1Mzlci/XxJYFobzxUNEF 0VFGdj1Cur7huoAizdTwKiYEB99GKQD+kdA410n/aH4XpdXWV524y9yJVQdS/TD7UthO qe+f++BL+xHseJaCATk6px7MIA2bWyHT945H2chWjzDvDf6i2p4wLaAxf3gmhYTXUDmV Q5QHXjuQKzvPJe6dJlMFRfymFErEHxqziT+mpg8qEEm2D3Et78oCfU6BN3e7FeNxaQP7 2Wh1itJbbJk46q9D822B0kfbA00Gue3fHfxIIlQbrYuLPtW71LSc9F+2vnNCjHTqPzvh lXfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=GNxvEO8zKMF9CuL60442aziMrziKJwXDy+lUG20M/ag=; b=LXGXWUyNVdg3gz92ODxj9Lxqkfg1GllP8jD4D03usZ3kx7dEsP92oEHSTz4TIoQocz 6g+tgIvBncSh6ZzUVqLm8oqrylRc0IyA4pK55vhKmo++FysSmHsj4UbeKyrq+xgfFq+2 808idNokDeSHr1n341MqG8os83x/lDiVcLTwQz5Q4Bn8UP/HNC5jM9qbomHCm0LW7Ki2 L+5+aDcuE01YxpU94A99wtCd3G6NWpQFjXknTX1Udx2eMMBB3pv9PIdI9pnVcWqfqk/I 63gCuu24winiDgqsZ8UjxE/2SgqYcHVXL0FVets9pytLjqB0U5cb3ztFX/7nz63NZqvX Mfng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="iyx3d/ND"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t62-20020a638141000000b0041b8f2bd530si3789546pgd.217.2022.07.31.20.31.39; Sun, 31 Jul 2022 20:32:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="iyx3d/ND"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239203AbiHADX7 (ORCPT + 99 others); Sun, 31 Jul 2022 23:23:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237074AbiHADX4 (ORCPT ); Sun, 31 Jul 2022 23:23:56 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B429C65B1; Sun, 31 Jul 2022 20:23:55 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id q7so10888490ljp.13; Sun, 31 Jul 2022 20:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=GNxvEO8zKMF9CuL60442aziMrziKJwXDy+lUG20M/ag=; b=iyx3d/NDu2nKpMoy/Z9uAw6CuiuFJYmEEu4gVHmqdwBt5ror1Ahn3BNZL1p+OmS9HE tAyIPEko9+xcgfN/Je26e00wMf18DiARtGozbBZRu4XaFfijI2YJ1oOIIq0CMr9spXu2 gi4ZVOjpKapMxnbUlHVaXaqDmaXALMj9+WD8ojtm6zhn7JMOGlvHC9r1PpAPfYIdT/8E 5deVq7qTyvZBBlec470JvDLuZzF8vEiT+4etz6i/E+rlNeM6m9tz/ywPWCtAlo6cM74i 3dDoNaDkeNIs2CGOpop3eiqjG9K21J0xneISc9BX6XowptUOuOtuL7Au/vbnV7crIYFh xPbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=GNxvEO8zKMF9CuL60442aziMrziKJwXDy+lUG20M/ag=; b=C7gCt1igVj2Swks3cQDGuUJfLlMbJUwzH/vs+t6YTYUPuPx+MPGegUx2n/ijcmneh1 g0LBqaaZZbFO6djAGe/PxuTPok8MrUAsqVECkkQvBBR9kWzZjgfKqdRy6gzTX+BMkwY2 euUj7BB2Te4lW0oRQYV0hMy16kbVbsgANYddk8NCNb1N0Kfkt0P/MTeCqyno4EDdO+5n W2kA7NPMhQ+0bKLSxNyFyFvnBmW585EPZx1rjp0Tz9Gu1VY6bIOLbHWqVs76hPE0JRAD x8sRY+CTAmmBX7+ma7wOhrbgUYveSp+lqLeOBp2+nsLugVX+56Ibm3cMTFBTBsdnKICD PVGg== X-Gm-Message-State: AJIora8ud5PWpejrIMEgibiFaCylZKGCXbNbfFylb3Nr80IkfWxyg12B Jx6B0mgHVpGsOTFwjSnQTJXVx6KwLNQ6tGWZaw== X-Received: by 2002:a05:651c:98d:b0:25d:eb67:7160 with SMTP id b13-20020a05651c098d00b0025deb677160mr4247395ljq.385.1659324233799; Sun, 31 Jul 2022 20:23:53 -0700 (PDT) MIME-Version: 1.0 References: <20220720204414.1.I699244ea7efbd326a34a6dfd9b5a31e78400cf68@changeid> In-Reply-To: <20220720204414.1.I699244ea7efbd326a34a6dfd9b5a31e78400cf68@changeid> From: Stanley Chu Date: Mon, 1 Aug 2022 11:23:42 +0800 Message-ID: Subject: Re: [PATCH] ufs: core: ufshcd: use CLOCK_BOOTTIME for debugging timestamps To: Daniil Lunev Cc: Adrian Hunter , Bart Van Assche , Alim Akhtar , Avri Altman , Bean Huo , Daejun Park , "James E.J. Bottomley" , "Martin K. Petersen" , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniil, On Wed, Jul 20, 2022 at 6:49 PM Daniil Lunev wrote: > > CLOCK_MONOTONIC is not advanced when the system is in suspend. This > becomes problematic when debugging issues related to suspend-resume: > the timestamps printed by ufshcd_print_trs can not be correlated with > dmesg entries, which are timestamped with CLOCK_BOOTTIME. > > This CL changes the used clock to CLOCK_BOOTTIME for the informational > timestamp variables and adds mirroring CLOCK_BOOTIME instances for > variables used in subsequent derevations (to not change the semantics of > those derevations). > > Signed-off-by: Daniil Lunev > Regarding the suspend/resume issue breakdown with aligned timestamp with the dmesg logs, perhaps we need to use "sched_clock()" since it is the timestamp used by dmesg? Thanks, Stanley