Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: RE:(2) [PATCH v5 3/6] scsi: ufs: wb: Add explicit flush sysfs
 attribute
Reply-To: j-young.choi@samsung.com
Sender: Jinyoung CHOI <j-young.choi@samsung.com>
From:   Jinyoung CHOI <j-young.choi@samsung.com>
To:     Bart Van Assche <bvanassche@acm.org>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
In-Reply-To: <82d1e6da-df4b-31bb-ec46-76099d7c3288@acm.org>
Message-ID: <20220801052718epcms2p11e9e1677abbc0e573cddff4e641e212f@epcms2p1>
Date:   Mon, 01 Aug 2022 14:27:18 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <82d1e6da-df4b-31bb-ec46-76099d7c3288@acm.org>
        <20220729045433epcms2p77ff2cdde6ddffd9ab0b0810ebe84f0e5@epcms2p7>
        <20220729045252epcms2p7fee5c1cdca5e4bef02a833e40f80649b@epcms2p7>
        <20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p8>
        <20220729045600epcms2p45c0f8a5a0a76c7fe85b0961570de89ce@epcms2p4>
        <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p1>
Precedence: bulk

>On 7/28/22 21:56, Jinyoung CHOI wrote:
>> diff --git a/Documentation/ABI/testing/sysfs-driver-ufs b/Documentation/ABI/testing/sysfs-driver-ufs
>> index 6b248abb1bd7..7e9e1db55d60 100644
>> --- a/Documentation/ABI/testing/sysfs-driver-ufs
>> +++ b/Documentation/ABI/testing/sysfs-driver-ufs
>> @@ -1417,6 +1417,16 @@ Description:	This node is used to set or display whether UFS WriteBooster is
>>   		platform that doesn't support UFSHCD_CAP_CLK_SCALING, we can
>>   		disable/enable WriteBooster through this sysfs node.
>>   
>> +What:		/sys/bus/platform/drivers/ufshcd/*/wb_buf_flush_en
>> +What:		/sys/bus/platform/devices/*.ufs/wb_buf_flush_en
>> +Date:		July 2022
>> +Contact:	Jinyoung Choi <j-young.choi@samsung.com>
>> +Description:	This node is used to set or display whether WriteBooster
>                      ^^^^
>
>Please change "node" into "attribute" (here and below). Sysfs files are 
>called attributes.
>

The wb_on description is also written as node.
This will also be changed to other commit.


>> +		buffer flusing is enabled. The data written in the WriteBooster
>                        ^^^^^^^
>                        flushing?
>> +		Buffer can be flushed by an explicit host command or
>> +		implicitly while in hibernate (HIBERN8) state.
>
>The above sentence is misleading because it suggests that setting this 
>attribute causes the WB buffer to be flushed in its entirety. That is 
>not correct - what this attribute controls is whether or not the UFS 
>device is allowed to start with flushing the WB buffer.
>

It seems to have been written so briefly.
Because each device manufacturer may have different flush policies,
So, I did not describe the amount. This is the same as the ufs spec.
I will add more explanation.
And, I don't fully understand your comment (That is not correct ~)
If you explain it more, I will consider it.


>> +	if (!ufshcd_is_wb_allowed(hba) ||
>> +	    (hba->quirks & UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL)) {
>> +		dev_warn(dev, "It is not allowed to configure WB buf flush!\n");
>
>flush -> flushing
>

OK, I will fix it.


>> +	ufshcd_rpm_get_sync(hba);
>> +	res = ufshcd_wb_toggle_buf_flush(hba, wb_buf_flush_en);
>> +	ufshcd_rpm_put_sync(hba);
>> +out:
>> +	up(&hba->host_sem);
>> +	return res < 0 ? res : count;
>> +}
>
>Please leave a blank line above goto labels as requested by the kernel 
>coding style guide.
>
>Thanks,
>
>Bart.

OK, I will fix it.
wb_on_store() will also be modified with this. (other commit)

Kind Regards,
Jinyoung