Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp1798956imn; Sun, 31 Jul 2022 23:50:07 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tmtExSiakpFENpamLNBzIfB6m0OwMK/tW/aJNJcZxubk/0PCpooglwy5eWHcKOnHZxmqqJ X-Received: by 2002:a63:905:0:b0:415:fcde:2423 with SMTP id 5-20020a630905000000b00415fcde2423mr12574317pgj.374.1659336607528; Sun, 31 Jul 2022 23:50:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659336607; cv=none; d=google.com; s=arc-20160816; b=Iyu1bpHjCRB9IkCeP3/+csC7ugAyO7+U183BQICLZOOcetnOAtnMh/ikMGnGKlXhdj 9qsB+FbNXC3q30Bub9zqN5XmDR7ThnwDD1uFptWyx7mSYXDamhVQIIEVzkUL4tXOqmnn skyEtgEexJyCnWFXSbaviesCheaJO96KwjnE9r6c0ifIckOqN3KNzMIV97zmi6ckCaen pS5MIqas9WICpG4MemNtnmmzOUBPRE01mQUcML15hbQOYrh1gmjqdvkNjf0K10TqFaIs Z3UXa428cET66xzYHq8p6maAccuCrG1o/s2+sFSGYlYuAQr5rvNGL+nMrw//GSACF+Vd BzkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GbgF0LLWJDZYO2w1Ddew1umRr4H0L7EKWjkDsSsyfSI=; b=mpjVGLoWvBQxI+nPJDKZN9tZOId4rCRc45Ru4HH46p6olMi3DuCWCtihquVyn3vOMf hnNGHmT6mhWjbHcQlWHhNpWrUntmn8Jd4b3OQ12eAEFjGvLZkE24MUjbjSChd0NdjJQU VfPt7PiFjge4SCPjpMZpu4VOBbiT2fhgin5ZJtjsqYSGY54B/ehkjo+02F7FBDVMEEry +O+Gb2MnOWx1bRFZ/8nnsrwsBnFlPheDo+zJK90KZ4iXZ4qlq9aDhEbnGKmuOIgIN0v0 c2shgYrjsd6+nTZCZPAxFTmIFmv0fSe0yT8FbDjILYMEXxZyJqLnembmioSqENoUqFms KOaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LHF4HuYL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ji6-20020a170903324600b0016ef4ad8b68si961348plb.303.2022.07.31.23.49.53; Sun, 31 Jul 2022 23:50:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LHF4HuYL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231686AbiHAGr6 (ORCPT + 99 others); Mon, 1 Aug 2022 02:47:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231866AbiHAGrg (ORCPT ); Mon, 1 Aug 2022 02:47:36 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54BE3B4B3; Sun, 31 Jul 2022 23:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659336317; x=1690872317; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cbqXcDjp4IBB8KsWVje8p2Ad+jjJ0kLCJwU06mgi6Z4=; b=LHF4HuYLXytjwY/cWGpyOVbf+Ly60vBhkG+wbJvkg0k3FumDyAYEj7hT YT5RLX9osV1Gb7IZ0eevMdCVI5Eu5+ch4sOwVE49NJCVb/2GIBrJ8whya amZJOk7Kec72Qo8pZbR2pEW97vRm1HiKH4fC2t8gmVjYExpTicZ8nHgVI sMFRHFVI7eTLlLZ3GabMh/WA/CTO+TKPM+1uUIAjOn8E+LDwyk0HW87+F qpc3ZgQehXTj+C9Qu8iFxubo6PjIePNGK2fGFSrPTDKyMkHrLeEOIiUlO elf/m6CsRQ9fem7QtOti2Bs+k8bpgecTF+UDp7NF74+liwGFG1uuXFVZ6 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10425"; a="314897901" X-IronPort-AV: E=Sophos;i="5.93,206,1654585200"; d="scan'208";a="314897901" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jul 2022 23:45:12 -0700 X-IronPort-AV: E=Sophos;i="5.93,206,1654585200"; d="scan'208";a="552410211" Received: from punajuuri.fi.intel.com (HELO paasikivi.fi.intel.com) ([10.237.72.43]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jul 2022 23:45:10 -0700 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id F071A2019B; Mon, 1 Aug 2022 09:45:07 +0300 (EEST) Date: Mon, 1 Aug 2022 06:45:07 +0000 From: Sakari Ailus To: Andy Shevchenko Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Greg Kroah-Hartman Subject: Re: [PATCH v1 1/1] media: atomisp_gmin_platform: Unexport and split camera_sensor_csi() Message-ID: References: <20220730162027.1011-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220730162027.1011-1-andriy.shevchenko@linux.intel.com> X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 30, 2022 at 07:20:27PM +0300, Andy Shevchenko wrote: > The camera_sensor_csi() is not used outside the module, hence make it > static. While at it, split it to _alloc() and _free() to clearly show > the idea behind the last parameter @flag that is passed to > gmin_csi_cfg(). > > Signed-off-by: Andy Shevchenko Thanks! Acked-by: Sakari Ailus -- Sakari Ailus