Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 1 Aug 2022 12:17:36 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Joe Perches <joe@perches.com>
Cc:     Phillip Potter <phil@philpotter.co.uk>, gregkh@linuxfoundation.org,
        Larry.Finger@lwfinger.net, paskripkin@gmail.com, martin@kaiser.cx,
        straube.linux@gmail.com, fmdefrancesco@gmail.com,
        abdun.nihaal@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: r8188eu: convert rtw_set_802_11_add_wep
 error code semantics
Message-ID: <20220801091735.GB3460@kadam>
References: <20220728231150.972-1-phil@philpotter.co.uk>
 <20220728231150.972-3-phil@philpotter.co.uk>
 <20220729064803.GT2338@kadam>
 <YuV452xuR1S0WyJi@OEMBP14.local>
 <f93d3ea32ac04a5edd8159abcb0504f71fe7aee4.camel@perches.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f93d3ea32ac04a5edd8159abcb0504f71fe7aee4.camel@perches.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RWKSq6sCXNgNe/Ezetxa6lfv86sMX3gZPuZh0ob/DKrYkzqc8/VmvsJsZi9S?=
 =?us-ascii?Q?yhKIS3tbudxh0UeDkqlWaKp8IkcHbmGT5Vr33u6Vp0V6qFm+TZo4IfajVzmc?=
 =?us-ascii?Q?wDFe8BPiJt2140LYqc2V8ILgDGhR/uvZzhVpRgi4njURHYcxDnb4MuQU/ats?=
 =?us-ascii?Q?uOs+24ijhAPw0Q+fJyY2xtqWZOHxAE9VnMacJM2j1daQoPhoI4DVYmRVUGZy?=
 =?us-ascii?Q?0AF/ccpV1QD6cE5n62ni4JlvjOpdImom4h5RIe6iKZuU7wV4MmzFHzGveOUU?=
 =?us-ascii?Q?Hw3PJ0xk5UNBaq7WyozUmvWhY9uxFPtAHPghHN3MrnhnwB0rIo/Ec95r6rcJ?=
 =?us-ascii?Q?u3Y6kozS6PugLRBRZjg+uayXEXcymT51DAZciDDyufc3wDMwu1UmM66a8xM+?=
 =?us-ascii?Q?FRCJFS0UQihaD4pbM/EAUPZ8Qi/NyaO5LXzhSxFJGlA4bmLP9dNXOZhT/M3y?=
 =?us-ascii?Q?kgGrSwnSvBKR3BIMPUKQyhU3b2UBT0QOliZyuPX7PeXFqjeT0clfvWgRznVu?=
 =?us-ascii?Q?kCWIHftAM4+kbv8950PT+lAXw+U7eHQmtdzR/Otahm+6jzJCwEhUamDCzBT7?=
 =?us-ascii?Q?6P2+mxM6gTSlsvdluBoqdlbCRtdyWo8Ff/IUXATvd7PThxOcmGS4duAdr1BJ?=
 =?us-ascii?Q?KELqLn9MIa6/gItbyHMc5tLO0WaeXZwafKWr4ZSZVwHURiHNUGM/aWvEE2x/?=
 =?us-ascii?Q?3KCRCBDWsuk9UzvORVKTjaJPgg4WgsIt2QMqUcObq1uCsN39KnrKrV6gNbWM?=
 =?us-ascii?Q?tHgbqL0J55MH6ZWXIq33Ur7efrvHp3ddd9Q38+WNFdDxk8MYRDWSsQDEzfO3?=
 =?us-ascii?Q?FlZEbN9SZWlzy3Xe6KOzoXgJbXmR5x7vq7pC72HfVvDcxzCHssm6GuivDbQy?=
 =?us-ascii?Q?NvaRBjXjPLXUOCzE+ob+2QO3eVzsKrG+iSw1gHF89XJGReCo0K1B01c9DHHk?=
 =?us-ascii?Q?Pst3yH9XXop46z/SryfYWJNimrWztKF/1JdU2Vfo2tU9wuf5CMHCw4oAsjcX?=
 =?us-ascii?Q?axu3el80jw9BAIV2ggWsoyZllIqpk2Z7vbQD+4UUYZtGbbEuH98VPWwbPjH9?=
 =?us-ascii?Q?8gcrdTN855xdkc4riEscsVrIUkAd+VjHw1+O1dtIoFKnMR0EPxk5OK41zbeV?=
 =?us-ascii?Q?qfUFgbnKGLCXgW9hsM7R5GdXR2elc6q5THn6smFYeg4/DCCactCkf4D/w+Oo?=
 =?us-ascii?Q?BrSWZFYNwGH1T8KV4/9emAKUOgXd+VVCHDFk8TsowCPz0cpJ+oZBEBcJb3OW?=
 =?us-ascii?Q?Xcj7hJJpkloybne2Czqo2rLx1qRVY6ELKuJPYS3gZOQzxnAG23USyKE5/hsU?=
 =?us-ascii?Q?5DrQev/tU7CC0EumklNU0xDNowZz8einNnfY09rLatmjuqmGNQFzsGWH8uz2?=
 =?us-ascii?Q?GhTtgUOQiDhJ+ZHbalLK6Nw5YgWvgWUTS5mAzPzJg2d2e5UZ7ZWPEHz/udDa?=
 =?us-ascii?Q?oRAhOlgb7uGTLtGo8wooEX2wmMOLXLUqlNKjXG92PRlV72t4avRyk/T7y3w1?=
 =?us-ascii?Q?UeEQHQCk57i+gTV/ULnNfUMhmHC6Hu6aBUaCzOMBrD2fx4HUE/gwh2Ht9Kty?=
 =?us-ascii?Q?z1Kwly2+tUEJmDQOFFmEGFRCZjNkfV2+SNl65HJx?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 046969ee-3dc8-4226-a4f5-08da739ec7d0
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2022 09:18:22.2588
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zj5gOoLGRmCULyv8o3fxk3FcN+vZ4RIsyaDFSZSdGuktBDF4k/suFOxkp3tyMQYWxKYm2nr2cgfWBQ8QlKS7XbJyJ+3maBXb2k8ijcciKRs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB5961
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-01_05,2022-07-28_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999
 malwarescore=0 bulkscore=0 spamscore=0 phishscore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2208010044
X-Proofpoint-GUID: EXUDxOheEkxf1W9xCiPkNBTkPcm3b-k3
X-Proofpoint-ORIG-GUID: EXUDxOheEkxf1W9xCiPkNBTkPcm3b-k3
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jul 31, 2022 at 10:12:56AM -0700, Joe Perches wrote:
> > I'm happy of course to rewrite this to address any concerns, but
> > I was hoping I could clarify what you've said though? Apologies if I've
> > missed it, but how is this function now returning 1 on success? It sets
> > ret to 0 (success) at the start and then sets it to one of two negative
> > error codes depending on what happens. Am I missing something here?
> > (Perfectly possible that I am).
> > 
> > In terms of do nothing gotos, do you mean gotos that just set an error
> > code then jump to the end? If you'd prefer, as the function just returns
> > right after the exit label, I can just return the codes directly and have
> > a 'return 0;' like you say above?
> > 
> > Thanks as always for your insight.
> 
> Yes, you've got it right.
> 
> I think Dan is suggesting something like the below, but
> not necessarily in a single patch:

I always like your style, Joe.

regards,
dan carpenter