Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp1892072imn; Mon, 1 Aug 2022 04:12:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR7fsUSuOouZju5XHAFLheNY3AsyXYn9mNm7f8OulheCcYdk1nA28jjCwiYjvkipE/RtT1qP X-Received: by 2002:a05:6402:270d:b0:43a:67b9:6eea with SMTP id y13-20020a056402270d00b0043a67b96eeamr12909963edd.94.1659352358888; Mon, 01 Aug 2022 04:12:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659352358; cv=none; d=google.com; s=arc-20160816; b=DWTdOo75CvayKP4JE0PTJa/F7zTBwC0Dp2gaayRt7GsFWO4gYeWBnHBFJ94xlPxsnV zEXWc3HwIB5X/1rnTj6MJExx2LdtLj0tG6o+/qPmrWkbd00RZhOg75rk2s2KhEhb1z0v o3riiQFjVv7erHtNfyz68SkqoUtKWVChoF3y7hWJaY9TxSEPODeq6IaJ0Eh59Bcs8QHj zZrreG5blPgGlt3iGsN6DKj9dknyP7zcVlgdsZJ0DFfHCelfgRAH2JAxvQNqA8wrpxzT 9uM8RDWFRZ/hcEDquXoXQjDmt0ufymkcdI03Py39ygZzEics3j6R4+YjDZ6kZD524GpK 79qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=E6tzHitojhjUFSZmmsLg+hWiSrkksYqGDPuIHe7lM+I=; b=ThhYumNjnleTfuFZx0c1msSeuTaiJk4pvX36t1AtK2bt0i3iChmse4xmxDKRjVkHxT XiEd4nFtGx+mZKz8j+dif/XpsIo/ux9VceyBm2LTkFvg7CHZX5FcE+lCsg2au2HhZObL FxERXTrQxIZ4+RW1SdTijtYvjI/KS691oryOn9iA7eRe40URPKFqO+oW4dgrOiUzZBbJ lYhvWGpMmE8hFlSgVEcJdtYQEYrRF+JKp5IJG9oxJUtLnCGQ1nkZ8f0/NwRsruCf1mpL KuSci33luecVbXDRASwxeNmNGHdLc9uFoE+AxzBhb+Gf6zjvkwEwasEbZG61Nbr8TgNb 4CMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=M2HFP7Za; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d1-20020a056402144100b0043d4055d6a2si5486872edx.290.2022.08.01.04.12.14; Mon, 01 Aug 2022 04:12:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=M2HFP7Za; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229965AbiHAKYJ (ORCPT + 99 others); Mon, 1 Aug 2022 06:24:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229664AbiHAKYI (ORCPT ); Mon, 1 Aug 2022 06:24:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EDAA2FA; Mon, 1 Aug 2022 03:24:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2BEB061160; Mon, 1 Aug 2022 10:24:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C783C433D6; Mon, 1 Aug 2022 10:24:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1659349446; bh=aZ5KzaP2kedlbYW3tFmm//ddOrI7TYRpUXxPO9v7KlU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M2HFP7ZaVHaYxu0hQciwzi/nzE3T0b/0margR75eCj7z/YgWoMkoWtpvaRXw+MdyH M2BJA54FAtA5+FdsQS7oiDMNMmX6pTloBd6ojxseqdSeOn75NQ8XIn5M9qQPQVpzym LSaiQnkqo6Yd8rIz7Jx+xUtNddCy9WlbZfOfyoC4= Date: Mon, 1 Aug 2022 12:24:03 +0200 From: Greg KH To: Siddh Raman Pant Cc: Dipanjan Das , syzbot+c70d87ac1d001f29a058 , linux-kernel-mentees , linux-security-modules , linux-kernel , David Howells , Eric Dumazet , Christophe JAILLET , "Fabio M. De Francesco" Subject: Re: [PATCH v3] kernel/watch_queue: Make pipe NULL while clearing watch_queue Message-ID: References: <20220728155121.12145-1-code@siddh.me> <18258c1d370.6c4bec7a269297.4170944235031209431@siddh.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18258c1d370.6c4bec7a269297.4170944235031209431@siddh.me> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Mon, Aug 01, 2022 at 03:04:33PM +0530, Siddh Raman Pant via Linux-kernel-mentees wrote: > Hello Dipanjan, > > It would be nice if you could test this patch and tell if it fixes the > issue on v5.10, as you had reported it earlier. > > Please apply the following commits before applying this patch: > db8facfc9faf ("watch_queue, pipe: Free watchqueue state after clearing pipe ring") > 353f7988dd84 ("watchqueue: make sure to serialize 'wqueue->defunct' properly") > > I have tested locally on tag v5.10, using the reproducer available on > syzkaller dashboard. The crash occurred when the patches weren't applied, > and it no longer occurs after applying the three patches. Trying anything on tag v5.10 is not a good test as that kernel is very old and obsolete and over 15000 changes behind what the latest 5.10.y kernel release has in it. So trying it on v5.10.134 would be best. thanks, greg k-h