Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 1 Aug 2022 14:21:26 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc:     Forest Bond <forest@alittletooquiet.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] staging: vt6655: Create one function for four macros
Message-ID: <20220801112126.GB3438@kadam>
References: <cover.1659192760.git.philipp.g.hortmann@gmail.com>
 <d4768227a7ea10ccec6d08eb0c55f8790ef70379.1659192760.git.philipp.g.hortmann@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d4768227a7ea10ccec6d08eb0c55f8790ef70379.1659192760.git.philipp.g.hortmann@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XBu+T0iccy43JvSekwMlcXguPwLgLTRrKHbZS2wy3NEQo5yNO6W194O6Yx/n?=
 =?us-ascii?Q?ni3IXJHqaXQI6xA4iwPi951vaF3BaiWe4rCFZpF2UL9na/vt5G76Lwj2F68d?=
 =?us-ascii?Q?ra6a9gofBXuMfv8OqIMIjU1niFJU3hRB/wsjH5H311FR91VvuS4g7DGRPT6H?=
 =?us-ascii?Q?N/PF7LUfcicN8CmrzYgaU7HbNdJB4/o1BN4KZoWUiOtb1Tm1U2c7Al8/CigH?=
 =?us-ascii?Q?TBOdR2cwaz7p901fZmJ/PhUQvOPdan8+DruYeezye8a7LdPGUuOUg1jwxx7+?=
 =?us-ascii?Q?aOZKW0DxmL3AZEaV+L0OLhDweLteH57DkuFk4woZ1rQbWd9xKfLEAmuFi5aC?=
 =?us-ascii?Q?LpzB44Myls2q+bvG3unmmyelnILfBKGkYCVWDfmqKX4Y4wZCZDI7vUeyY2xa?=
 =?us-ascii?Q?V6fYSdLKAh8tvzmGW5u9XcUQnPxvRzytwPbI+hSMadaO+DslQppumu9JCrEQ?=
 =?us-ascii?Q?teoUV0wlWD/La73sBAwFlZztw62jZojU/GhPrncnWREh8tQR8Zqtpp17l1Zs?=
 =?us-ascii?Q?ByFlxF1UfAAJkMJuu8zNBNpAobrnhETXRpiv25K4f6AJhw3QXNgwYLsiBmhN?=
 =?us-ascii?Q?lIoZfzjMGJ6GAkyubVmwyQ1BVhPinvLJZDgey2BSpXKuzsqhW50v5flbp/Tp?=
 =?us-ascii?Q?gRdNIlVd/HoJvyLqTSCCyM8ek4l90ckb9tBPG7AZzJsMWNDNDRFmGLN5Q8+v?=
 =?us-ascii?Q?lLqjRHN1k3aFrTnmzexRsTDb3ETz39C7CR9/abSGjGXRr+iKYmr3NPpZPXd4?=
 =?us-ascii?Q?bFWJIBZCcUegMhXAeN0ufgd9XGnwcUr0DOb9DcbQbiaA6E9bCQRic84InrD9?=
 =?us-ascii?Q?XEjL2Ys7L410DXauPSG1eQyIkzh2nrK/48IW9gxQMLeE+f0tObFXCrCDPgzF?=
 =?us-ascii?Q?3rhRR85LvXdSu4ahP8Aa3s5C4Vrnkh867w9ZL7oS+0Nv+uC9xhNgqOXq/aXH?=
 =?us-ascii?Q?2soQbG3ei+VGXBv5CXj7fzfI45P8FX8ZGuHW8xZwUqd/zvBDFDJzpQk4dtYF?=
 =?us-ascii?Q?qFBeCT5KupjDTay1QbSH9574W0pcAj6A/9hDHIBJVYO3Z9jqkNRm291wzwpt?=
 =?us-ascii?Q?vFNqzMalimZ9m4icwqH3q0mEtt2IvyP6tviR2cFFIu1N1UXctGYxI1mVw6S9?=
 =?us-ascii?Q?ZOZnyf8HrlnF7UUL5xfVV/NuJt+KdB/eNpDTyAFVucgOLHdsOp6MC7YGO7WS?=
 =?us-ascii?Q?gPk8tQxAUOYYtviqxliF8wpQtr/tGHU0cm7hnTVPNbHkv2SSBv8L7qn12V4K?=
 =?us-ascii?Q?rRwg9OP00/5gk598cE014e8hnKdQtD1Y+T/dTCa4aO9VbxeWdRm+GSBFxmR7?=
 =?us-ascii?Q?ELLIoy+I9Sy6hCvmvMVsZaBdrBfVP2muShwqgv1zyeXs3PUH6/llcYyDpnmN?=
 =?us-ascii?Q?ms8ILT5FbnGXU7w2e+PSwAMDYUrbJfPm1SXDavhjaKNjHjWbOtN19LS/frtL?=
 =?us-ascii?Q?klWfZ4tJf6xi9Kw/nYa8wsbJBXbPswXgpi9M/V7QEOjwFyuWVObzuvqYQCSf?=
 =?us-ascii?Q?lFMihPr27KJZzwLgSpM2ylumhKn8ZDQgHvL0+aN876dsb0Fota4znGFT6u9K?=
 =?us-ascii?Q?8fiFBw+gKaPlve0jWC2FOspAmBOVomQNTYeNn7y0xtu37IN0Lu+n7ToH0B3x?=
 =?us-ascii?Q?XQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a6c03c2-602d-4201-bb00-08da73b00b8a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2022 11:21:57.3144
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aYEin4G9iIilH1xe6jKu10el2+GXfxyAxKhRvpuTxzC5oX0T9PCkLrv2m3pTDAKPG6k4OPGeXK8saFsfh1fN7DZv+lbWYwVekwR3eHxn7iM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3274
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-01_05,2022-08-01_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2208010056
X-Proofpoint-ORIG-GUID: I6A7NsL-qS4v0bmq4-wGCe3Mx6CXHYfq
X-Proofpoint-GUID: I6A7NsL-qS4v0bmq4-wGCe3Mx6CXHYfq
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jul 30, 2022 at 09:20:30PM +0200, Philipp Hortmann wrote:
> Create function vt6655_mac_en_dis_bits_u32_reg with three parameters to
> cover functionality of four macros.
> 
> Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
> ---
>  drivers/staging/vt6655/device_main.c | 12 ++++++++++--
>  drivers/staging/vt6655/mac.h         |  3 +++
>  2 files changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 3565aa53f007..5f64204dc312 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -216,15 +216,23 @@ static void vt6655_mac_dma_ctl(void __iomem *iobase, u8 reg_index)
>  		iowrite32(DMACTL_RUN, iobase + reg_index);
>  }
>  
> -static void MACvEnableProtectMD(void __iomem *iobase)
> +static void vt6655_mac_en_dis_bits_u32_reg(void __iomem *iobase, bool en_not_dis, u32 bit_mask)

Never have "not" in a variable name.  Just make this two functions.

static void vt6655_mac_set_bits(void __iomem *iobase, u32 mask)
static void vt6655_mac_clear_bits(void __iomem *iobase, u32 mask)

Rename "bit_mask" to "mask" or "bits" because bit masks are the only type
of mask that there is in the kernel.

regards,
dan carpenter