Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 01 Aug 2022 08:47:40 -0300
From:   Logan Gunthorpe <logang@deltatee.com>
To:     Song Liu <song@kernel.org>, Christoph Hellwig <hch@infradead.org>
CC:     open list <linux-kernel@vger.kernel.org>,
        linux-raid <linux-raid@vger.kernel.org>,
        Guoqing Jiang <guoqing.jiang@linux.dev>,
        Stephen Bates <sbates@raithlin.com>,
        Martin Oliveira <Martin.Oliveira@eideticom.com>,
        David Sloan <David.Sloan@eideticom.com>
User-Agent: K-9 Mail for Android
In-Reply-To: <CAPhsuW4jtiuNPzC2aK-Jo80X15AWdYi7HQ2n7YWqVP6Uux3hYg@mail.gmail.com>
References: <20220727210600.120221-1-logang@deltatee.com> <20220727210600.120221-2-logang@deltatee.com> <YuKZmloAcZWY5of8@infradead.org> <CAPhsuW4jtiuNPzC2aK-Jo80X15AWdYi7HQ2n7YWqVP6Uux3hYg@mail.gmail.com>
Message-ID: <215E9FEF-69F9-44AB-A5B0-FD3C8335E985@deltatee.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH 1/5] md/raid5: Refactor raid5_get_active_stripe()
Precedence: bulk


On July 29, 2022 7:48:48 PM ADT, Song Liu <song@kernel=2Eorg> wrote:
>On Thu, Jul 28, 2022 at 7:13 AM Christoph Hellwig <hch@infradead=2Eorg> w=
rote:
>>
>> On Wed, Jul 27, 2022 at 03:05:56PM -0600, Logan Gunthorpe wrote:
>> > Refactor the raid5_get_active_stripe() to read more linearly in
>> > the order it's typically executed=2E
>> >
>> > The init_stripe() call is called if a free stripe is found and the
>> > function is exited early which removes a lot of if (sh) checks and
>> > unindents the following code=2E
>> >
>> > Remove the while loop in favour of the 'goto retry' pattern, which
>> > reduces indentation further=2E And use a 'goto wait_for_stripe' inste=
ad
>> > of an additional indent seeing it is the unusual path and this makes
>> > the code easier to read=2E
>> >
>> > No functional changes intended=2E Will make subsequent changes
>> > in patches easier to understand=2E
>>
>> I find the new loop even more confusing than the old one=2E  I'd go
>> with something like the version below (on top of the whol md-next tree
>> that pulled this in way too fast=2E=2E)
>
>This looks good to me=2E Christoph, would you mind send official patch
>for this?
>
>Thanks,
>Song

I'm on vacation this week, but I'd be happy to send patches addressing Chr=
istoph's feedback when I'm back next week=2E

Thanks,

Logan