Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp1942525imn; Mon, 1 Aug 2022 05:53:11 -0700 (PDT) X-Google-Smtp-Source: AA6agR5B47kXHsAWdd+Ey8xBfFUAy5Nj83CcxxeDHm+n7c1h12HB6nyLTIw4VaDRBxU7tIuqyxgc X-Received: by 2002:a05:6402:ea7:b0:43a:ecea:76e with SMTP id h39-20020a0564020ea700b0043aecea076emr2187238eda.77.1659358391016; Mon, 01 Aug 2022 05:53:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659358391; cv=none; d=google.com; s=arc-20160816; b=pNBim1XyPqbfu26D1s88sICwXeGQQzeBGQSpcVFB6OhtwLr1tC0qCz+pykUurcW5V1 bF5mTkyH/3TmpTjV/v2iH7sse4vUZYwZYIoPt+eBos0S/pj/LYVa2dKSzXhO/A194wWT j1EC9ewu0lsjIRVfT2tc9bz4nmVDN8ihq9GW7tKET/rJwuCJQ5Hmxe/dV1PAO2jT6IPB y9hI5gCUoIL+ZzSi3zugYYIsJ0+TduwtM0OQHfL9hrQM3iYq6jjIS8H8XZAErSeV8W9t T7qpLjvKWBBwfY6jCsfDPk8g4weXOhT3LAEYEae2719MgBE6n838HgmhZ89hBB63ToRV XDXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=XzCa2G3Dh7j5zo9aDn5U5gt/WBQ+zre/qdFm18dN0vc=; b=SOW1uJ/O4tVXT8Jf+nj4En1SOcUgw6lPYrB91v6Jnt+w2JXLw9rw4X6fWwJnBziY1l MGRmiSTUECXPbC4XQJzJOx7CN3/90DdoaalEF5lvtNlyUuZlxastlyiiduzJFhpNgoD0 0geJHeBWcN1FHUX1WTr/IihVqX0FTE5z+zMoVG1QLdxI2dCQqAiRp1u1NmikzPvZ+AVs Mg2NHWWIjmdDim0/x8BKiJhB2JIMFIWvg8Yi2LZkN7hzlytLE0WgYH1R8Stu0ql/up4G fqZge8e3ZJMrCyFeJ3QOm8CJEZWORi/NQ5z/waKcAWtCbGZc10k8kvih3zNNIxcXB9fT MtSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aUEE1F8N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id vf17-20020a170907239100b0072ee6c76e3esi8142760ejb.790.2022.08.01.05.52.45; Mon, 01 Aug 2022 05:53:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aUEE1F8N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233408AbiHAMEv (ORCPT + 99 others); Mon, 1 Aug 2022 08:04:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232939AbiHAMEP (ORCPT ); Mon, 1 Aug 2022 08:04:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 783CB20F74; Mon, 1 Aug 2022 04:54:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B701AB80E8F; Mon, 1 Aug 2022 11:54:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29CF6C433C1; Mon, 1 Aug 2022 11:54:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1659354858; bh=SA4mr/GOqmBjYbqizDfuGgHUp55u4FM5kuYkl1VLvSQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aUEE1F8Ne7abkIyxxkN9r1PwawUlE1jTB2UbUR+dxnQuOEgeMiJ2a3sr0wTOSNAcE 8K5qm2Y4jfWQHiIp0FC/gBbcEbUEslB2OudL83GfJARw5wfQNroLxWzDGqGsvxnqbi vQVuPSQecQ9RTbgZO28sd3L6w2s6uYqmAnvK3ryg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kuniyuki Iwashima , "David S. Miller" Subject: [PATCH 5.15 15/69] tcp: Fix a data-race around sysctl_tcp_app_win. Date: Mon, 1 Aug 2022 13:46:39 +0200 Message-Id: <20220801114135.101281639@linuxfoundation.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220801114134.468284027@linuxfoundation.org> References: <20220801114134.468284027@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kuniyuki Iwashima commit 02ca527ac5581cf56749db9fd03d854e842253dd upstream. While reading sysctl_tcp_app_win, it can be changed concurrently. Thus, we need to add READ_ONCE() to its reader. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Kuniyuki Iwashima Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv4/tcp_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -526,7 +526,7 @@ static void tcp_grow_window(struct sock */ static void tcp_init_buffer_space(struct sock *sk) { - int tcp_app_win = sock_net(sk)->ipv4.sysctl_tcp_app_win; + int tcp_app_win = READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_app_win); struct tcp_sock *tp = tcp_sk(sk); int maxwin;