Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Matthew Wilcox <willy@infradead.org>,
        Viacheslav Dubeyko <slava@dubeyko.com>,
        Ira Weiny <ira.weiny@intel.com>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hfsplus: Convert kmap() to kmap_local_page() in bitmap.c
Date:   Mon, 01 Aug 2022 14:56:42 +0200
Message-ID: <2117828.irdbgypaU6@opensuse>
In-Reply-To: <5834FD23-A333-40B7-9678-43E61986512E@dubeyko.com>
References: <20220724205007.11765-1-fmdefrancesco@gmail.com> <Yt7Y6so92vXTOI+Q@casper.infradead.org> <5834FD23-A333-40B7-9678-43E61986512E@dubeyko.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Precedence: bulk

On marted=C3=AC 26 luglio 2022 20:40:29 CEST Viacheslav Dubeyko wrote:
>=20
> > On Jul 25, 2022, at 10:54 AM, Matthew Wilcox <willy@infradead.org>=20
wrote:
> >=20
> > On Mon, Jul 25, 2022 at 10:17:13AM -0700, Viacheslav Dubeyko wrote:
> >> Looks good. Maybe, it makes sense to combine all kmap() related=20
modifications in HFS+ into
> >> one patchset?
> >=20
> > For bisection, I'd think it best to leave them separate?
>=20
> I am OK with any way. My point that it will be good to have patchset to=20
see all modified places together, from logical point of view. Even if we=20
have some issue with kmap() change on kmap_local_page(), then, as far as I=
=20
can see, the root of issue should be kmap_local_page() but not HFS+ code.=20
Oppositely, if it=E2=80=99s some undiscovered HFS+ issue, then again=20
kmap_local_page() changes nothing. But I am OK if it is separate patches=20
too.
>=20
> Thanks,
> Slava.
>=20
And I am OK with sending a patchset :-)

I'm sorry because, while working on the last conversions for HFS+ in=20
btree.c, I just noticed that I had overlooked one other kmap() call site in=
=20
bitmap.c.

Therefore, I'd like to ask to drop this patch and I'll also ask to drop the=
=20
patch to bnode.c in the related thread.=20

When done, I'll send a series of three patches, one per file (bnode.c,=20
bitmap.c, btree.c).

Thanks,

=46abio